diff mbox series

[3/7] sim/erc32: Add ATTRIBUTE_PRINTF

Message ID 7348f2c7752509c5f784b04a40ffec029d6bc559.1664095452.git.research_trasio@irq.a4lg.com
State Superseded
Headers
Series sim, sim/ARCH: Add ATTRIBUTE_PRINTF |

Commit Message

Tsukasa OI Sept. 25, 2022, 8:44 a.m. UTC 
  Clang generates a warning if the format string of a printf-like function is
not a literal ("-Wformat-nonliteral").  On the default configuration, it
causes a build failure (unless "--disable-werror" is specified).

To avoid warnings on the printf-like wrapper, it requires proper
__attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason.

This commit adds ATTRIBUTE_PRINTF to the printf-like functions.

sim/ChangeLog:

	* erc32/interf.c (fprintf_styled): Add ATTRIBUTE_PRINTF.
	* erc32/sis.c (fprintf_styled): Likewise.
---
 sim/erc32/interf.c | 2 +-
 sim/erc32/sis.c    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/sim/erc32/interf.c b/sim/erc32/interf.c
index f433b9d55ac..fe8e9e822dd 100644
--- a/sim/erc32/interf.c
+++ b/sim/erc32/interf.c
@@ -156,7 +156,7 @@  run_sim(struct pstate *sregs, uint64_t icount, int dis)
     return TIME_OUT;
 }
 
-static int
+static int ATTRIBUTE_PRINTF(3, 4)
 fprintf_styled (void *stream, enum disassembler_style style,
 		const char *fmt, ...)
 {
diff --git a/sim/erc32/sis.c b/sim/erc32/sis.c
index 1d3ea139c23..d66f5c4dc9e 100644
--- a/sim/erc32/sis.c
+++ b/sim/erc32/sis.c
@@ -138,7 +138,7 @@  run_sim(struct pstate *sregs, uint64_t icount, int dis)
     return TIME_OUT;
 }
 
-static int
+static int ATTRIBUTE_PRINTF(3, 4)
 fprintf_styled (void *stream, enum disassembler_style style,
 		const char *fmt, ...)
 {