From patchwork Sun Sep 25 08:44:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tsukasa OI X-Patchwork-Id: 57998 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D2BF23858024 for ; Sun, 25 Sep 2022 08:44:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D2BF23858024 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1664095499; bh=tUkaH14dbWJpB1zUS3U+ZW0mCCJBy0ZlHso7E2z8bY8=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=W868wKt0EozIxf9tIkU68y8WDvo84UhgdI0y4DcfuVpdGMYYMX3J030/p8GHgjeDE UYI5e5in3ua2UWMlDzhIN4wMCduZi31zbeFK37G4xuU/4Xv8NUR9qdh4u+4MXSnMXh +szVwM0vawfA4pBSzEIv5Qj1SeSDrXkl2o/I42G8= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id DE8AB385829A for ; Sun, 25 Sep 2022 08:44:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DE8AB385829A Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 3A4AD300089; Sun, 25 Sep 2022 08:44:35 +0000 (UTC) To: Tsukasa OI , Andrew Burgess , Mike Frysinger , Stephane Carrez , "Frank Ch . Eigler" Subject: [PATCH 1/7] sim: Add ATTRIBUTE_PRINTF Date: Sun, 25 Sep 2022 08:44:11 +0000 Message-Id: In-Reply-To: References: Mime-Version: 1.0 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tsukasa OI via Gdb-patches From: Tsukasa OI Reply-To: Tsukasa OI Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Clang generates a warning if the format string of a printf-like function is not a literal ("-Wformat-nonliteral"). On the default configuration, it causes a build failure (unless "--disable-werror" is specified). To avoid warnings on the printf-like wrapper, it requires proper __attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason. This commit adds ATTRIBUTE_PRINTF to a printf-like function. sim/ChangeLog: * common/sim-cpu.h (sim_io_eprintf_cpu): Add ATTRIBUTE_PRINTF. --- sim/common/sim-cpu.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sim/common/sim-cpu.h b/sim/common/sim-cpu.h index d8b2b9c494a..024eb31d79a 100644 --- a/sim/common/sim-cpu.h +++ b/sim/common/sim-cpu.h @@ -137,7 +137,8 @@ extern sim_cpu *sim_cpu_lookup (SIM_DESC, const char *); /* Return prefix to use in cpu specific messages. */ extern const char *sim_cpu_msg_prefix (sim_cpu *); /* Cover fn to sim_io_eprintf. */ -extern void sim_io_eprintf_cpu (sim_cpu *, const char *, ...); +extern void sim_io_eprintf_cpu (sim_cpu *, const char *, ...) + ATTRIBUTE_PRINTF (2, 3); /* Get/set a pc value. */ #define CPU_PC_GET(cpu) ((* CPU_PC_FETCH (cpu)) (cpu)) From patchwork Sun Sep 25 08:44:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tsukasa OI X-Patchwork-Id: 57999 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E890338582B3 for ; Sun, 25 Sep 2022 08:45:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E890338582B3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1664095515; bh=UDkKKvwh6pJpQo7Rn2o4G0l+PXB0QHTJnDDeAJwZPc0=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=kPYurzkHO1Nn0QM1Ci/DBlnP66EIPMinhEjZ4rsfOU6tBVyuuMGKuZkZWggIbZGNp vmGKG7f1QCOYc/hWiN/XPio7PDjkLlHeLaPIhzXwFhKzaltvnivD2pc4D6Nm9xFe0b +U3wRtvO95HFkb1etoBgAN2Her51YFcoRtcfzUh0= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id 6EB7C385828F for ; Sun, 25 Sep 2022 08:44:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6EB7C385828F Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id BA7A2300089; Sun, 25 Sep 2022 08:44:45 +0000 (UTC) To: Tsukasa OI , Andrew Burgess , Mike Frysinger , Stephane Carrez , "Frank Ch . Eigler" Subject: [PATCH 2/7] sim/cris: Add ATTRIBUTE_PRINTF Date: Sun, 25 Sep 2022 08:44:12 +0000 Message-Id: <933c98735904e8558f36bc042bf90a8448962182.1664095452.git.research_trasio@irq.a4lg.com> In-Reply-To: References: Mime-Version: 1.0 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tsukasa OI via Gdb-patches From: Tsukasa OI Reply-To: Tsukasa OI Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Clang generates a warning if the format string of a printf-like function is not a literal ("-Wformat-nonliteral"). On the default configuration, it causes a build failure (unless "--disable-werror" is specified). To avoid warnings on the printf-like wrapper, it requires proper __attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason. This commit adds ATTRIBUTE_PRINTF to a printf-like function. sim/ChangeLog: * cris/traps.c (cris_unknown_syscall): Add ATTRIBUTE_PRINTF. --- sim/cris/traps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sim/cris/traps.c b/sim/cris/traps.c index 8750c4d4e3c..3cbbe4088e5 100644 --- a/sim/cris/traps.c +++ b/sim/cris/traps.c @@ -1382,7 +1382,7 @@ make_first_thread (SIM_CPU *current_cpu) /* Handle unknown system calls. Returns (if it does) the syscall return value. */ -static USI +static USI ATTRIBUTE_PRINTF(3, 4) cris_unknown_syscall (SIM_CPU *current_cpu, USI pc, char *s, ...) { SIM_DESC sd = CPU_STATE (current_cpu); From patchwork Sun Sep 25 08:44:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tsukasa OI X-Patchwork-Id: 58000 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D3271385800B for ; Sun, 25 Sep 2022 08:45:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D3271385800B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1664095520; bh=CjYYNYQmYyK+g9Oy16rXjkTPWgaob02C2TOQ1sGBoyI=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=SWwqBwuSKWLS9jlXg6smLFynFSaS2UOw70Z16vNO7L1X5qKSVp/F6Z7Mll4ehs7fH SK3jFynnvVk0q6nkCpl8VXWhYlJZxbqp709/48Hj6Y3MUv77k6Y4rJbh6RCGuNJWO6 7Vvql/MSiGcPrDOGux1vJw1pFCwARZfqtssvpJv0= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id 05CBB3858284 for ; Sun, 25 Sep 2022 08:44:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 05CBB3858284 Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 4660B300089; Sun, 25 Sep 2022 08:44:56 +0000 (UTC) To: Tsukasa OI , Andrew Burgess , Mike Frysinger , Stephane Carrez , "Frank Ch . Eigler" Subject: [PATCH 3/7] sim/erc32: Add ATTRIBUTE_PRINTF Date: Sun, 25 Sep 2022 08:44:13 +0000 Message-Id: <7348f2c7752509c5f784b04a40ffec029d6bc559.1664095452.git.research_trasio@irq.a4lg.com> In-Reply-To: References: Mime-Version: 1.0 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tsukasa OI via Gdb-patches From: Tsukasa OI Reply-To: Tsukasa OI Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Clang generates a warning if the format string of a printf-like function is not a literal ("-Wformat-nonliteral"). On the default configuration, it causes a build failure (unless "--disable-werror" is specified). To avoid warnings on the printf-like wrapper, it requires proper __attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason. This commit adds ATTRIBUTE_PRINTF to the printf-like functions. sim/ChangeLog: * erc32/interf.c (fprintf_styled): Add ATTRIBUTE_PRINTF. * erc32/sis.c (fprintf_styled): Likewise. --- sim/erc32/interf.c | 2 +- sim/erc32/sis.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sim/erc32/interf.c b/sim/erc32/interf.c index f433b9d55ac..fe8e9e822dd 100644 --- a/sim/erc32/interf.c +++ b/sim/erc32/interf.c @@ -156,7 +156,7 @@ run_sim(struct pstate *sregs, uint64_t icount, int dis) return TIME_OUT; } -static int +static int ATTRIBUTE_PRINTF(3, 4) fprintf_styled (void *stream, enum disassembler_style style, const char *fmt, ...) { diff --git a/sim/erc32/sis.c b/sim/erc32/sis.c index 1d3ea139c23..d66f5c4dc9e 100644 --- a/sim/erc32/sis.c +++ b/sim/erc32/sis.c @@ -138,7 +138,7 @@ run_sim(struct pstate *sregs, uint64_t icount, int dis) return TIME_OUT; } -static int +static int ATTRIBUTE_PRINTF(3, 4) fprintf_styled (void *stream, enum disassembler_style style, const char *fmt, ...) { From patchwork Sun Sep 25 08:44:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tsukasa OI X-Patchwork-Id: 58002 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4E9A2385828F for ; Sun, 25 Sep 2022 08:45:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4E9A2385828F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1664095546; bh=1WK1ezOpYCeZAsBaWAwmcPnXOzO2uoW13GDkHpaHZ6s=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Tw5D7TuTiIPtw7cGhQ7H0f08r3xZuIznKEKzr9tDh1C+Dk/S2hbXh08tdYp/YFctj L6lSaiR9BWigIlJwKXacOcGWMK5maGCGgl3zHlLRru47YLKJReu1RVubYJeq1NzXoO FL/UFFGzksLoDbAhyAIlaU5ifFueLxr7hH2qLvZg= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id 8AAF7385840C for ; Sun, 25 Sep 2022 08:45:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8AAF7385840C Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id CC9A5300089; Sun, 25 Sep 2022 08:45:06 +0000 (UTC) To: Tsukasa OI , Andrew Burgess , Mike Frysinger , Stephane Carrez , "Frank Ch . Eigler" Subject: [PATCH 4/7] sim/m32c: Add ATTRIBUTE_PRINTF Date: Sun, 25 Sep 2022 08:44:14 +0000 Message-Id: In-Reply-To: References: Mime-Version: 1.0 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tsukasa OI via Gdb-patches From: Tsukasa OI Reply-To: Tsukasa OI Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Clang generates a warning if the format string of a printf-like function is not a literal ("-Wformat-nonliteral"). On the default configuration, it causes a build failure (unless "--disable-werror" is specified). To avoid warnings on the printf-like wrapper, it requires proper __attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason. This commit adds ATTRIBUTE_PRINTF to the printf-like functions. sim/ChangeLog: * m32c/trace.c (op_printf, op_styled_printf): Add ATTRIBUTE_PRINTF. --- sim/m32c/trace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sim/m32c/trace.c b/sim/m32c/trace.c index 1888e69122b..0aa4440cade 100644 --- a/sim/m32c/trace.c +++ b/sim/m32c/trace.c @@ -89,7 +89,7 @@ compare_symbols (const void *ap, const void *bp) static char opbuf[1000]; -static int +static int ATTRIBUTE_PRINTF(2, 3) op_printf (char *buf, char *fmt, ...) { int ret; @@ -101,7 +101,7 @@ op_printf (char *buf, char *fmt, ...) return ret; } -static int +static int ATTRIBUTE_PRINTF(3, 4) op_styled_printf (char *buf, enum disassembler_style style, char *fmt, ...) { int ret; From patchwork Sun Sep 25 08:44:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tsukasa OI X-Patchwork-Id: 58001 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 48CA63858029 for ; Sun, 25 Sep 2022 08:45:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 48CA63858029 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1664095544; bh=REIoVI6ZRfSTUW5o/sHfzLqzuoXG5uerheJGDcVhgqM=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=n6Majy4ua7FOOPqodJJue/ZcDseekBtYNKYUXbT6y9VdgX0kGvwq6TGXe7oo0fYSm U2ZglK5AjmhoOkanVnmpnlHxRfVee56zHzzTJRCZg5PoLZvwOvOn4o5IqwAfTzsphB tUOVIj7/m2lBUXsGNgZXhk8blex3PbJ8usmyI9L4= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id 2137B38582BF for ; Sun, 25 Sep 2022 08:45:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2137B38582BF Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 58240300089; Sun, 25 Sep 2022 08:45:17 +0000 (UTC) To: Tsukasa OI , Andrew Burgess , Mike Frysinger , Stephane Carrez , "Frank Ch . Eigler" Subject: [PATCH 5/7] sim/m68hc11: Add ATTRIBUTE_PRINTF Date: Sun, 25 Sep 2022 08:44:15 +0000 Message-Id: In-Reply-To: References: Mime-Version: 1.0 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tsukasa OI via Gdb-patches From: Tsukasa OI Reply-To: Tsukasa OI Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Clang generates a warning if the format string of a printf-like function is not a literal ("-Wformat-nonliteral"). On the default configuration, it causes a build failure (unless "--disable-werror" is specified). To avoid warnings on the printf-like wrapper, it requires proper __attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason. This commit adds ATTRIBUTE_PRINTF to a printf-like function. sim/ChangeLog: * m68hc11/m68hc11_sim.c (sim_memory_error): Add ATTRIBUTE_PRINTF. * m68hc11/sim-main.h (sim_memory_error): Likewise. --- sim/m68hc11/m68hc11_sim.c | 2 +- sim/m68hc11/sim-main.h | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/sim/m68hc11/m68hc11_sim.c b/sim/m68hc11/m68hc11_sim.c index 6ec45f78206..3f73215f2e2 100644 --- a/sim/m68hc11/m68hc11_sim.c +++ b/sim/m68hc11/m68hc11_sim.c @@ -1017,7 +1017,7 @@ cpu_single_step (sim_cpu *cpu) } /* VARARGS */ -void +void ATTRIBUTE_PRINTF(4, 5) sim_memory_error (sim_cpu *cpu, SIM_SIGNAL excep, uint16_t addr, const char *message, ...) { diff --git a/sim/m68hc11/sim-main.h b/sim/m68hc11/sim-main.h index e667c33a705..b8e485ebe97 100644 --- a/sim/m68hc11/sim-main.h +++ b/sim/m68hc11/sim-main.h @@ -538,8 +538,9 @@ extern void cpu_return (sim_cpu *cpu); extern void cpu_set_sp (sim_cpu *cpu, uint16_t val); extern int cpu_reset (sim_cpu *cpu); extern int cpu_restart (sim_cpu *cpu); -extern void sim_memory_error (sim_cpu *cpu, SIM_SIGNAL excep, - uint16_t addr, const char *message, ...); +extern void sim_memory_error (sim_cpu *cpu, SIM_SIGNAL excep, uint16_t addr, + const char *message, ...) + ATTRIBUTE_PRINTF (4, 5); extern void emul_os (int op, sim_cpu *cpu); extern void cpu_interp_m6811 (sim_cpu *cpu); extern void cpu_interp_m6812 (sim_cpu *cpu); From patchwork Sun Sep 25 08:44:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tsukasa OI X-Patchwork-Id: 58004 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8FE4F38582B1 for ; Sun, 25 Sep 2022 08:46:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8FE4F38582B1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1664095571; bh=DPu3oQYWJWYRnxsYlnQi53IXiEqt9z+EGH7mBMHD9Nw=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=jlbJZ9GdjKYSQ4i2n6o0urKUTmO3MGKG/dOOrX9VQuSYx2lbBE0mo5mDD7n5/463o nO6tArSfSi0fxZL7OX4zQgOnk7jkgwbEmDhniWZvkKGHBdBlyNRdTdfAiLfHlENWmP zuJWSAapfS3zeo+ozZXHBrraeLBrRIAoMKTqotQI= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-sender-0.a4lg.com (mail-sender.a4lg.com [153.120.152.154]) by sourceware.org (Postfix) with ESMTPS id A94393857B8D for ; Sun, 25 Sep 2022 08:45:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A94393857B8D Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id E704B300089; Sun, 25 Sep 2022 08:45:27 +0000 (UTC) To: Tsukasa OI , Andrew Burgess , Mike Frysinger , Stephane Carrez , "Frank Ch . Eigler" Subject: [PATCH 6/7] sim/ppc: Add ATTRIBUTE_PRINTF Date: Sun, 25 Sep 2022 08:44:16 +0000 Message-Id: <924d86933d2e2b6da6940f13e64ef0ab5008a797.1664095452.git.research_trasio@irq.a4lg.com> In-Reply-To: References: Mime-Version: 1.0 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tsukasa OI via Gdb-patches From: Tsukasa OI Reply-To: Tsukasa OI Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Clang generates a warning if the format string of a printf-like function is not a literal ("-Wformat-nonliteral"). On the default configuration, it causes a build failure (unless "--disable-werror" is specified). To avoid warnings on the printf-like wrapper, it requires proper __attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason. This commit adds ATTRIBUTE_PRINTF to the printf-like functions. sim/ChangeLog: * ppc/main.c (error): Add ATTRIBUTE_PRINTF. * ppc/misc.c (error, dumpf): Likewise. * ppc/sim_calls.c (error): Likewise. --- sim/ppc/main.c | 2 +- sim/ppc/misc.c | 4 ++-- sim/ppc/sim_calls.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sim/ppc/main.c b/sim/ppc/main.c index 83b629ec14a..4a88166106f 100644 --- a/sim/ppc/main.c +++ b/sim/ppc/main.c @@ -68,7 +68,7 @@ sim_io_printf_filtered(const char *msg, ...) va_end(ap); } -void +void ATTRIBUTE_PRINTF(1, 2) error (const char *msg, ...) { va_list ap; diff --git a/sim/ppc/misc.c b/sim/ppc/misc.c index 8f2581e3ef3..71cda9fa298 100644 --- a/sim/ppc/misc.c +++ b/sim/ppc/misc.c @@ -28,7 +28,7 @@ #include #include -void +void ATTRIBUTE_PRINTF(1, 2) error (const char *msg, ...) { va_list ap; @@ -48,7 +48,7 @@ zalloc(long size) return memory; } -void +void ATTRIBUTE_PRINTF(2, 3) dumpf (int indent, const char *msg, ...) { va_list ap; diff --git a/sim/ppc/sim_calls.c b/sim/ppc/sim_calls.c index fbc327c94e0..b0ed3d4c3cc 100644 --- a/sim/ppc/sim_calls.c +++ b/sim/ppc/sim_calls.c @@ -388,7 +388,7 @@ sim_io_error (SIM_DESC sd, const char *fmt, ...) /****/ -void ATTRIBUTE_NORETURN +void ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF(1, 2) error (const char *msg, ...) { va_list ap; From patchwork Sun Sep 25 08:44:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tsukasa OI X-Patchwork-Id: 58003 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D342D3857B8A for ; Sun, 25 Sep 2022 08:46:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D342D3857B8A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1664095562; bh=NIhPm5JMzj6ctGVoQp9vqfmfGD2Pds3t/wDVYf2KjQo=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=DcKl+9u+zohuxbfvzYViUTHLA2iXTweTwxTqdOqejPL5fRz17ERKxzMPLvvrDvQQx 00mi8CT+vsWPz8rgXqepV6N4f93j1pk8iNzHr9W5ly3WNlQ4VPlhaD8afjW7ttqHHZ Ho8C3RvA0F8i7DfDlRbY8GPhO+7qpwMjV4abS4pM= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id 334C83858028 for ; Sun, 25 Sep 2022 08:45:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 334C83858028 Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 81F86300089; Sun, 25 Sep 2022 08:45:38 +0000 (UTC) To: Tsukasa OI , Andrew Burgess , Mike Frysinger , Stephane Carrez , "Frank Ch . Eigler" Subject: [PATCH 7/7] sim/rl78: Add ATTRIBUTE_PRINTF Date: Sun, 25 Sep 2022 08:44:17 +0000 Message-Id: In-Reply-To: References: Mime-Version: 1.0 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tsukasa OI via Gdb-patches From: Tsukasa OI Reply-To: Tsukasa OI Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Clang generates a warning if the format string of a printf-like function is not a literal ("-Wformat-nonliteral"). On the default configuration, it causes a build failure (unless "--disable-werror" is specified). To avoid warnings on the printf-like wrapper, it requires proper __attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason. This commit adds ATTRIBUTE_PRINTF to the printf-like functions. sim/ChangeLog: * rl78/trace.c (op_printf, op_styled_printf): Add ATTRIBUTE_PRINTF. --- sim/rl78/trace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sim/rl78/trace.c b/sim/rl78/trace.c index 669c2b54615..55a330e0c2b 100644 --- a/sim/rl78/trace.c +++ b/sim/rl78/trace.c @@ -92,7 +92,7 @@ compare_symbols (const void *ap, const void *bp) static char opbuf[1000]; -static int +static int ATTRIBUTE_PRINTF(2, 3) op_printf (char *buf, char *fmt, ...) { int ret; @@ -104,7 +104,7 @@ op_printf (char *buf, char *fmt, ...) return ret; } -static int +static int ATTRIBUTE_PRINTF(3, 4) op_styled_printf (char *buf, enum disassembler_style style, char *fmt, ...) { int ret;