diff mbox series

[1/7] sim: Add ATTRIBUTE_PRINTF

Message ID ef8729c24afbdff398456a55038ae1593249d374.1664095452.git.research_trasio@irq.a4lg.com
State Superseded
Headers
Series sim, sim/ARCH: Add ATTRIBUTE_PRINTF |

Commit Message

Tsukasa OI Sept. 25, 2022, 8:44 a.m. UTC 
  Clang generates a warning if the format string of a printf-like function is
not a literal ("-Wformat-nonliteral").  On the default configuration, it
causes a build failure (unless "--disable-werror" is specified).

To avoid warnings on the printf-like wrapper, it requires proper
__attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason.

This commit adds ATTRIBUTE_PRINTF to a printf-like function.

sim/ChangeLog:

	* common/sim-cpu.h (sim_io_eprintf_cpu): Add ATTRIBUTE_PRINTF.
---
 sim/common/sim-cpu.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/sim/common/sim-cpu.h b/sim/common/sim-cpu.h
index d8b2b9c494a..024eb31d79a 100644
--- a/sim/common/sim-cpu.h
+++ b/sim/common/sim-cpu.h
@@ -137,7 +137,8 @@  extern sim_cpu *sim_cpu_lookup (SIM_DESC, const char *);
 /* Return prefix to use in cpu specific messages.  */
 extern const char *sim_cpu_msg_prefix (sim_cpu *);
 /* Cover fn to sim_io_eprintf.  */
-extern void sim_io_eprintf_cpu (sim_cpu *, const char *, ...);
+extern void sim_io_eprintf_cpu (sim_cpu *, const char *, ...)
+    ATTRIBUTE_PRINTF (2, 3);
 
 /* Get/set a pc value.  */
 #define CPU_PC_GET(cpu) ((* CPU_PC_FETCH (cpu)) (cpu))