[4/7] sim/m32c: Add ATTRIBUTE_PRINTF

Message ID a9dfb14061c124f834436088e793783b023d8e73.1664095452.git.research_trasio@irq.a4lg.com
State Superseded
Series sim, sim/ARCH: Add ATTRIBUTE_PRINTF |

Commit Message

Tsukasa OI Sept. 25, 2022, 8:44 a.m. UTC
  Clang generates a warning if the format string of a printf-like function is
not a literal ("-Wformat-nonliteral").  On the default configuration, it
causes a build failure (unless "--disable-werror" is specified).

To avoid warnings on the printf-like wrapper, it requires proper
__attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason.

This commit adds ATTRIBUTE_PRINTF to the printf-like functions.


	* m32c/trace.c (op_printf, op_styled_printf): Add
 sim/m32c/trace.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


diff --git a/sim/m32c/trace.c b/sim/m32c/trace.c
index 1888e69122b..0aa4440cade 100644
--- a/sim/m32c/trace.c
+++ b/sim/m32c/trace.c
@@ -89,7 +89,7 @@  compare_symbols (const void *ap, const void *bp)
 static char opbuf[1000];
-static int
+static int ATTRIBUTE_PRINTF(2, 3)
 op_printf (char *buf, char *fmt, ...)
   int ret;
@@ -101,7 +101,7 @@  op_printf (char *buf, char *fmt, ...)
   return ret;
-static int
+static int ATTRIBUTE_PRINTF(3, 4)
 op_styled_printf (char *buf, enum disassembler_style style, char *fmt, ...)
   int ret;