diff mbox series

[v4,04/18] RISC-V: Add support for 32-bit vDSO calls

Message ID	387ccbf208e633784d901f01826143e2f16d5ebd.1597243100.git.alistair.francis@wdc.com
State	Committed
Headers	DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EDA323857C40 IronPort-SDR: qlOXyLrIg0cmC2r5ufbmI9m0B73Mm3bVXMHiQ1dOAFsurjslcd4nXxFSBs0uqTrrL0MVeJt+Bv FYWUUaDYDehRXtV0FM1jUYE9/Sdb6kQpN9kxDHlPJWBwNTGIiA7LmFIolLQVB2nnU6on2kjmSY ciN3iJJ8w0noL6abz3WKWhgdRryZw34y9/xWDmgpCi/nWpwsU6fO9iD4qN95l0Q9pyoT7E06x2 IBQnOOUXCDd4OrmIhaQZ6cYWf19U9yYDUls/Nhb5UcD+5EBSCjmO3n/OAmvxDRwWFOZsL1qkMR oHI= IronPort-SDR: WsQr1NZYvL6Q98jqwV9IRQ3Uja0CFGiNzkgH6e/oWDGNYT5bPzI2aWwvQNr2vjFVZdkpMAHxtz jWHLdclMigdQ== IronPort-SDR: hnFlSNDaW6793FlvvtrwBtblUQCfM9Z64CYinCDrY5VV/s1bmu52k7xEU51ynSoM+hd2h24Jgk rLEcFFNiC7ig== WDCIronportException: Internal To: libc-alpha@sourceware.org Subject: [PATCH v4 04/18] RISC-V: Add support for 32-bit vDSO calls Date: Wed, 12 Aug 2020 07:40:57 -0700 Message-Id: <387ccbf208e633784d901f01826143e2f16d5ebd.1597243100.git.alistair.francis@wdc.com> In-Reply-To: <cover.1597243100.git.alistair.francis@wdc.com> References: <cover.1597243100.git.alistair.francis@wdc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list From: Alistair Francis via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Alistair Francis <alistair.francis@wdc.com> Cc: macro@wdc.com, alistair.francis@wdc.com Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces@sourceware.org>
Series	glibc port for 32-bit RISC-V (RV32) \| [v4,00/18] glibc port for 32-bit RISC-V (RV32) [v4,01/18] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64 [v4,02/18] RISC-V: Cleanup some of the sysdep.h code [v4,03/18] RISC-V: Use 64-bit-time syscall numbers with the 32-bit port [v4,04/18] RISC-V: Add support for 32-bit vDSO calls [v4,05/18] RISC-V: Support dynamic loader for the 32-bit [v4,07/18] sysv/linux: riscv: Fix dl-cache.h indentation [v4,08/18] RISC-V: Add arch-syscall.h for RV32 [v4,09/18] RISC-V: Support the 32-bit ABI implementation [v4,10/18] RISC-V: Hard float support for 32-bit [v4,11/18] RISC-V: Add 32-bit ABI lists [v4,12/18] RISC-V: Add the RV32 libm-test-ulps [v4,13/18] RISC-V: Fix llrint and llround missing exceptions on RV32 [v4,14/18] riscv32: Specify the arch_minimum_kernel as 5.4 [v4,16/18] RISC-V: Add rv32 path to RTLDLIST in ldd [v4,17/18] Documentation for the RISC-V 32-bit port [v4,18/18] Add RISC-V 32-bit target to build-many-glibcs.py

Commit Message

Alistair Francis Aug. 12, 2020, 2:40 p.m. UTC

  ---
 sysdeps/unix/sysv/linux/riscv/sysdep.h | 23 +++++++++++++++++------
 1 file changed, 17 insertions(+), 6 deletions(-)

Comments

Maciej W. Rozycki Aug. 17, 2020, 2:10 p.m. UTC | #1

On Wed, 12 Aug 2020, Alistair Francis wrote:

> ---
>  sysdeps/unix/sysv/linux/riscv/sysdep.h | 23 +++++++++++++++++------
>  1 file changed, 17 insertions(+), 6 deletions(-)

 LGTM.

Reviewed-by: Maciej W. Rozycki <macro@wdc.com>

  Maciej

Kito Cheng Aug. 18, 2020, 1:35 a.m. UTC | #2

On Wed, Aug 12, 2020 at 10:54 PM Alistair Francis via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> ---
>  sysdeps/unix/sysv/linux/riscv/sysdep.h | 23 +++++++++++++++++------
>  1 file changed, 17 insertions(+), 6 deletions(-)
>
> diff --git a/sysdeps/unix/sysv/linux/riscv/sysdep.h b/sysdeps/unix/sysv/linux/riscv/sysdep.h
> index 292484b303..6f26c558b1 100644
> --- a/sysdeps/unix/sysv/linux/riscv/sysdep.h
> +++ b/sysdeps/unix/sysv/linux/riscv/sysdep.h
> @@ -135,13 +135,24 @@
>
>  #else
>
> -# define VDSO_NAME  "LINUX_4.15"
> -# define VDSO_HASH  182943605

VDSO_NAME and VDSO_HASH have defined in if-else-clause,
so those two lines seem redundant?

> +# if __WORDSIZE == 64
> +#  define VDSO_NAME    "LINUX_4.15"
> +#  define VDSO_HASH    182943605
> +
> +/* List of system calls which are supported as vsyscalls only
> +   for RV64.  */
> +#  define HAVE_CLOCK_GETRES64_VSYSCALL "__vdso_clock_getres"
> +#  define HAVE_CLOCK_GETTIME64_VSYSCALL        "__vdso_clock_gettime"
> +#  define HAVE_GETTIMEOFDAY_VSYSCALL   "__vdso_gettimeofday"
> +# else
> +#  define VDSO_NAME    "LINUX_5.4"
> +#  define VDSO_HASH    61765876
> +
> +/* RV32 does not support the gettime VDSO syscalls.  */
> +# endif
>
> -/* List of system calls which are supported as vsyscalls.  */
> -# define HAVE_CLOCK_GETRES64_VSYSCALL  "__vdso_clock_getres"
> -# define HAVE_CLOCK_GETTIME64_VSYSCALL "__vdso_clock_gettime"
> -# define HAVE_GETTIMEOFDAY_VSYSCALL    "__vdso_gettimeofday"
> +/* List of system calls which are supported as vsyscalls (for RV32 and
> +   RV64).  */
>  # define HAVE_GETCPU_VSYSCALL          "__vdso_getcpu"
>
>  # define INTERNAL_SYSCALL(name, nr, args...) \
> --
> 2.27.0
>

diff mbox series

Patch

diff --git a/sysdeps/unix/sysv/linux/riscv/sysdep.h b/sysdeps/unix/sysv/linux/riscv/sysdep.h
index 292484b303..6f26c558b1 100644
--- a/sysdeps/unix/sysv/linux/riscv/sysdep.h
+++ b/sysdeps/unix/sysv/linux/riscv/sysdep.h
@@ -135,13 +135,24 @@ 
 
 #else
 
-# define VDSO_NAME  "LINUX_4.15"
-# define VDSO_HASH  182943605
+# if __WORDSIZE == 64
+#  define VDSO_NAME	"LINUX_4.15"
+#  define VDSO_HASH	182943605
+
+/* List of system calls which are supported as vsyscalls only
+   for RV64.  */
+#  define HAVE_CLOCK_GETRES64_VSYSCALL	"__vdso_clock_getres"
+#  define HAVE_CLOCK_GETTIME64_VSYSCALL	"__vdso_clock_gettime"
+#  define HAVE_GETTIMEOFDAY_VSYSCALL	"__vdso_gettimeofday"
+# else
+#  define VDSO_NAME	"LINUX_5.4"
+#  define VDSO_HASH	61765876
+
+/* RV32 does not support the gettime VDSO syscalls.  */
+# endif
 
-/* List of system calls which are supported as vsyscalls.  */
-# define HAVE_CLOCK_GETRES64_VSYSCALL	"__vdso_clock_getres"
-# define HAVE_CLOCK_GETTIME64_VSYSCALL	"__vdso_clock_gettime"
-# define HAVE_GETTIMEOFDAY_VSYSCALL	"__vdso_gettimeofday"
+/* List of system calls which are supported as vsyscalls (for RV32 and
+   RV64).  */
 # define HAVE_GETCPU_VSYSCALL		"__vdso_getcpu"
 
 # define INTERNAL_SYSCALL(name, nr, args...) \