diff mbox series

[v4,07/18] sysv/linux: riscv: Fix dl-cache.h indentation

Message ID	0afac7b4aa891fae06fccdef5f85d676747e7fa8.1597243100.git.alistair.francis@wdc.com
State	Committed
Headers	DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A97633857C40 IronPort-SDR: 22fsg8REE6d86AB6OMYXqCzCr9vCgxwJFBZJrcb3poSfo5OoILoASAa9b0VAvjhAFAzr3sAntT kkgoJTCUMlPFAFc/aOjONFijbmlvc9MTM+Z5RdmilaTPecnKk5sAUSPC+WV+CLjzesAv7ZycNg 8rrc+KZHEitMDFv0kvO22mev3Un6bfUUltpe5tJZ0hXTI1v1POWvDDW+klDolRwZJPh+J+dHWK yewP1asCI/+mq1/51c9V/jbkKWqM2yhysFARLdHE9xbjAjLT8Di4h26vO+4HH3H0RZE6mSAbPm /sc= IronPort-SDR: mNnMFvrzXE94S3ifTLCK40nONdPm6Jlxu+7r0VUUDaE6FBA7qGCrqO8SSpij7CYV6raXFYd6n+ 9ReLyN85HKvw== IronPort-SDR: Ob6enxTMfVh4S6dV+xYkJ1EVNVUgipnTW+dCOb2ekffRbgURwni3/FIGfveGXoC0gcll45xQv+ uJcunNlOdzig== WDCIronportException: Internal To: libc-alpha@sourceware.org Subject: [PATCH v4 07/18] sysv/linux: riscv: Fix dl-cache.h indentation Date: Wed, 12 Aug 2020 07:41:14 -0700 Message-Id: <0afac7b4aa891fae06fccdef5f85d676747e7fa8.1597243100.git.alistair.francis@wdc.com> In-Reply-To: <cover.1597243100.git.alistair.francis@wdc.com> References: <cover.1597243100.git.alistair.francis@wdc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list From: Alistair Francis via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Alistair Francis <alistair.francis@wdc.com> Cc: macro@wdc.com, alistair.francis@wdc.com Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces@sourceware.org>
Series	glibc port for 32-bit RISC-V (RV32) \| [v4,00/18] glibc port for 32-bit RISC-V (RV32) [v4,01/18] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64 [v4,02/18] RISC-V: Cleanup some of the sysdep.h code [v4,03/18] RISC-V: Use 64-bit-time syscall numbers with the 32-bit port [v4,04/18] RISC-V: Add support for 32-bit vDSO calls [v4,05/18] RISC-V: Support dynamic loader for the 32-bit [v4,07/18] sysv/linux: riscv: Fix dl-cache.h indentation [v4,08/18] RISC-V: Add arch-syscall.h for RV32 [v4,09/18] RISC-V: Support the 32-bit ABI implementation [v4,10/18] RISC-V: Hard float support for 32-bit [v4,11/18] RISC-V: Add 32-bit ABI lists [v4,12/18] RISC-V: Add the RV32 libm-test-ulps [v4,13/18] RISC-V: Fix llrint and llround missing exceptions on RV32 [v4,14/18] riscv32: Specify the arch_minimum_kernel as 5.4 [v4,16/18] RISC-V: Add rv32 path to RTLDLIST in ldd [v4,17/18] Documentation for the RISC-V 32-bit port [v4,18/18] Add RISC-V 32-bit target to build-many-glibcs.py

Commit Message

Alistair Francis Aug. 12, 2020, 2:41 p.m. UTC

  Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
 sysdeps/unix/sysv/linux/riscv/dl-cache.h | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

Comments

Maciej W. Rozycki Aug. 17, 2020, 2:21 p.m. UTC | #1

On Wed, 12 Aug 2020, Alistair Francis wrote:

> diff --git a/sysdeps/unix/sysv/linux/riscv/dl-cache.h b/sysdeps/unix/sysv/linux/riscv/dl-cache.h
> index 331e6015f4..d2adfbc301 100644
> --- a/sysdeps/unix/sysv/linux/riscv/dl-cache.h
> +++ b/sysdeps/unix/sysv/linux/riscv/dl-cache.h
> @@ -31,7 +31,7 @@
>    ((flags) == _DL_CACHE_DEFAULT_ID)
>  
>  /* If given a path to one of our library directories, adds every library
> -   directory via add_dir (), otherwise just adds the giver directory.  On
> +   directory via add_dir (), otherwise just adds the given directory.  On
>     RISC-V, libraries can be found in paths ending in:
>       - /lib64/lp64d
>       - /lib64/lp64
> @@ -41,15 +41,16 @@
>     so this will add all of those paths.
>  
>     According to Joseph Myers:
> -       My reasoning for that would be: generic autoconf-configured (etc.)
> -       software may only know about using the lib directory, so you want the
> -       lib directory to be searched regardless of the ABI - but it's also
> -       useful to be able to e.g. list /usr/local/lib in /etc/ld.so.conf for all
> -       architectures and have that automatically imply /usr/local/lib64/lp64d
> -       etc. so that libraries can be found that come from software that does
> -       use the ABI-specific directories.  */
> +	 My reasoning for that would be: generic autoconf-configured (etc.)
> +	 software may only know about using the lib directory, so you want the
> +	 lib directory to be searched regardless of the ABI - but it's also
> +	 useful to be able to e.g. list /usr/local/lib in /etc/ld.so.conf for all
> +	 architectures and have that automatically imply /usr/local/lib64/lp64d
> +	 etc. so that libraries can be found that come from software that does
> +	 use the ABI-specific directories.  */
> +
>  #define add_system_dir(dir) 						\
> -  do							    		\
> +  do									\

 Hmm, wrong patch submitted (06/19 from v3, which I asked to drop, rather 
than 07/19)?  Also there's no 6/18 in the series, so something surely went 
wrong.

 NB I suggest splitting any fixes for typos or formatting anomalies off 
for a later submission unless made on a line that is changed for another 
reason anyway.  Such changes can usually be committed as obvious right 
away with a note sent to the list and may be ignored for any backports.

  Maciej

diff mbox series

Patch

diff --git a/sysdeps/unix/sysv/linux/riscv/dl-cache.h b/sysdeps/unix/sysv/linux/riscv/dl-cache.h
index 331e6015f4..d2adfbc301 100644
--- a/sysdeps/unix/sysv/linux/riscv/dl-cache.h
+++ b/sysdeps/unix/sysv/linux/riscv/dl-cache.h
@@ -31,7 +31,7 @@ 
   ((flags) == _DL_CACHE_DEFAULT_ID)
 
 /* If given a path to one of our library directories, adds every library
-   directory via add_dir (), otherwise just adds the giver directory.  On
+   directory via add_dir (), otherwise just adds the given directory.  On
    RISC-V, libraries can be found in paths ending in:
      - /lib64/lp64d
      - /lib64/lp64
@@ -41,15 +41,16 @@ 
    so this will add all of those paths.
 
    According to Joseph Myers:
-       My reasoning for that would be: generic autoconf-configured (etc.)
-       software may only know about using the lib directory, so you want the
-       lib directory to be searched regardless of the ABI - but it's also
-       useful to be able to e.g. list /usr/local/lib in /etc/ld.so.conf for all
-       architectures and have that automatically imply /usr/local/lib64/lp64d
-       etc. so that libraries can be found that come from software that does
-       use the ABI-specific directories.  */
+	 My reasoning for that would be: generic autoconf-configured (etc.)
+	 software may only know about using the lib directory, so you want the
+	 lib directory to be searched regardless of the ABI - but it's also
+	 useful to be able to e.g. list /usr/local/lib in /etc/ld.so.conf for all
+	 architectures and have that automatically imply /usr/local/lib64/lp64d
+	 etc. so that libraries can be found that come from software that does
+	 use the ABI-specific directories.  */
+
 #define add_system_dir(dir) 						\
-  do							    		\
+  do									\
     {									\
       static const char* lib_dirs[] = {					\
 	"/lib64/lp64d",							\