Message ID | 9d993eb853ecc5911c85868931cec308925014d8.1665038133.git.research_trasio@irq.a4lg.com |
---|---|
State | Committed |
Headers |
Return-Path: <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BEAA8384B82D for <patchwork@sourceware.org>; Thu, 6 Oct 2022 06:38:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BEAA8384B82D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1665038290; bh=3sC7nBMelMn6ACKfqajGkOwikODC7lETs/0+PX0NMuY=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=cd922c1uYHF+1fDX0rQqCrNqg4eC1HzmOyKvEd6rSJ6ddBuYe1LGUJe9lZHav+odd wPk7oUPujcLy30qoDGsxfPq/FdqWRb8Mw4JFaenObCS4XlvP5Iu1SuTDQp2YbNxPWn F5F4zSqxB5aqc9fhG72VPGmMSAlG4XdVZVqmMafw= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-sender-0.a4lg.com (mail-sender.a4lg.com [153.120.152.154]) by sourceware.org (Postfix) with ESMTPS id 7228C384BC22 for <gdb-patches@sourceware.org>; Thu, 6 Oct 2022 06:37:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7228C384BC22 Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id AF794300089; Thu, 6 Oct 2022 06:37:28 +0000 (UTC) To: Tsukasa OI <research_trasio@irq.a4lg.com>, Andrew Burgess <aburgess@redhat.com>, Mike Frysinger <vapier@gentoo.org>, Stephane Carrez <Stephane.Carrez@gmail.com>, "Frank Ch . Eigler" <fche@redhat.com> Subject: [PATCH v2 5/7] sim/m68hc11: Add ATTRIBUTE_PRINTF Date: Thu, 6 Oct 2022 06:36:31 +0000 Message-Id: <9d993eb853ecc5911c85868931cec308925014d8.1665038133.git.research_trasio@irq.a4lg.com> In-Reply-To: <cover.1665038133.git.research_trasio@irq.a4lg.com> References: <cover.1664095452.git.research_trasio@irq.a4lg.com> <cover.1665038133.git.research_trasio@irq.a4lg.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=subscribe> From: Tsukasa OI via Gdb-patches <gdb-patches@sourceware.org> Reply-To: Tsukasa OI <research_trasio@irq.a4lg.com> Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> |
Series |
sim, sim/ARCH: Add ATTRIBUTE_PRINTF
|
|
Commit Message
Tsukasa OI
Oct. 6, 2022, 6:36 a.m. UTC
Clang generates a warning if the format string of a printf-like function is not a literal ("-Wformat-nonliteral"). On the default configuration, it causes a build failure (unless "--disable-werror" is specified). To avoid warnings on the printf-like wrapper, it requires proper __attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason. This commit adds ATTRIBUTE_PRINTF to a printf-like function. --- sim/m68hc11/m68hc11_sim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Tsukasa OI <research_trasio@irq.a4lg.com> writes: > Clang generates a warning if the format string of a printf-like function is > not a literal ("-Wformat-nonliteral"). On the default configuration, it > causes a build failure (unless "--disable-werror" is specified). > > To avoid warnings on the printf-like wrapper, it requires proper > __attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason. > > This commit adds ATTRIBUTE_PRINTF to a printf-like function. > --- > sim/m68hc11/m68hc11_sim.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sim/m68hc11/m68hc11_sim.c b/sim/m68hc11/m68hc11_sim.c > index 6ec45f78206..2770f17262a 100644 > --- a/sim/m68hc11/m68hc11_sim.c > +++ b/sim/m68hc11/m68hc11_sim.c > @@ -1017,7 +1017,7 @@ cpu_single_step (sim_cpu *cpu) > } > > /* VARARGS */ > -void > +void ATTRIBUTE_PRINTF (4, 5) > sim_memory_error (sim_cpu *cpu, SIM_SIGNAL excep, > uint16_t addr, const char *message, ...) > { I've pushed this patch, but moved the ATTRIBUTE_PRINTF to the function declaration. Thanks, Andrew --- commit 7f9495b21380c0184dde72920bcca37be9d76b9d Author: Tsukasa OI <research_trasio@irq.a4lg.com> Date: Thu Oct 6 06:36:31 2022 +0000 sim/m68hc11: Add ATTRIBUTE_PRINTF Clang generates a warning if the format string of a printf-like function is not a literal ("-Wformat-nonliteral"). On the default configuration, it causes a build failure (unless "--disable-werror" is specified). To avoid warnings on the printf-like wrapper, it requires proper __attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason. This commit adds ATTRIBUTE_PRINTF to a printf-like function. diff --git a/sim/m68hc11/sim-main.h b/sim/m68hc11/sim-main.h index e667c33a705..78dbd672867 100644 --- a/sim/m68hc11/sim-main.h +++ b/sim/m68hc11/sim-main.h @@ -539,7 +539,8 @@ extern void cpu_set_sp (sim_cpu *cpu, uint16_t val); extern int cpu_reset (sim_cpu *cpu); extern int cpu_restart (sim_cpu *cpu); extern void sim_memory_error (sim_cpu *cpu, SIM_SIGNAL excep, - uint16_t addr, const char *message, ...); + uint16_t addr, const char *message, ...) + ATTRIBUTE_PRINTF (4, 5); extern void emul_os (int op, sim_cpu *cpu); extern void cpu_interp_m6811 (sim_cpu *cpu); extern void cpu_interp_m6812 (sim_cpu *cpu);
diff --git a/sim/m68hc11/m68hc11_sim.c b/sim/m68hc11/m68hc11_sim.c index 6ec45f78206..2770f17262a 100644 --- a/sim/m68hc11/m68hc11_sim.c +++ b/sim/m68hc11/m68hc11_sim.c @@ -1017,7 +1017,7 @@ cpu_single_step (sim_cpu *cpu) } /* VARARGS */ -void +void ATTRIBUTE_PRINTF (4, 5) sim_memory_error (sim_cpu *cpu, SIM_SIGNAL excep, uint16_t addr, const char *message, ...) {