Message ID | cover.1665038133.git.research_trasio@irq.a4lg.com |
---|---|
Headers |
Return-Path: <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0EEB3384B801 for <patchwork@sourceware.org>; Thu, 6 Oct 2022 06:37:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0EEB3384B801 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1665038223; bh=45C1m2ycyDQRQZDon4kUZtiMNCCIDe3HaTwc4N7Qh+k=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=l0UVDV8t7L7h2gm5uk5XL0YNup/mTcv9b8M2hpfFdMAiQFDml7XWNsh3dMPyPR/hh 2DXIX++4mH/SuzKUZmkV1AIxWUiPRYFMNIu0PYIMI6dKRQL1uXFHGBu9z805X8whG5 PYmRlMamTxg8SpKp2LmhnLCaLtpLTVGv+DkGIO8U= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-sender-0.a4lg.com (mail-sender.a4lg.com [153.120.152.154]) by sourceware.org (Postfix) with ESMTPS id 53EC03853543 for <gdb-patches@sourceware.org>; Thu, 6 Oct 2022 06:36:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 53EC03853543 Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 0EEE4300089; Thu, 6 Oct 2022 06:36:36 +0000 (UTC) To: Tsukasa OI <research_trasio@irq.a4lg.com>, Andrew Burgess <aburgess@redhat.com>, Mike Frysinger <vapier@gentoo.org>, Stephane Carrez <Stephane.Carrez@gmail.com>, "Frank Ch . Eigler" <fche@redhat.com> Subject: [PATCH v2 0/7] sim, sim/ARCH: Add ATTRIBUTE_PRINTF Date: Thu, 6 Oct 2022 06:36:26 +0000 Message-Id: <cover.1665038133.git.research_trasio@irq.a4lg.com> In-Reply-To: <cover.1664095452.git.research_trasio@irq.a4lg.com> References: <cover.1664095452.git.research_trasio@irq.a4lg.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=subscribe> From: Tsukasa OI via Gdb-patches <gdb-patches@sourceware.org> Reply-To: Tsukasa OI <research_trasio@irq.a4lg.com> Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> |
Series |
sim, sim/ARCH: Add ATTRIBUTE_PRINTF
|
|
Message
Tsukasa OI
Oct. 6, 2022, 6:36 a.m. UTC
Hello, [Background] When we build Binutils and GDB with Clang, it causes a build failure due to warnings generated by Clang and the default -Werror configuration. I MOSTLY managed to make ALL ARCHITECTURE ENABLED Binutils and GDB -Werror-free on Clang 15.0.0 (note that this does not necessarily mean warning-free) and this patchset is a part of it (simulator: printf-like functions). - It still requires -Wno-implicit-function-declaration on the LatticeMicro32 and M32R simulators. Except them, most of Binutils / GDB components can be built with Clang by default with my tree. - I noticed that the assembler is not tested enough (because just with --enable-targets=all, it builds only host assembler). Full Clang 15.0.0 -Werror-free branch in development is available at: <https://github.com/a4lg/binutils-gdb/tree/clang-nowarn-dev> Tested configuration: - Ubuntu 22.04.1 LTS (x86_64) - LLVM / Clang 15.0.0 (built from source) - Configuration examples: $srcdir/configure \ --enable-targets=all \ --enable-multilib --enable-ld --enable-gold --enable-nls \ CC=clang CXX=clang++ CCLD=clang CXXLD=clang++ \ CFLAGS=' -O2 -g -Wno-implicit-function-declaration' \ CXXFLAGS='-O2 -g -Wno-implicit-function-declaration' $srcdir/configure \ --target=riscv64-unknown-linux-gnu \ --enable-multilib --enable-ld --enable-gold --enable-nls \ CC=clang CXX=clang++ CCLD=clang CXXLD=clang++ \ CFLAGS='-O2 -g' CXXFLAGS='-O2 -g' [About this Patchset] Clang generates a warning if the format string of a printf-like function is not a literal ("-Wformat-nonliteral"). On the default configuration, it causes a build failure (unless "--disable-werror" is specified). To avoid warnings on the printf-like wrapper, it requires proper __attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason. This patchset adds ATTRIBUTE_PRINTF to all functions that require ATTRIBUTE_PRINTF macro. [Changes: v1 -> v2] - We only append ATTRIBUTE_PRINTF at function declarations, not definitions (based on the feedback by Andrew Burgess). - Fixed indents - Removed ChangeLog from commit messages (based on the feedback [to another patchset by me] by Bruno Larsen). Thanks, Tsukasa Tsukasa OI (7): sim: Add ATTRIBUTE_PRINTF sim/cris: Add ATTRIBUTE_PRINTF sim/erc32: Add ATTRIBUTE_PRINTF sim/m32c: Add ATTRIBUTE_PRINTF sim/m68hc11: Add ATTRIBUTE_PRINTF sim/ppc: Add ATTRIBUTE_PRINTF sim/rl78: Add ATTRIBUTE_PRINTF sim/common/sim-utils.c | 2 +- sim/cris/traps.c | 2 +- sim/erc32/interf.c | 2 +- sim/erc32/sis.c | 2 +- sim/m32c/trace.c | 4 ++-- sim/m68hc11/m68hc11_sim.c | 2 +- sim/ppc/main.c | 2 +- sim/ppc/misc.c | 4 ++-- sim/ppc/sim_calls.c | 2 +- sim/rl78/trace.c | 4 ++-- 10 files changed, 13 insertions(+), 13 deletions(-) base-commit: a13886e2198beb78b81c59839043b021ce6df78a
Comments
Tsukasa OI <research_trasio@irq.a4lg.com> writes: > Hello, > > [Background] > > When we build Binutils and GDB with Clang, it causes a build failure due to > warnings generated by Clang and the default -Werror configuration. > > I MOSTLY managed to make ALL ARCHITECTURE ENABLED Binutils and GDB > -Werror-free on Clang 15.0.0 (note that this does not necessarily mean > warning-free) and this patchset is a part of it (simulator: > printf-like functions). > > - It still requires -Wno-implicit-function-declaration on the > LatticeMicro32 and M32R simulators. Except them, most of Binutils / GDB > components can be built with Clang by default with my tree. > - I noticed that the assembler is not tested enough (because just with > --enable-targets=all, it builds only host assembler). > > Full Clang 15.0.0 -Werror-free branch in development is available at: > <https://github.com/a4lg/binutils-gdb/tree/clang-nowarn-dev> > > Tested configuration: > - Ubuntu 22.04.1 LTS (x86_64) > - LLVM / Clang 15.0.0 (built from source) > - Configuration examples: > $srcdir/configure \ > --enable-targets=all \ > --enable-multilib --enable-ld --enable-gold --enable-nls \ > CC=clang CXX=clang++ CCLD=clang CXXLD=clang++ \ > CFLAGS=' -O2 -g -Wno-implicit-function-declaration' \ > CXXFLAGS='-O2 -g -Wno-implicit-function-declaration' > $srcdir/configure \ > --target=riscv64-unknown-linux-gnu \ > --enable-multilib --enable-ld --enable-gold --enable-nls \ > CC=clang CXX=clang++ CCLD=clang CXXLD=clang++ \ > CFLAGS='-O2 -g' CXXFLAGS='-O2 -g' > > > [About this Patchset] > > Clang generates a warning if the format string of a printf-like function is > not a literal ("-Wformat-nonliteral"). On the default configuration, it > causes a build failure (unless "--disable-werror" is specified). > > To avoid warnings on the printf-like wrapper, it requires proper > __attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason. > > This patchset adds ATTRIBUTE_PRINTF to all functions that require > ATTRIBUTE_PRINTF macro. > > > [Changes: v1 -> v2] > > - We only append ATTRIBUTE_PRINTF at function declarations, > not definitions (based on the feedback by Andrew Burgess). > - Fixed indents > - Removed ChangeLog from commit messages > (based on the feedback [to another patchset by me] by Bruno Larsen). Thanks for the updated series. I've now pushed these patches with a few minor adjustments. I'll comment on each patch where I made changes. Thanks, Andrew