diff mbox series

[v2,4/7] sim/m32c: Add ATTRIBUTE_PRINTF

Message ID 9b1d90ae461063037376a8b48d01faac2bea2c82.1665038133.git.research_trasio@irq.a4lg.com
State Committed
Commit fe8732f93993b99fb257ebd38b47d64f2e4400b4
Headers
Series sim, sim/ARCH: Add ATTRIBUTE_PRINTF |

Commit Message

Tsukasa OI Oct. 6, 2022, 6:36 a.m. UTC 
  Clang generates a warning if the format string of a printf-like function is
not a literal ("-Wformat-nonliteral").  On the default configuration, it
causes a build failure (unless "--disable-werror" is specified).

To avoid warnings on the printf-like wrapper, it requires proper
__attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason.

This commit adds ATTRIBUTE_PRINTF to the printf-like functions.
---
 sim/m32c/trace.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/sim/m32c/trace.c b/sim/m32c/trace.c
index 1888e69122b..2f6373dd5f8 100644
--- a/sim/m32c/trace.c
+++ b/sim/m32c/trace.c
@@ -89,7 +89,7 @@  compare_symbols (const void *ap, const void *bp)
 
 static char opbuf[1000];
 
-static int
+static int ATTRIBUTE_PRINTF (2, 3)
 op_printf (char *buf, char *fmt, ...)
 {
   int ret;
@@ -101,7 +101,7 @@  op_printf (char *buf, char *fmt, ...)
   return ret;
 }
 
-static int
+static int ATTRIBUTE_PRINTF (3, 4)
 op_styled_printf (char *buf, enum disassembler_style style, char *fmt, ...)
 {
   int ret;