diff mbox series

[v2,60/79] Rename to allow_debuginfod_tests

Message ID 20230112030052.3306113-61-tom@tromey.com
State Committed
Headers
Series Rewrite "require" test procedure and use it more often |

Commit Message

Tom Tromey Jan. 12, 2023, 3 a.m. UTC 
  This changes skip_debuginfod_tests to invert the sense, and renames it
to allow_debuginfod_tests.
---
 .../gdb.debuginfod/fetch_src_and_symbols.exp       |  2 +-
 gdb/testsuite/lib/debuginfod-support.exp           | 14 +++++++-------
 2 files changed, 8 insertions(+), 8 deletions(-)
diff mbox series

Patch

diff --git a/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp b/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp
index e2c77eb109f..c9cd8a30a1c 100644
--- a/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp
+++ b/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp
@@ -20,7 +20,7 @@  standard_testfile
 load_lib dwarf.exp
 load_lib debuginfod-support.exp
 
-require !skip_debuginfod_tests
+require allow_debuginfod_tests
 
 set sourcetmp [standard_output_file tmp-${srcfile}]
 set outputdir [standard_output_file {}]
diff --git a/gdb/testsuite/lib/debuginfod-support.exp b/gdb/testsuite/lib/debuginfod-support.exp
index ad156f23d03..50a8b512a4a 100644
--- a/gdb/testsuite/lib/debuginfod-support.exp
+++ b/gdb/testsuite/lib/debuginfod-support.exp
@@ -15,20 +15,20 @@ 
 
 # Helper functions to make it easier to write debuginfod tests.
 
-# Return true if the debuginfod tests should be skipped, otherwise, return
+# Return true if the debuginfod tests should be run, otherwise, return
 # false.
-proc skip_debuginfod_tests {} {
+proc allow_debuginfod_tests {} {
     if [is_remote host] {
-	return true
+	return false
     }
 
     if { [which debuginfod] == 0 } {
-	return true
+	return false
     }
 
     if { [which curl] == 0 } {
 	untested "cannot find curl"
-	return true
+	return false
     }
 
     # Skip testing if gdb was not configured with debuginfod.
@@ -39,10 +39,10 @@  proc skip_debuginfod_tests {} {
     if { [string first "with-debuginfod" \
 	      [eval exec $::GDB --quiet $::INTERNAL_GDBFLAGS \
 		   --configuration]] == -1 } {
-	return true
+	return false
     }
 
-    return false
+    return true
 }
 
 # Create two directories within the current output directory.  One directory