diff mbox series

[v2,55/79] Rename to allow_avx512fp16_tests

Message ID 20230112030052.3306113-56-tom@tromey.com
State Committed
Headers
Series Rewrite "require" test procedure and use it more often |

Commit Message

Tom Tromey Jan. 12, 2023, 3 a.m. UTC 
  This changes skip_avx512fp16_tests to invert the sense, and renames it
to allow_avx512fp16_tests.
---
 gdb/testsuite/gdb.arch/x86-avx512fp16-abi.exp |  2 +-
 gdb/testsuite/gdb.arch/x86-avx512fp16.exp     |  2 +-
 gdb/testsuite/lib/gdb.exp                     | 24 +++++++++----------
 3 files changed, 14 insertions(+), 14 deletions(-)
diff mbox series

Patch

diff --git a/gdb/testsuite/gdb.arch/x86-avx512fp16-abi.exp b/gdb/testsuite/gdb.arch/x86-avx512fp16-abi.exp
index 696a6b8edf1..bf8291a4d0b 100644
--- a/gdb/testsuite/gdb.arch/x86-avx512fp16-abi.exp
+++ b/gdb/testsuite/gdb.arch/x86-avx512fp16-abi.exp
@@ -15,7 +15,7 @@ 
 
 # Test support for _Float16 parameters and return values.
 
-require !skip_avx512fp16_tests
+require allow_avx512fp16_tests
 
 standard_testfile
 
diff --git a/gdb/testsuite/gdb.arch/x86-avx512fp16.exp b/gdb/testsuite/gdb.arch/x86-avx512fp16.exp
index 526be1660bf..144b51bfa68 100644
--- a/gdb/testsuite/gdb.arch/x86-avx512fp16.exp
+++ b/gdb/testsuite/gdb.arch/x86-avx512fp16.exp
@@ -15,7 +15,7 @@ 
 
 # Test fp16 support in AVX512 registers.
 
-require !skip_avx512fp16_tests
+require allow_avx512fp16_tests
 
 standard_testfile
 
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index b68ea4eb5b0..4959af6b2c4 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -3750,16 +3750,16 @@  gdb_caching_proc allow_avx512bf16_tests {
     return $allow_avx512bf16_tests
 }
 
-# Run a test on the target to see if it supports avx512fp16.  Return 0 if so,
-# 1 if it does not.  Based on 'check_vmx_hw_available' from the GCC testsuite.
+# Run a test on the target to see if it supports avx512fp16.  Return 1 if so,
+# 0 if it does not.  Based on 'check_vmx_hw_available' from the GCC testsuite.
 
-gdb_caching_proc skip_avx512fp16_tests {
+gdb_caching_proc allow_avx512fp16_tests {
     global srcdir subdir gdb_prompt inferior_exited_re
 
-    set me "skip_avx512fp16_tests"
+    set me "allow_avx512fp16_tests"
     if { ![istarget "i?86-*-*"] && ![istarget "x86_64-*-*"] } {
-        verbose "$me:  target does not support avx512fp16, returning 1" 2
-        return 1
+	verbose "$me:  target does not support avx512fp16, returning 0" 2
+	return 0
     }
 
     # Compile a test program.
@@ -3770,7 +3770,7 @@  gdb_caching_proc skip_avx512fp16_tests {
         }
     }
     if {![gdb_simple_compile $me $src executable]} {
-        return 1
+	return 0
     }
 
     # No error message, compilation succeeded so now run it via gdb.
@@ -3783,22 +3783,22 @@  gdb_caching_proc skip_avx512fp16_tests {
     gdb_expect {
         -re ".*Illegal instruction.*${gdb_prompt} $" {
             verbose -log "$me:  avx512fp16 hardware not detected."
-            set skip_avx512fp16_tests 1
+	    set allow_avx512fp16_tests 0
         }
         -re ".*$inferior_exited_re normally.*${gdb_prompt} $" {
             verbose -log "$me:  avx512fp16 hardware detected."
-            set skip_avx512fp16_tests 0
+	    set allow_avx512fp16_tests 1
         }
         default {
             warning "\n$me:  default case taken."
-            set skip_avx512fp16_tests 1
+	    set allow_avx512fp16_tests 0
         }
     }
     gdb_exit
     remote_file build delete $obj
 
-    verbose "$me:  returning $skip_avx512fp16_tests" 2
-    return $skip_avx512fp16_tests
+    verbose "$me:  returning $allow_avx512fp16_tests" 2
+    return $allow_avx512fp16_tests
 }
 
 # Run a test on the target to see if it supports btrace hardware.  Return 0 if so,