diff mbox series

[v2,52/79] Rename to allow_aarch64_sve_tests

Message ID 20230112030052.3306113-53-tom@tromey.com
State Committed
Headers
Series Rewrite "require" test procedure and use it more often |

Commit Message

Tom Tromey Jan. 12, 2023, 3 a.m. UTC 
  This changes skip_aarch64_sve_tests to invert the sense, and renames
it to allow_aarch64_sve_tests.
---
 .../gdb.arch/aarch64-sighandler-regs.exp       |  2 +-
 gdb/testsuite/gdb.arch/aarch64-sve.exp         |  2 +-
 gdb/testsuite/lib/gdb.exp                      | 18 +++++++++---------
 3 files changed, 11 insertions(+), 11 deletions(-)
diff mbox series

Patch

diff --git a/gdb/testsuite/gdb.arch/aarch64-sighandler-regs.exp b/gdb/testsuite/gdb.arch/aarch64-sighandler-regs.exp
index d3f7d1f503e..57ebed3628f 100644
--- a/gdb/testsuite/gdb.arch/aarch64-sighandler-regs.exp
+++ b/gdb/testsuite/gdb.arch/aarch64-sighandler-regs.exp
@@ -19,7 +19,7 @@  require is_aarch64_target
 
 set compile_flags {debug}
 
-if { [skip_aarch64_sve_tests] } {
+if { ![allow_aarch64_sve_tests] } {
     unsupported "target does not support SVE"
     set sve_hw 0
 } else {
diff --git a/gdb/testsuite/gdb.arch/aarch64-sve.exp b/gdb/testsuite/gdb.arch/aarch64-sve.exp
index 4a54b56105d..9b2755e569d 100644
--- a/gdb/testsuite/gdb.arch/aarch64-sve.exp
+++ b/gdb/testsuite/gdb.arch/aarch64-sve.exp
@@ -15,7 +15,7 @@ 
 
 # Test a binary that uses SVE and exercise changing the SVE vector length.
 
-require !skip_aarch64_sve_tests
+require allow_aarch64_sve_tests
 
 standard_testfile
 if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } {
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index f293cbb19cc..9f7ec180189 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -3906,15 +3906,15 @@  gdb_caching_proc skip_btrace_pt_tests {
 }
 
 # Run a test on the target to see if it supports Aarch64 SVE hardware.
-# Return 0 if so, 1 if it does not.  Note this causes a restart of GDB.
+# Return 1 if so, 0 if it does not.  Note this causes a restart of GDB.
 
-gdb_caching_proc skip_aarch64_sve_tests {
+gdb_caching_proc allow_aarch64_sve_tests {
     global srcdir subdir gdb_prompt inferior_exited_re
 
     set me "skip_aarch64_sve_tests"
 
     if { ![is_aarch64_target]} {
-	return 1
+	return 0
     }
 
     set compile_flags "{additional_flags=-march=armv8-a+sve}"
@@ -3927,7 +3927,7 @@  gdb_caching_proc skip_aarch64_sve_tests {
 	}
     }
     if {![gdb_simple_compile $me $src executable $compile_flags]} {
-        return 1
+        return 0
     }
 
     # Compilation succeeded so now run it via gdb.
@@ -3936,22 +3936,22 @@  gdb_caching_proc skip_aarch64_sve_tests {
     gdb_expect {
         -re ".*Illegal instruction.*${gdb_prompt} $" {
             verbose -log "\n$me sve hardware not detected"
-            set skip_sve_tests 1
+            set allow_sve_tests 0
         }
         -re ".*$inferior_exited_re normally.*${gdb_prompt} $" {
             verbose -log "\n$me: sve hardware detected"
-            set skip_sve_tests 0
+            set allow_sve_tests 1
         }
         default {
           warning "\n$me: default case taken"
-            set skip_sve_tests 1
+            set allow_sve_tests 0
         }
     }
     gdb_exit
     remote_file build delete $obj
 
-    verbose "$me:  returning $skip_sve_tests" 2
-    return $skip_sve_tests
+    verbose "$me:  returning $allow_sve_tests" 2
+    return $allow_sve_tests
 }