diff mbox series

[16/26] gdbserver: boolify regcache fields

Message ID	9bbbc603a5966c9440bfa12484ced476bb80a3fa.1677582745.git.tankut.baris.aktemur@intel.com
State	New
Headers	DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 096C8384F4AE To: gdb-patches@sourceware.org Subject: [PATCH 16/26] gdbserver: boolify regcache fields Date: Tue, 28 Feb 2023 12:28:14 +0100 Message-Id: <9bbbc603a5966c9440bfa12484ced476bb80a3fa.1677582745.git.tankut.baris.aktemur@intel.com> In-Reply-To: <cover.1677582744.git.tankut.baris.aktemur@intel.com> References: <cover.1677582744.git.tankut.baris.aktemur@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Precedence: list From: Tankut Baris Aktemur via Gdb-patches <gdb-patches@sourceware.org> Reply-To: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com> Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org>
Series	gdbserver: refactor regcache and allow gradually populating \| [00/26] gdbserver: refactor regcache and allow gradually populating [01/26] gdbserver: convert init_register_cache into regcache::initialize [02/26] gdbserver: convert new_register_cache into a regcache constructor [03/26] gdbserver: by-pass regcache to access tdesc only [04/26] gdbserver: boolify and defaultize the 'fetch' parameter of get_thread_regcache [05/26] gdbserver: add a pointer to the owner thread in regcache [06/26] gdbserver: turn part of get_thread_regcache into regcache::fetch [07/26] gdbserver: convert regcache_cpy into regcache::copy_from [08/26] gdbserver: convert free_register_cache into a destructor of regcache [09/26] gdbserver: extract out regcache::invalidate and regcache::discard [10/26] gdbserver: convert registers_to_string into regcache::registers_to_string [11/26] gdbserver: convert registers_from_string into regcache::registers_from_string [12/26] gdbserver: convert supply_regblock to regcache::supply_regblock [13/26] gdbserver: convert register_data into regcache::register_data [14/26] gdbserver: introduce and use regcache::set_register_status [15/26] gdbserver: check for nullptr condition in regcache::get_register_status [16/26] gdbserver: boolify regcache fields [17/26] gdbserver: rename regcache's registers_valid to registers_fetched [18/26] gdbsupport: fix a typo in a comment in common-regcache.h [19/26] gdbserver: fix the declared type of register_status in regcache [20/26] gdbserver: make some regcache fields private [21/26] gdbserver: use REG_UNKNOWN for a regcache's register statuses [22/26] gdbserver: zero-out register values in regcache-discard [23/26] gdbserver: set register statuses in registers_from_string [24/26] gdbserver: return tracked register status in regcache_raw_read_unsigned [25/26] gdbserver: refuse null argument in regcache::supply_regblock [26/26] gdbserver: allow gradually populating and selectively storing a regcache

Commit Message

Aktemur, Tankut Baris Feb. 28, 2023, 11:28 a.m. UTC

  The registers_valid and registers_owned fields of the regcache struct
are of type int.  Make them bool.
---
 gdbserver/regcache.cc | 12 ++++++------
 gdbserver/regcache.h  |  4 ++--
 2 files changed, 8 insertions(+), 8 deletions(-)

Comments

Simon Marchi Dec. 22, 2023, 3:20 a.m. UTC | #1

On 2023-02-28 06:28, Tankut Baris Aktemur via Gdb-patches wrote:
> The registers_valid and registers_owned fields of the regcache struct
> are of type int.  Make them bool.

I think that can be pushed right away (well, perhaps it doesn't apply
cleanly without the previous patches, but some equivalent version of
this can be pushed right away).

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon

diff mbox series

Patch

diff --git a/gdbserver/regcache.cc b/gdbserver/regcache.cc
index 0c6f1eb392b..4b56750d06a 100644
--- a/gdbserver/regcache.cc
+++ b/gdbserver/regcache.cc
@@ -57,7 +57,7 @@  get_thread_regcache (struct thread_info *thread, bool fetch)
 void
 regcache::fetch ()
 {
-  if (registers_valid == 0)
+  if (!registers_valid)
     {
       scoped_restore_current_thread restore_thread;
       gdb_assert (this->thread != nullptr);
@@ -66,7 +66,7 @@  regcache::fetch ()
       /* Invalidate all registers, to prevent stale left-overs.  */
       memset (register_status, REG_UNAVAILABLE, tdesc->reg_defs.size ());
       fetch_inferior_registers (this, -1);
-      registers_valid = 1;
+      registers_valid = true;
     }
 }
 
@@ -128,7 +128,7 @@  regcache_invalidate (void)
 void
 regcache::discard ()
 {
-  registers_valid = 0;
+  registers_valid = false;
 }
 
 void
@@ -145,7 +145,7 @@  regcache::initialize (const target_desc *tdesc,
       this->tdesc = tdesc;
       this->registers
 	= (unsigned char *) xcalloc (1, tdesc->registers_size);
-      this->registers_owned = 1;
+      this->registers_owned = true;
       this->register_status
 	= (unsigned char *) xmalloc (tdesc->reg_defs.size ());
       memset ((void *) this->register_status, REG_UNAVAILABLE,
@@ -158,13 +158,13 @@  regcache::initialize (const target_desc *tdesc,
     {
       this->tdesc = tdesc;
       this->registers = regbuf;
-      this->registers_owned = 0;
+      this->registers_owned = false;
 #ifndef IN_PROCESS_AGENT
       this->register_status = nullptr;
 #endif
     }
 
-  this->registers_valid = 0;
+  this->registers_valid = false;
 }
 
 #ifndef IN_PROCESS_AGENT
diff --git a/gdbserver/regcache.h b/gdbserver/regcache.h
index ceef28086ce..f155ac631eb 100644
--- a/gdbserver/regcache.h
+++ b/gdbserver/regcache.h
@@ -41,8 +41,8 @@  struct regcache : public reg_buffer_common
      register cache is _not_ pass-through, unlike GDB's.  Note that
      "valid" here is unrelated to whether the registers are available
      in a traceframe.  For that, check REGISTER_STATUS below.  */
-  int registers_valid = 0;
-  int registers_owned = 0;
+  bool registers_valid = false;
+  bool registers_owned = false;
   unsigned char *registers = nullptr;
 #ifndef IN_PROCESS_AGENT
   /* One of REG_UNAVAILABLE or REG_VALID.  */