diff mbox series

[20/26] gdbserver: make some regcache fields private

Message ID	e212bf44ab32c693e1b46a696afd1666c0d090dc.1677582745.git.tankut.baris.aktemur@intel.com
State	New
Headers	DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 347C03850229 To: gdb-patches@sourceware.org Subject: [PATCH 20/26] gdbserver: make some regcache fields private Date: Tue, 28 Feb 2023 12:28:18 +0100 Message-Id: <e212bf44ab32c693e1b46a696afd1666c0d090dc.1677582745.git.tankut.baris.aktemur@intel.com> In-Reply-To: <cover.1677582744.git.tankut.baris.aktemur@intel.com> References: <cover.1677582744.git.tankut.baris.aktemur@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Precedence: list From: Tankut Baris Aktemur via Gdb-patches <gdb-patches@sourceware.org> Reply-To: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com> Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org>
Series	gdbserver: refactor regcache and allow gradually populating \| [00/26] gdbserver: refactor regcache and allow gradually populating [01/26] gdbserver: convert init_register_cache into regcache::initialize [02/26] gdbserver: convert new_register_cache into a regcache constructor [03/26] gdbserver: by-pass regcache to access tdesc only [04/26] gdbserver: boolify and defaultize the 'fetch' parameter of get_thread_regcache [05/26] gdbserver: add a pointer to the owner thread in regcache [06/26] gdbserver: turn part of get_thread_regcache into regcache::fetch [07/26] gdbserver: convert regcache_cpy into regcache::copy_from [08/26] gdbserver: convert free_register_cache into a destructor of regcache [09/26] gdbserver: extract out regcache::invalidate and regcache::discard [10/26] gdbserver: convert registers_to_string into regcache::registers_to_string [11/26] gdbserver: convert registers_from_string into regcache::registers_from_string [12/26] gdbserver: convert supply_regblock to regcache::supply_regblock [13/26] gdbserver: convert register_data into regcache::register_data [14/26] gdbserver: introduce and use regcache::set_register_status [15/26] gdbserver: check for nullptr condition in regcache::get_register_status [16/26] gdbserver: boolify regcache fields [17/26] gdbserver: rename regcache's registers_valid to registers_fetched [18/26] gdbsupport: fix a typo in a comment in common-regcache.h [19/26] gdbserver: fix the declared type of register_status in regcache [20/26] gdbserver: make some regcache fields private [21/26] gdbserver: use REG_UNKNOWN for a regcache's register statuses [22/26] gdbserver: zero-out register values in regcache-discard [23/26] gdbserver: set register statuses in registers_from_string [24/26] gdbserver: return tracked register status in regcache_raw_read_unsigned [25/26] gdbserver: refuse null argument in regcache::supply_regblock [26/26] gdbserver: allow gradually populating and selectively storing a regcache

Commit Message

Tankut Baris Aktemur Feb. 28, 2023, 11:28 a.m. UTC

  Some fields of the regcache struct are used for internal state
tracking.  Prevent direct access to them from outside by making them
private.
---
 gdbserver/regcache.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff mbox series

Patch

diff --git a/gdbserver/regcache.h b/gdbserver/regcache.h
index ad71a9acaec..be412bc3765 100644
--- a/gdbserver/regcache.h
+++ b/gdbserver/regcache.h
@@ -36,6 +36,8 @@  struct regcache : public reg_buffer_common
   /* Back-link to the thread to which this regcache belongs.  */
   thread_info *thread = nullptr;
 
+private:
+
   /* Whether the REGISTERS buffer's contents are fetched.  If false,
      we haven't fetched the registers from the target yet.  Note that
      this register cache is _not_ pass-through, unlike GDB's.  Also,
@@ -49,6 +51,8 @@  struct regcache : public reg_buffer_common
   /* See gdbsupport/common-regcache.h.  */
   enum register_status *register_status = nullptr;
 
+public:
+
   /* Constructors.  */
   regcache () = default;
   regcache (const target_desc *tdesc);
@@ -59,6 +63,8 @@  struct regcache : public reg_buffer_common
   virtual ~regcache ();
 #endif
 
+public:
+
   /* Init the regcache data.  */
   void initialize (const target_desc *tdesc, unsigned char *regbuf);