diff mbox series

[Committed] Add constraints to new andn<dwi>_doubleword_bmi pattern in i386.md.

Message ID 003e01d88d33$c5864830$5092d890$@nextmovesoftware.com
State Committed
Commit e2d2a8ff4f0dd37336714a25623cc877cf5812b0
Headers
Series [Committed] Add constraints to new andn<dwi>_doubleword_bmi pattern in i386.md. |

Commit Message

Roger Sayle July 1, 2022, 10:17 a.m. UTC 
  Many thanks to Uros for spotting that I'd forgotten to add constraints
to the new define_insn_and_split *andn<dwi>_doubleword_bmi when moving it
from pre-reload to post-reload.  I've pushed this obvious fix after a
make bootstrap on x86_64-pc-linux-gnu.  Sorry for the inconvenience to
anyone building the tree with a non-default architecture that enables
BMI.


2022-07-01  Roger Sayle  <roger@nextmovesoftware.com>
            Uroš Bizjak  <ubizjak@gmail.com>

gcc/ChangeLog
        * config/i386/i386.md (*andn<mode>3_doubleword_bmi): Add constraints
        to post-reload define_insn_and_split.


Roger
--

Comments

Uros Bizjak July 1, 2022, 11:18 a.m. UTC | #1 
On Fri, Jul 1, 2022 at 12:17 PM Roger Sayle <roger@nextmovesoftware.com> wrote:
>
>
> Many thanks to Uros for spotting that I'd forgotten to add constraints
> to the new define_insn_and_split *andn<dwi>_doubleword_bmi when moving it
> from pre-reload to post-reload.  I've pushed this obvious fix after a
> make bootstrap on x86_64-pc-linux-gnu.  Sorry for the inconvenience to
> anyone building the tree with a non-default architecture that enables
> BMI.
>
>
> 2022-07-01  Roger Sayle  <roger@nextmovesoftware.com>
>             Uroš Bizjak  <ubizjak@gmail.com>
>
> gcc/ChangeLog
>         * config/i386/i386.md (*andn<mode>3_doubleword_bmi): Add constraints
>         to post-reload define_insn_and_split.

-  (not:<DWI> (match_operand:<DWI> 1 "register_operand"))
-  (match_operand:<DWI> 2 "nonimmediate_operand")))
+  (not:<DWI> (match_operand:<DWI> 1 "register_operand" "0"))

This constraint can be "r", ANDN is not destructive.

+  (match_operand:<DWI> 2 "nonimmediate_operand" "ro")))

Uros.
diff mbox series

Patch

diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md
index 3401814..352a21c 100644
--- a/gcc/config/i386/i386.md
+++ b/gcc/config/i386/i386.md
@@ -10405,10 +10405,10 @@ 
 })
 
 (define_insn_and_split "*andn<mode>3_doubleword_bmi"
-  [(set (match_operand:<DWI> 0 "register_operand")
+  [(set (match_operand:<DWI> 0 "register_operand" "=r")
 	(and:<DWI>
-	  (not:<DWI> (match_operand:<DWI> 1 "register_operand"))
-	  (match_operand:<DWI> 2 "nonimmediate_operand")))
+	  (not:<DWI> (match_operand:<DWI> 1 "register_operand" "0"))
+	  (match_operand:<DWI> 2 "nonimmediate_operand" "ro")))
    (clobber (reg:CC FLAGS_REG))]
   "TARGET_BMI"
   "#"