internal_error - do not use leading capital letter
Commit Message
That's follow up patch based on the discussion with Jakub.
Ready to be installed?
Thanks,
Martin
gcc/ChangeLog:
* config/rs6000/host-darwin.cc (segv_crash_handler):
Do not use leading capital letter.
(segv_handler): Likewise.
* ipa-sra.cc (verify_splitting_accesses): Likewise.
* varasm.cc (get_section): Likewise.
gcc/d/ChangeLog:
* decl.cc (d_finish_decl): Do not use leading capital letter.
---
gcc/config/rs6000/host-darwin.cc | 4 ++--
gcc/d/decl.cc | 2 +-
gcc/ipa-sra.cc | 4 ++--
gcc/varasm.cc | 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
Comments
> That's follow up patch based on the discussion with Jakub.
>
> Ready to be installed?
> Thanks,
> Martin
>
> gcc/ChangeLog:
>
> * config/rs6000/host-darwin.cc (segv_crash_handler):
> Do not use leading capital letter.
> (segv_handler): Likewise.
> * ipa-sra.cc (verify_splitting_accesses): Likewise.
> * varasm.cc (get_section): Likewise.
>
> gcc/d/ChangeLog:
>
> * decl.cc (d_finish_decl): Do not use leading capital letter.
> ---
> gcc/config/rs6000/host-darwin.cc | 4 ++--
> gcc/d/decl.cc | 2 +-
> gcc/ipa-sra.cc | 4 ++--
> gcc/varasm.cc | 2 +-
> 4 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/gcc/config/rs6000/host-darwin.cc b/gcc/config/rs6000/host-darwin.cc
> index 541f7e1c81c..efb1965004e 100644
> --- a/gcc/config/rs6000/host-darwin.cc
> +++ b/gcc/config/rs6000/host-darwin.cc
> @@ -128,7 +128,7 @@ segv_handler (int sig ATTRIBUTE_UNUSED,
> fprintf (stderr, "[address=%08lx pc=%08x]\n",
> uc->uc_mcontext->MC_FLD(es).MC_FLD(dar),
> uc->uc_mcontext->MC_FLD(ss).MC_FLD(srr0));
> - internal_error ("Segmentation Fault");
> + internal_error ("egmentation fault");
segmentation or perhaps eggmentation? :)
Honza
Excerpts from Martin Liška's message of Januar 27, 2022 1:40 pm:
> That's follow up patch based on the discussion with Jakub.
>
> Ready to be installed?
> Thanks,
> Martin
>
> gcc/ChangeLog:
>
> * config/rs6000/host-darwin.cc (segv_crash_handler):
> Do not use leading capital letter.
> (segv_handler): Likewise.
> * ipa-sra.cc (verify_splitting_accesses): Likewise.
> * varasm.cc (get_section): Likewise.
>
> gcc/d/ChangeLog:
>
> * decl.cc (d_finish_decl): Do not use leading capital letter.
> ---
> gcc/config/rs6000/host-darwin.cc | 4 ++--
> gcc/d/decl.cc | 2 +-
> gcc/ipa-sra.cc | 4 ++--
> gcc/varasm.cc | 2 +-
> 4 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/gcc/d/decl.cc b/gcc/d/decl.cc
> index c7a1e4652f8..5ecc6269780 100644
> --- a/gcc/d/decl.cc
> +++ b/gcc/d/decl.cc
> @@ -1597,7 +1597,7 @@ d_finish_decl (tree decl)
> {
> tree name = DECL_ASSEMBLER_NAME (decl);
>
> - internal_error ("Mismatch between declaration %qE size (%wd) and "
> + internal_error ("mismatch between declaration %qE size (%wd) and "
> "its initializer size (%wd).",
> IDENTIFIER_PRETTY_NAME (name)
> ? IDENTIFIER_PRETTY_NAME (name) : name,
This part is OK for me.
Iain.
On Thu, Jan 27, 2022 at 01:40:15PM +0100, Martin Liška wrote:
> That's follow up patch based on the discussion with Jakub.
>
> Ready to be installed?
> Thanks,
> Martin
>
> gcc/ChangeLog:
>
> * config/rs6000/host-darwin.cc (segv_crash_handler):
> Do not use leading capital letter.
> (segv_handler): Likewise.
> * ipa-sra.cc (verify_splitting_accesses): Likewise.
> * varasm.cc (get_section): Likewise.
>
> gcc/d/ChangeLog:
>
> * decl.cc (d_finish_decl): Do not use leading capital letter.
> ---
> gcc/config/rs6000/host-darwin.cc | 4 ++--
> gcc/d/decl.cc | 2 +-
> gcc/ipa-sra.cc | 4 ++--
> gcc/varasm.cc | 2 +-
> 4 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/gcc/config/rs6000/host-darwin.cc b/gcc/config/rs6000/host-darwin.cc
> index 541f7e1c81c..efb1965004e 100644
> --- a/gcc/config/rs6000/host-darwin.cc
> +++ b/gcc/config/rs6000/host-darwin.cc
> @@ -58,7 +58,7 @@ extern int sigaltstack(const struct sigaltstack *, struct sigaltstack *);
> static void
> segv_crash_handler (int sig ATTRIBUTE_UNUSED)
> {
> - internal_error ("Segmentation Fault (code)");
> + internal_error ("segmentation fault (code)");
> }
> static void
> @@ -128,7 +128,7 @@ segv_handler (int sig ATTRIBUTE_UNUSED,
> fprintf (stderr, "[address=%08lx pc=%08x]\n",
> uc->uc_mcontext->MC_FLD(es).MC_FLD(dar),
> uc->uc_mcontext->MC_FLD(ss).MC_FLD(srr0));
> - internal_error ("Segmentation Fault");
> + internal_error ("egmentation fault");
s went missing.
Otherwise LGTM.
Jakub
@@ -58,7 +58,7 @@ extern int sigaltstack(const struct sigaltstack *, struct sigaltstack *);
static void
segv_crash_handler (int sig ATTRIBUTE_UNUSED)
{
- internal_error ("Segmentation Fault (code)");
+ internal_error ("segmentation fault (code)");
}
static void
@@ -128,7 +128,7 @@ segv_handler (int sig ATTRIBUTE_UNUSED,
fprintf (stderr, "[address=%08lx pc=%08x]\n",
uc->uc_mcontext->MC_FLD(es).MC_FLD(dar),
uc->uc_mcontext->MC_FLD(ss).MC_FLD(srr0));
- internal_error ("Segmentation Fault");
+ internal_error ("egmentation fault");
exit (FATAL_EXIT_CODE);
}
@@ -1597,7 +1597,7 @@ d_finish_decl (tree decl)
{
tree name = DECL_ASSEMBLER_NAME (decl);
- internal_error ("Mismatch between declaration %qE size (%wd) and "
+ internal_error ("mismatch between declaration %qE size (%wd) and "
"its initializer size (%wd).",
IDENTIFIER_PRETTY_NAME (name)
? IDENTIFIER_PRETTY_NAME (name) : name,
@@ -2493,10 +2493,10 @@ verify_splitting_accesses (cgraph_node *node, bool certain_must_exist)
bool certain_access_present = !certain_must_exist;
if (overlapping_certain_accesses_p (desc, &certain_access_present))
- internal_error ("Function %qs, parameter %u, has IPA-SRA accesses "
+ internal_error ("function %qs, parameter %u, has IPA-SRA accesses "
"which overlap", node->dump_name (), pidx);
if (!certain_access_present)
- internal_error ("Function %s, parameter %u, is used but does not "
+ internal_error ("function %qs, parameter %u, is used but does not "
"have any certain IPA-SRA access",
node->dump_name (), pidx);
}
@@ -312,7 +312,7 @@ get_section (const char *name, unsigned int flags, tree decl,
else
{
if (not_existing)
- internal_error ("Section already exists: %qs", name);
+ internal_error ("section already exists: %qs", name);
sect = *slot;
/* It is fine if one of the sections has SECTION_NOTYPE as long as