From patchwork Thu Jan 27 12:40:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Martin_Li=C5=A1ka?= X-Patchwork-Id: 50488 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 47B6B3947411 for ; Thu, 27 Jan 2022 12:40:33 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id A98F0385ED40 for ; Thu, 27 Jan 2022 12:40:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A98F0385ED40 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7FA66210F5; Thu, 27 Jan 2022 12:40:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1643287215; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MpEnEKvb5yCrBs8KfuTCNpn5X86UJTOKrwctxPDY7t0=; b=NrBLxuLXHBRYejjiBuY+iBdb3+gR8yBz9IYjLsgghZbkaZpPfBcYV/OGSYy/axvl27SQSu Pzgr4oS7KVs3+dUN0M8ClxrR0kPG/UOBpYgJBJp0nB5h5c0mQb8uYRrPeRJlo6DUk3xz6V lgxCW5hKrbOA4Zp7HHNfOVKsX5hr7d8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1643287215; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MpEnEKvb5yCrBs8KfuTCNpn5X86UJTOKrwctxPDY7t0=; b=ea7y32Imy4rKDpaCk08z4ty95DKL8hhXa3GFgWKdKHuG8U19ncHURmNrtFAUn502rQ6jZS 6O/rEQgNoSBBQ5Cw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6789913B46; Thu, 27 Jan 2022 12:40:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id duibF6+S8mE9BwAAMHmgww (envelope-from ); Thu, 27 Jan 2022 12:40:15 +0000 Message-ID: Date: Thu, 27 Jan 2022 13:40:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 From: =?utf-8?q?Martin_Li=C5=A1ka?= Subject: [PATCH] internal_error - do not use leading capital letter To: gcc-patches@gcc.gnu.org Content-Language: en-US X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jakub Jelinek Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" That's follow up patch based on the discussion with Jakub. Ready to be installed? Thanks, Martin gcc/ChangeLog: * config/rs6000/host-darwin.cc (segv_crash_handler): Do not use leading capital letter. (segv_handler): Likewise. * ipa-sra.cc (verify_splitting_accesses): Likewise. * varasm.cc (get_section): Likewise. gcc/d/ChangeLog: * decl.cc (d_finish_decl): Do not use leading capital letter. --- gcc/config/rs6000/host-darwin.cc | 4 ++-- gcc/d/decl.cc | 2 +- gcc/ipa-sra.cc | 4 ++-- gcc/varasm.cc | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gcc/config/rs6000/host-darwin.cc b/gcc/config/rs6000/host-darwin.cc index 541f7e1c81c..efb1965004e 100644 --- a/gcc/config/rs6000/host-darwin.cc +++ b/gcc/config/rs6000/host-darwin.cc @@ -58,7 +58,7 @@ extern int sigaltstack(const struct sigaltstack *, struct sigaltstack *); static void segv_crash_handler (int sig ATTRIBUTE_UNUSED) { - internal_error ("Segmentation Fault (code)"); + internal_error ("segmentation fault (code)"); } static void @@ -128,7 +128,7 @@ segv_handler (int sig ATTRIBUTE_UNUSED, fprintf (stderr, "[address=%08lx pc=%08x]\n", uc->uc_mcontext->MC_FLD(es).MC_FLD(dar), uc->uc_mcontext->MC_FLD(ss).MC_FLD(srr0)); - internal_error ("Segmentation Fault"); + internal_error ("egmentation fault"); exit (FATAL_EXIT_CODE); } diff --git a/gcc/d/decl.cc b/gcc/d/decl.cc index c7a1e4652f8..5ecc6269780 100644 --- a/gcc/d/decl.cc +++ b/gcc/d/decl.cc @@ -1597,7 +1597,7 @@ d_finish_decl (tree decl) { tree name = DECL_ASSEMBLER_NAME (decl); - internal_error ("Mismatch between declaration %qE size (%wd) and " + internal_error ("mismatch between declaration %qE size (%wd) and " "its initializer size (%wd).", IDENTIFIER_PRETTY_NAME (name) ? IDENTIFIER_PRETTY_NAME (name) : name, diff --git a/gcc/ipa-sra.cc b/gcc/ipa-sra.cc index 969160f9806..f8a4549c9b0 100644 --- a/gcc/ipa-sra.cc +++ b/gcc/ipa-sra.cc @@ -2493,10 +2493,10 @@ verify_splitting_accesses (cgraph_node *node, bool certain_must_exist) bool certain_access_present = !certain_must_exist; if (overlapping_certain_accesses_p (desc, &certain_access_present)) - internal_error ("Function %qs, parameter %u, has IPA-SRA accesses " + internal_error ("function %qs, parameter %u, has IPA-SRA accesses " "which overlap", node->dump_name (), pidx); if (!certain_access_present) - internal_error ("Function %s, parameter %u, is used but does not " + internal_error ("function %qs, parameter %u, is used but does not " "have any certain IPA-SRA access", node->dump_name (), pidx); } diff --git a/gcc/varasm.cc b/gcc/varasm.cc index 5bc30f0c26e..330ec293711 100644 --- a/gcc/varasm.cc +++ b/gcc/varasm.cc @@ -312,7 +312,7 @@ get_section (const char *name, unsigned int flags, tree decl, else { if (not_existing) - internal_error ("Section already exists: %qs", name); + internal_error ("section already exists: %qs", name); sect = *slot; /* It is fine if one of the sections has SECTION_NOTYPE as long as