diff mbox

gdb/Makefile.in: fix 'make tags' failure

Message ID 0b415071-9af7-6521-8f35-c9766696c98c@mathworks.com
State New, archived
Headers

Commit Message

Mike Gulick Oct. 31, 2017, 12:11 a.m. UTC 
  On 10/30/2017 07:02 PM, Sergio Durigan Junior wrote:
> On Monday, October 30 2017, Mike Gulick wrote:
> 
>> 'make tags' has been broken in master for a couple of weeks.  Hopefully this
>> is small enough to not require copyright attribution.  Otherwise someone can
>> be "inspired" by this change to fix it themselves.
> 
> Thanks for the patch, Mike.  Could you please write a proper ChangeLog
> entry and a more descriptive commit message?  When you do that I can
> push this in for you under the obvious rule.

Sure, how about this:

From e330a7a6763a4d520e2c15792154db1aaa30c86a Mon Sep 17 00:00:00 2001
From: Mike Gulick <mgulick@mathworks.com>
Date: Thu, 19 Oct 2017 16:51:33 -0400
Subject: [PATCH] gdb/Makefile.in: fix 'make tags' failure

'make tags' fails with the following error:

  make[2]: Entering directory '/local-ssd/mgulick/gdb/git/binutils-gdb/gdb'
  make[2]: *** No rule to make target 'gdb.h', needed by 'TAGS'.  Stop.
  make[2]: Leaving directory '/local-ssd/mgulick/gdb/git/binutils-gdb/gdb'

The file gdb/gdb.h was removed in commit
65630365f7d073430e62b4fe65f34dcdc0a4b05e.

gdb/ChangeLog:

* Makefile.in (HFILES_NO_SRCDIR): Remove reference to gdb.h.
---
 gdb/ChangeLog   | 4 ++++
 gdb/Makefile.in | 1 -
 2 files changed, 4 insertions(+), 1 deletion(-)

Comments

Sergio Durigan Junior Oct. 31, 2017, 1:33 a.m. UTC | #1 
On Monday, October 30 2017, Mike Gulick wrote:

> On 10/30/2017 07:02 PM, Sergio Durigan Junior wrote:
>> On Monday, October 30 2017, Mike Gulick wrote:
>> 
>>> 'make tags' has been broken in master for a couple of weeks.  Hopefully this
>>> is small enough to not require copyright attribution.  Otherwise someone can
>>> be "inspired" by this change to fix it themselves.
>> 
>> Thanks for the patch, Mike.  Could you please write a proper ChangeLog
>> entry and a more descriptive commit message?  When you do that I can
>> push this in for you under the obvious rule.
>
> Sure, how about this:
>
> From e330a7a6763a4d520e2c15792154db1aaa30c86a Mon Sep 17 00:00:00 2001
> From: Mike Gulick <mgulick@mathworks.com>
> Date: Thu, 19 Oct 2017 16:51:33 -0400
> Subject: [PATCH] gdb/Makefile.in: fix 'make tags' failure
>
> 'make tags' fails with the following error:
>
>   make[2]: Entering directory '/local-ssd/mgulick/gdb/git/binutils-gdb/gdb'
>   make[2]: *** No rule to make target 'gdb.h', needed by 'TAGS'.  Stop.
>   make[2]: Leaving directory '/local-ssd/mgulick/gdb/git/binutils-gdb/gdb'
>
> The file gdb/gdb.h was removed in commit
> 65630365f7d073430e62b4fe65f34dcdc0a4b05e.
>
> gdb/ChangeLog:
>
> * Makefile.in (HFILES_NO_SRCDIR): Remove reference to gdb.h.

This should have been indented with a TAB; I fixed it in the commit log.
Otherwise, looks good.  I went ahead and pushed as obvious:

f871c4853a9725682011c2314ea4308f3c34bd8d

Thanks!

> ---
>  gdb/ChangeLog   | 4 ++++
>  gdb/Makefile.in | 1 -
>  2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index 5a680ed..a72cc74 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,3 +1,7 @@
> +2017-10-30  Mike Gulick  <mgulick@mathworks.com>
> +
> +	* Makefile.in (HFILES_NO_SRCDIR): Remove reference to gdb.h.
> +
>  2017-10-30  Simon Marchi  <simon.marchi@ericsson.com>
>  
>  	* common/common-utils.h (in_inclusive_range): New function.
> diff --git a/gdb/Makefile.in b/gdb/Makefile.in
> index 6cb0970..1a68746 100644
> --- a/gdb/Makefile.in
> +++ b/gdb/Makefile.in
> @@ -1346,7 +1346,6 @@ HFILES_NO_SRCDIR = \
>  	frv-tdep.h \
>  	ft32-tdep.h \
>  	gcore.h \
> -	gdb.h \
>  	gdb_bfd.h \
>  	gdb_curses.h \
>  	gdb-dlfcn.h \
> -- 
> 2.1.4
Mike Gulick Oct. 31, 2017, 1:41 a.m. UTC | #2 
On 10/30/2017 09:33 PM, Sergio Durigan Junior wrote:
> On Monday, October 30 2017, Mike Gulick wrote:
> 
>> ...
>> gdb/ChangeLog:
>>
>> * Makefile.in (HFILES_NO_SRCDIR): Remove reference to gdb.h.
> 
> This should have been indented with a TAB; I fixed it in the commit log.
> Otherwise, looks good.  I went ahead and pushed as obvious:
> 
> f871c4853a9725682011c2314ea4308f3c34bd8d
> 
> Thanks!
> 

Thank you!
diff mbox

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 5a680ed..a72cc74 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@ 
+2017-10-30  Mike Gulick  <mgulick@mathworks.com>
+
+	* Makefile.in (HFILES_NO_SRCDIR): Remove reference to gdb.h.
+
 2017-10-30  Simon Marchi  <simon.marchi@ericsson.com>
 
 	* common/common-utils.h (in_inclusive_range): New function.
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index 6cb0970..1a68746 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -1346,7 +1346,6 @@  HFILES_NO_SRCDIR = \
 	frv-tdep.h \
 	ft32-tdep.h \
 	gcore.h \
-	gdb.h \
 	gdb_bfd.h \
 	gdb_curses.h \
 	gdb-dlfcn.h \