From patchwork Tue Oct 31 00:11:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Gulick X-Patchwork-Id: 23980 Received: (qmail 83862 invoked by alias); 31 Oct 2017 00:12:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 83852 invoked by uid 89); 31 Oct 2017 00:12:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy=Leaving X-HELO: NAM01-BY2-obe.outbound.protection.outlook.com Received: from mail-by2nam01on0074.outbound.protection.outlook.com (HELO NAM01-BY2-obe.outbound.protection.outlook.com) (104.47.34.74) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 31 Oct 2017 00:12:06 +0000 Received: from [172.28.194.135] (144.212.3.4) by BY2PR0501MB2040.namprd05.prod.outlook.com (10.163.197.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.197.4; Tue, 31 Oct 2017 00:12:02 +0000 Subject: Re: [PATCH] gdb/Makefile.in: fix 'make tags' failure To: Sergio Durigan Junior Cc: gdb-patches@sourceware.org References: <68f1f2bf-a5a9-d1e5-6f5a-ea9d5db3b887@mathworks.com> <874lqg9r3t.fsf@redhat.com> From: Mike Gulick Message-ID: <0b415071-9af7-6521-8f35-c9766696c98c@mathworks.com> Date: Mon, 30 Oct 2017 20:11:52 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <874lqg9r3t.fsf@redhat.com> X-ClientProxiedBy: BN6PR03CA0002.namprd03.prod.outlook.com (10.168.230.140) To BY2PR0501MB2040.namprd05.prod.outlook.com (10.163.197.27) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 67e0e76b-e38b-4043-2714-08d51ff4030a X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(2017052603238); SRVR:BY2PR0501MB2040; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0501MB2040; 3:4pTuYsDZ2j5m/+jfbz7U+JmmrUMTHd1Lv4E2uM9f478/ZPgnKks3jZmiAuETFfQs2DrrrLjrqBJtqZPM1bAys3mmOwgvcajfCR7ysrqxDI/4tnSgfyCphtwwsI6iTeUX5oe+xdM9wSavOQsr/n+KM5PrNOCUYXih3FN0AsEJHkX/vc2DoANXt0HTdxfUYtL8e5Ig9oGT5r3uCZBRpD8usN8Pt9mvfFxTfezrHHdmP2b31bsKbbPHXq4TFJstKwnP; 25:3NHluTl4JeOUaFI30ciK+6P/+7Da9fQrbClhXkZPUdxR7UYcNfvI2fNkQpkHWse0AKy6Y7K2l4LSXhpg/M8KmWvVtL3czS5sRMgz4if7AQPACYTrlzeP4xTcm4NhaeFlNdCEDU1zsYKyBwOQK4TyhxPVpNNppnwee53I7K0UAZ1j9z0NQVZLvW+qTJLxXpI63kQ8nEKTXDvwAb4ZW0mjTXJIsaKl/dIp1xK+pPehX7qK/7+WJugKHqnlZCGNz4BTqOQfCZYVSx4CVENIiQiS65hX2vJeU/QzOTjsnU4NWJWvpYFqeX2QWgT9qOR7CGZpAxmEivHkEeevfLphFS64iT3BTvncWFhc7KKnV7e3enI=; 31:9oNq+UeQvezURWptLm30ZiRjlF5SY+qubwd+RJ87g7EhTNq+RS8Po0X9KObuwjGXB9yfRnZZCLr2Snx6RjaDn8rMIIuZV4wK6SAdg12JAPnJZ2hs8TRn96EzIoUx1DrRLTVUw38laKOm4tDYGfy9YnVMmAvvdwCOcxuYDh1vOaQcVFaJJibrSSkqzUlxiMRSMHF3J5dxNyREUDFjBsJ0ffldjyj/TF3hajUt5O4hY6k= X-MS-TrafficTypeDiagnostic: BY2PR0501MB2040: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Mike.Gulick@mathworks.com; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0501MB2040; 20:+S12H92ZSfXtR5xSoTMUvajsY3++zYL3a7rP1OSlUUiWx5QM7oEZ7J34zu3pc2mWVM+dTPho8SQjcjjmYBtqnsK8JXJjMcYTk3MOYUQhpWTn3+9Iymwl6nZwYPuVSwDJWQrR2ymJCHrGar0182EaVPuY+d8iKxrumzI0h5c14j66fS2ZU9n2Z8eLJRFc3sHrc9tfwLoIxs6alM/SLa07F/bFNugsjjSThGBLft91dRpOfEd0+g2k/k5zYNjV3UqKRgGQJIqqb0y/0KjefRjECENthWyyCmwaD3ntYQvRzmdKBuUe1k/zJURvT4d4zic5RkBhD0gPFYsH8ts/HCGwpXT3j4KeI3keJ4/spMRq4iLw87T8VBSCl/IJJxBK7uViu2+eKrYHHZoodeivcNl+LH46cbsFYA0y6LBv2wUn+AU1BjJZwp7wjpqEBtTWMrFnrGY50K68jz5V13x+Wi1AeTlDrcYm2cWfQEhoa2UQSid3r2mlZa54Bizj75QmcEoF; 4:5tR2FrzzEIdj1ptMv7srcbD+BAZXx90XLBSiQjAnrhoRkdwGvgPFYGU6TN8E0Hxt7zxJNEgEgqBLRoNuXlCtJLKS5qUGfUt6irsiTrkI+ThiNjlmNtEm/oKHcBgZ4mGBaVvSGjG31tCeX4G+CdaaOEjj/15oOyROD/N5RLQR+RTSLVBcZLt/87sEykJwwxlfMIzd8XGBIj2mk065DanxPxt2tiFNOp1xu60bSRJ/WSogHRv7JsHjwvvZK1gvb+DswYfdQWt568phCXMOQVnN586N2BPe71MrZTNI2uCQRghZwhqKF7ogCDabFNLxWYa0 X-Exchange-Antispam-Report-Test: UriScan:(37575265505322); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3231020)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6041248)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BY2PR0501MB2040; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BY2PR0501MB2040; X-Forefront-PRVS: 04772EA191 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(6049001)(346002)(39860400002)(376002)(51914003)(54534003)(377424004)(199003)(24454002)(189002)(68736007)(6916009)(65826007)(53546010)(5660300001)(229853002)(31686004)(76176999)(6246003)(54356999)(53936002)(6116002)(3846002)(101416001)(6666003)(50466002)(50986999)(23676003)(36756003)(2950100002)(8936002)(64126003)(6486002)(97736004)(4326008)(189998001)(230700001)(16526018)(33646002)(90366009)(25786009)(105586002)(106356001)(316002)(16576012)(4001150100001)(8676002)(77096006)(47776003)(86362001)(2906002)(575784001)(66066001)(58126008)(305945005)(65806001)(65956001)(7736002)(83506002)(478600001)(31696002)(72206003)(81156014)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0501MB2040; H:[172.28.194.135]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mathworks.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTJQUjA1MDFNQjIwNDA7MjM6eUFEQ0xSd0l1RmpJMkdKd1pERkFRZGE4?= =?utf-8?B?Y05JcVZPeVZXSmd6cUs1SGhGdzJ1bFZydTJ0QTZnUHdyMVZuSE1MZ3ZTYnhO?= =?utf-8?B?SVNZdWJKOUQxTTNhT1Z4SE5GZWpoYmE4dlk1TjBacGhHRnlOSTM5RTNJcmFw?= =?utf-8?B?bGV2UUUwMkFwa2RiVzh6S3RZODFVa2F2aGtibitkN2cvem9wRVBnbFBrTzRm?= =?utf-8?B?Ukx0eEVWRXNQeStqTFUzZFdyU2lRZHRyZ0QrR3BwT0xQUGQyT0kwcmsvUTRh?= =?utf-8?B?clpncnF5VmgxcDhadzluSkxNaEVaLzA3OEYyNUxMZW8zZHh3TUhsVHI3M2kz?= =?utf-8?B?cXNmVXJmT1l5Z3ZLUmQ1MXlqQitGbU5paVlPN3krMUVVNlZ6d3NNb2k5SzQ1?= =?utf-8?B?Vm9ZWW81UXdMYTdhZXlRbER3MGpINGRkTW1FZ2xNbkZ5WGhENmVhcUxFYVVI?= =?utf-8?B?UHBCaEprdXVUWVJnNko1RDA4VXFWNWowOHJEd2UvRFhOeEJ2dkRhbWdDM3dh?= =?utf-8?B?MFNjL2FiaVhoaHZWaUNwUDViRHRubWhlS3Q2RURxTmxLWHBXSUlFVWJEK0lH?= =?utf-8?B?U28zUjBqUjljenI1Ykw5a1AwWDZIV0tZaVlDUmY3SmJMVDhCUkFlaHRxU0pU?= =?utf-8?B?WC94MDdlNzEybmNLVHYycEc4Q05RcG92NGNTVThIUEdpOHNCNVFHRVhXUDdU?= =?utf-8?B?R1J5RnN4TkNxZkRtOU02S1lxbEdkVVlpc251MXVoM0lOSUFMVVM0VzZEbldT?= =?utf-8?B?WnJoTEtKazZ1cEwxOGo5Rk9sTTlMcnVTRGRZOWp6cXVUOWx5djErcldkcEVZ?= =?utf-8?B?VWNwaFBndEhPZGFjdnVYUnRiOUlUcDluUDJyMjBPZTk2Z3pMcW5pb0FSKzFV?= =?utf-8?B?eVMwTVVVYUlVRDZuZkt3MW5UTjFmWDNOSGt2aXpGY0ZxNmFrRVJzcHl6endl?= =?utf-8?B?QkROMHUxRjVsdE53b2FKakRmMCtIeHg1YXhzUWVxc0d1L04xS0Z3T1VzNk4y?= =?utf-8?B?bWRUYXNNVjZzdXY2OElob1VucFhqbzNWNnBaSjlsUTV0ZHg5ZDYwaGZCeEty?= =?utf-8?B?VGkwZ3B4UGtmNEQwNU9sU2R6T2J3aHRmYTE4TWZxaFp4Um1JKzZvRExoMlhM?= =?utf-8?B?eTdoZzVBZmtvS0VOeTlQRzBpb09yejZJQTR3Wk15SFZqdk01bTNDUVBIYnhy?= =?utf-8?B?dWtzT2RsZkxZNGVja2k5RGlsOHhkdW5RY2JUTXRHYVRBeTNrT0tUeS84cjVu?= =?utf-8?B?VWt1UThlall2OEk2cGF4ZjBSNDJGMHN3UWRlMTh6VUttcldScnVQZm1PUk82?= =?utf-8?B?cWVFZVhxRUM5RWhnWHU5WkxCTkxCdjdlZXhYT29PWGRvZ0taQm9UdW54bnZm?= =?utf-8?B?REp6cjhtbndsSkZRWlhWeE5CWk0rYS9ETlpjZHEwbkhhcG5ZbHZBZDJpd2lw?= =?utf-8?B?Wk81THRFYlNwQmx2LzRUdGsxbjdmck4ycjN5V3ZYaEdSaUEzcVNuNUc1UVM2?= =?utf-8?B?NHZpdUwzditaUGhCVCtwTWJOYmZvMCsxdFdWSzk1b1ZQN2pseWt6YVRkU3dh?= =?utf-8?B?elVkYmQvRzgvT3ZBOFQ5WjFPdE9JcXFybnBHT3M2dnNVZjVSRnZ5SnFKbkxi?= =?utf-8?B?Y1hCRjRvQVB2M0ZDanZ3T1NPRVlaU3ZrQW1wSHlXQVVOYWNSTk1acjI3bDBy?= =?utf-8?B?VkZkK1poT0Z4akdvMDNISFpzVzV5OFJSdFRTTGQxMXpWaGlzL2lsZTg3dWhL?= =?utf-8?B?K2N5b1czSU5SbGxlb3JVMHY1QmFhNHpjSGF1QmlrQXhsK1dZR0NQaGtiTUI5?= =?utf-8?B?U0VVL0RHb0s5WDFhNXpZei9oUitiUEJEcjFzNDNQNlhlRU1rNEtpc0JNNlFL?= =?utf-8?B?cWRRSWFEVTJ6am1LKzFDTkhDb09QZ25DYnVXTWpNTmwyTElVM1luci8zMzVr?= =?utf-8?B?eDVOTjc4MlEyM3krMkFlQ2N6am5VQk1uU3Z0ZE1UWGlNL2ZmWFpqSmIvRTlv?= =?utf-8?B?c0Uzb3hWMVpwcHBCOE8raXFYdEErQVBOeFZBWTVKcTlpemk5NHkveUg2R2pL?= =?utf-8?Q?LjlT20=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0501MB2040; 6:k8vqegG5yvRqN74MkQGVy+XRFLWgqO031Z2Ttdz6HXkNK9j4CiGk3okbRqhMleAxGsTj5306tfhgPvL/JiglEMg7hFvrTP+48zM7BtjInWnsg1GPv0Z5/KxfzXBtmGykLcM06Bk7UbE8U65RQ3jy+KmPSG/CdaNnsU+ouXGoAKmWQ40IzMZ5ElgX5JG6Yyj4NR32TOg6Kczdp1nAVAgtGYVmM3pssPs2LnQ6y0D9OcfuUWc00TGtVOYsbnCq2ZnXMFx8CnoYDn18IpKxlfVNSBCCNwaseJcgejh5YFtXTOe4AHNecpdDd3L8Y+t5XElbxNajuA88A19zdVkMs+0QGnA7wWLbOTh8UoToMlgThcg=; 5:OuUR/UpAIKKueu0eFetubz4lM+onb6rGhMnXbYmI+EwhBf34C0CGPlm3p8f26wfMcgOGGa81WXFryJzct0SI8K+RMiXNRAGpN/jf8bll6egeLe1wc7WPhspAbz4FK9Ni+eMtmbs3ZQGJ9Gn4nN8400xBmkEJjWxVEatjJEsZsNI=; 24:GAWxs8kz1rfn2PnEnUT9VdNmsyy+cw06NWCH1huqeVSpz9Escq6UlU4iy0hwjUVYlkc7ZR28TeRXAuvnkgSWTswzG79iIG4KozNXquelj2k=; 7:BMRXTmhCM1AlMJt9fKLHIdaOIqEKjOKEfXgh9CCU3CoqK7kYOLYMkCbiAgK1ewsHRXCqOh1WHCSjxycB2RLGHOMRHxq7YoB5jVXrTFSy3nE4JotU8zWscqslZA8Ape9em+4Vlm361IRGYQXmX5y7L67EAMjZN2zRjTXCPvhvpyzlF5dhSWJ/i2NNjHk7zcB6wy7Z1StJq6Kev79raHgUKQeYEJUXaGyF1+NXAtKMHHHFtZsfQrUCVCfX482Ig/8P SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: mathworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2017 00:12:02.2833 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 67e0e76b-e38b-4043-2714-08d51ff4030a X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 99dd3a11-4348-4468-9bdd-e5072b1dc1e6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0501MB2040 On 10/30/2017 07:02 PM, Sergio Durigan Junior wrote: > On Monday, October 30 2017, Mike Gulick wrote: > >> 'make tags' has been broken in master for a couple of weeks. Hopefully this >> is small enough to not require copyright attribution. Otherwise someone can >> be "inspired" by this change to fix it themselves. > > Thanks for the patch, Mike. Could you please write a proper ChangeLog > entry and a more descriptive commit message? When you do that I can > push this in for you under the obvious rule. Sure, how about this: From e330a7a6763a4d520e2c15792154db1aaa30c86a Mon Sep 17 00:00:00 2001 From: Mike Gulick Date: Thu, 19 Oct 2017 16:51:33 -0400 Subject: [PATCH] gdb/Makefile.in: fix 'make tags' failure 'make tags' fails with the following error: make[2]: Entering directory '/local-ssd/mgulick/gdb/git/binutils-gdb/gdb' make[2]: *** No rule to make target 'gdb.h', needed by 'TAGS'. Stop. make[2]: Leaving directory '/local-ssd/mgulick/gdb/git/binutils-gdb/gdb' The file gdb/gdb.h was removed in commit 65630365f7d073430e62b4fe65f34dcdc0a4b05e. gdb/ChangeLog: * Makefile.in (HFILES_NO_SRCDIR): Remove reference to gdb.h. --- gdb/ChangeLog | 4 ++++ gdb/Makefile.in | 1 - 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 5a680ed..a72cc74 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2017-10-30 Mike Gulick + + * Makefile.in (HFILES_NO_SRCDIR): Remove reference to gdb.h. + 2017-10-30 Simon Marchi * common/common-utils.h (in_inclusive_range): New function. diff --git a/gdb/Makefile.in b/gdb/Makefile.in index 6cb0970..1a68746 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -1346,7 +1346,6 @@ HFILES_NO_SRCDIR = \ frv-tdep.h \ ft32-tdep.h \ gcore.h \ - gdb.h \ gdb_bfd.h \ gdb_curses.h \ gdb-dlfcn.h \