diff mbox

Remove one line comment

Message ID 1498550237-5641-1-git-send-email-yao.qi@linaro.org
State New, archived
Headers

Commit Message

Yao Qi June 27, 2017, 7:57 a.m. UTC 
  This patch is going to remove a line comment, which was added in this
commit,

commit 55fea07
Author: Jim Kingdon <jkingdon@engr.sgi.com>
Date:   Tue Sep 14 01:08:22 1993 +0000

        * remote.c: Define remote_debug to 0 and #if 0 baud_rate.  Temporary
        hack so this file compiles again.

        * remote-utils.c (gr_multi_scan): Cast return value from alloca.
        (gr_multi_scan): #if 0 never-reached return(-1).

and at that moment, remote_prepare_to_store does updates some global
state,

static void
remote_prepare_to_store ()
{
  /* Make sure the entire registers array is valid.  */
  read_register_bytes (0, (char *)NULL, REGISTER_BYTES);
}

However, now, remote_prepare_to_store doesn't do that at all, and
rsa->sizeof_g_packet is updated in init_remote_state, so the line of
comment is out of date, and this patch removes it.

gdb:

2017-06-27  Yao Qi  <yao.qi@linaro.org>

	* remote.c (store_registers_using_G): Remove one line comment.
---
 gdb/remote.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Yao Qi July 18, 2017, 12:01 p.m. UTC | #1 
Yao Qi <qiyaoltc@gmail.com> writes:

> gdb:
>
> 2017-06-27  Yao Qi  <yao.qi@linaro.org>
>
> 	* remote.c (store_registers_using_G): Remove one line comment.

I pushed it in.
diff mbox

Patch

diff --git a/gdb/remote.c b/gdb/remote.c
index 8e8ee6f..d363a36 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -7844,8 +7844,6 @@  store_registers_using_G (const struct regcache *regcache)
      each byte encoded as two hex characters.  */
   p = rs->buf;
   *p++ = 'G';
-  /* remote_prepare_to_store insures that rsa->sizeof_g_packet gets
-     updated.  */
   bin2hex (regs, p, rsa->sizeof_g_packet);
   putpkt (rs->buf);
   getpkt (&rs->buf, &rs->buf_size, 0);