From patchwork Tue Jun 27 07:57:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 21276 Received: (qmail 27783 invoked by alias); 27 Jun 2017 07:57:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 27765 invoked by uid 89); 27 Jun 2017 07:57:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:static. X-HELO: mail-io0-f173.google.com Received: from mail-io0-f173.google.com (HELO mail-io0-f173.google.com) (209.85.223.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Jun 2017 07:57:22 +0000 Received: by mail-io0-f173.google.com with SMTP id h134so13417818iof.2 for ; Tue, 27 Jun 2017 00:57:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=RqxLzB9cJg7zUNxyUnE0iExnEZ0HXUs+Rx6v4Z551Po=; b=ICuwAx9N804at+lcsJ8TUmylQxsu7m6c3FmDnX2ZMo2EzRiiAjj4MqpKLyW2oJulmx sN+y2JUTkkwfXM7iNeup6guFWpB+RMeZCf4fpH4vxsHKyEb8UtPZvy4GO8MqzrpRLhzN vXwCMqZGjfRh2WOS1rel8JDKbsUhPom+lC5MWT8Fc0iIe7odY+aPaQ76ZiGIlcWwZi16 MOYw995d190MoFheLI8wU0su2nNF5UGZ1H7y7NGQ11np33FjaFQI1to/wQ6FbvDOvIB7 xagNwj5EzfnGzp42fbT5xSz4B2ruB0v4laNmgv/xVBzf1gC7YZ5t53Y3xy7I1kbbNlOR 0N7Q== X-Gm-Message-State: AKS2vOy0PnKgoe5ZR6afQAe7c/7R4oVckrL8deUolpF9BvKnu6ZbMvhI Ad7ouQ3Zx61+qsPG X-Received: by 10.107.180.1 with SMTP id d1mr5466689iof.11.1498550240645; Tue, 27 Jun 2017 00:57:20 -0700 (PDT) Received: from E107787-LIN.cambridge.arm.com (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id e8sm1209252iod.56.2017.06.27.00.57.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 27 Jun 2017 00:57:20 -0700 (PDT) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [PATCH] Remove one line comment Date: Tue, 27 Jun 2017 08:57:17 +0100 Message-Id: <1498550237-5641-1-git-send-email-yao.qi@linaro.org> X-IsSubscribed: yes This patch is going to remove a line comment, which was added in this commit, commit 55fea07 Author: Jim Kingdon Date: Tue Sep 14 01:08:22 1993 +0000 * remote.c: Define remote_debug to 0 and #if 0 baud_rate. Temporary hack so this file compiles again. * remote-utils.c (gr_multi_scan): Cast return value from alloca. (gr_multi_scan): #if 0 never-reached return(-1). and at that moment, remote_prepare_to_store does updates some global state, static void remote_prepare_to_store () { /* Make sure the entire registers array is valid. */ read_register_bytes (0, (char *)NULL, REGISTER_BYTES); } However, now, remote_prepare_to_store doesn't do that at all, and rsa->sizeof_g_packet is updated in init_remote_state, so the line of comment is out of date, and this patch removes it. gdb: 2017-06-27 Yao Qi * remote.c (store_registers_using_G): Remove one line comment. --- gdb/remote.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/gdb/remote.c b/gdb/remote.c index 8e8ee6f..d363a36 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -7844,8 +7844,6 @@ store_registers_using_G (const struct regcache *regcache) each byte encoded as two hex characters. */ p = rs->buf; *p++ = 'G'; - /* remote_prepare_to_store insures that rsa->sizeof_g_packet gets - updated. */ bin2hex (regs, p, rsa->sizeof_g_packet); putpkt (rs->buf); getpkt (&rs->buf, &rs->buf_size, 0);