struct stat: don't typecast to struct kernel_stat were not needed
Commit Message
The cast comes from the beginning of the git history, and probably was needed
when macro CHECK1() was used in syscalls. Now the cast is looking useless, and
breaks build if struct kernel_stat is not declared.
* sysdeps/unix/sysv/linux/fxstat.c: Remove useless cast.
* sysdeps/unix/sysv/linux/lxstat.c: Likewise.
* sysdeps/unix/sysv/linux/xstat.c: Likewise.
* sysdeps/unix/sysv/linux/i386/fxstat.c: Likewise.
* sysdeps/unix/sysv/linux/i386/lxstat.c: Likewise.
* sysdeps/unix/sysv/linux/i386/xstat.c: Likewise.
Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
---
sysdeps/unix/sysv/linux/fxstat.c | 2 +-
sysdeps/unix/sysv/linux/i386/fxstat.c | 2 +-
sysdeps/unix/sysv/linux/i386/lxstat.c | 2 +-
sysdeps/unix/sysv/linux/i386/xstat.c | 2 +-
sysdeps/unix/sysv/linux/lxstat.c | 2 +-
sysdeps/unix/sysv/linux/xstat.c | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
Comments
On Sep 06 2016, Yury Norov <ynorov@caviumnetworks.com> wrote:
> The cast comes from the beginning of the git history, and probably was needed
> when macro CHECK1() was used in syscalls.
Actually it predates the use of INLINE_SYSCALL.
> * sysdeps/unix/sysv/linux/fxstat.c: Remove useless cast.
> * sysdeps/unix/sysv/linux/lxstat.c: Likewise.
> * sysdeps/unix/sysv/linux/xstat.c: Likewise.
> * sysdeps/unix/sysv/linux/i386/fxstat.c: Likewise.
> * sysdeps/unix/sysv/linux/i386/lxstat.c: Likewise.
> * sysdeps/unix/sysv/linux/i386/xstat.c: Likewise.
Ok.
Andreas.
On 9/6/2016 7:28 AM, Yury Norov wrote:
> The cast comes from the beginning of the git history, and probably was needed
> when macro CHECK1() was used in syscalls. Now the cast is looking useless, and
> breaks build if struct kernel_stat is not declared.
>
> * sysdeps/unix/sysv/linux/fxstat.c: Remove useless cast.
> * sysdeps/unix/sysv/linux/lxstat.c: Likewise.
> * sysdeps/unix/sysv/linux/xstat.c: Likewise.
> * sysdeps/unix/sysv/linux/i386/fxstat.c: Likewise.
> * sysdeps/unix/sysv/linux/i386/lxstat.c: Likewise.
> * sysdeps/unix/sysv/linux/i386/xstat.c: Likewise.
>
> Signed-off-by: Yury Norov<ynorov@caviumnetworks.com>
I think you mean "where not needed" in the commit subject.
On Tue, Sep 06, 2016 at 12:19:12PM -0400, Chris Metcalf wrote:
> On 9/6/2016 7:28 AM, Yury Norov wrote:
> >The cast comes from the beginning of the git history, and probably was needed
> >when macro CHECK1() was used in syscalls. Now the cast is looking useless, and
> >breaks build if struct kernel_stat is not declared.
> >
> > * sysdeps/unix/sysv/linux/fxstat.c: Remove useless cast.
> > * sysdeps/unix/sysv/linux/lxstat.c: Likewise.
> > * sysdeps/unix/sysv/linux/xstat.c: Likewise.
> > * sysdeps/unix/sysv/linux/i386/fxstat.c: Likewise.
> > * sysdeps/unix/sysv/linux/i386/lxstat.c: Likewise.
> > * sysdeps/unix/sysv/linux/i386/xstat.c: Likewise.
> >
> >Signed-off-by: Yury Norov<ynorov@caviumnetworks.com>
>
> I think you mean "where not needed" in the commit subject.
Yes. Should I resend it?
On 9/6/2016 12:26 PM, Yury Norov wrote:
> On Tue, Sep 06, 2016 at 12:19:12PM -0400, Chris Metcalf wrote:
>> On 9/6/2016 7:28 AM, Yury Norov wrote:
>>> The cast comes from the beginning of the git history, and probably was needed
>>> when macro CHECK1() was used in syscalls. Now the cast is looking useless, and
>>> breaks build if struct kernel_stat is not declared.
>>>
>>> * sysdeps/unix/sysv/linux/fxstat.c: Remove useless cast.
>>> * sysdeps/unix/sysv/linux/lxstat.c: Likewise.
>>> * sysdeps/unix/sysv/linux/xstat.c: Likewise.
>>> * sysdeps/unix/sysv/linux/i386/fxstat.c: Likewise.
>>> * sysdeps/unix/sysv/linux/i386/lxstat.c: Likewise.
>>> * sysdeps/unix/sysv/linux/i386/xstat.c: Likewise.
>>>
>>> Signed-off-by: Yury Norov<ynorov@caviumnetworks.com>
>> I think you mean "where not needed" in the commit subject.
> Yes. Should I resend it?
I also notice you are missing a space between your name and your <email address>
in your Signed-off-by line. That said, Signed-off-by lines are not common in
glibc repository commits; they are not part of the documented commit process,
so I would avoid including them in your commits.
I'm not sure who is likely to commit your changes, or if you have commit rights
yourself, so I'm not sure how to answer as to whether you need to resend it.
On Tue, Sep 06, 2016 at 12:35:41PM -0400, Chris Metcalf wrote:
> On 9/6/2016 12:26 PM, Yury Norov wrote:
> >On Tue, Sep 06, 2016 at 12:19:12PM -0400, Chris Metcalf wrote:
> >>On 9/6/2016 7:28 AM, Yury Norov wrote:
> >>>The cast comes from the beginning of the git history, and probably was needed
> >>>when macro CHECK1() was used in syscalls. Now the cast is looking useless, and
> >>>breaks build if struct kernel_stat is not declared.
> >>>
> >>> * sysdeps/unix/sysv/linux/fxstat.c: Remove useless cast.
> >>> * sysdeps/unix/sysv/linux/lxstat.c: Likewise.
> >>> * sysdeps/unix/sysv/linux/xstat.c: Likewise.
> >>> * sysdeps/unix/sysv/linux/i386/fxstat.c: Likewise.
> >>> * sysdeps/unix/sysv/linux/i386/lxstat.c: Likewise.
> >>> * sysdeps/unix/sysv/linux/i386/xstat.c: Likewise.
> >>>
> >>>Signed-off-by: Yury Norov<ynorov@caviumnetworks.com>
> >>I think you mean "where not needed" in the commit subject.
> >Yes. Should I resend it?
>
> I also notice you are missing a space between your name and your <email address>
> in your Signed-off-by line. That said, Signed-off-by lines are not common in
> glibc repository commits; they are not part of the documented commit process,
> so I would avoid including them in your commits.
>
> I'm not sure who is likely to commit your changes, or if you have commit rights
> yourself, so I'm not sure how to answer as to whether you need to resend it.
No, I have no that rights. Could someone do it to me?
Yury.
@@ -36,7 +36,7 @@ int
__fxstat (int vers, int fd, struct stat *buf)
{
if (vers == _STAT_VER_KERNEL)
- return INLINE_SYSCALL (fstat, 2, fd, (struct kernel_stat *) buf);
+ return INLINE_SYSCALL (fstat, 2, fd, buf);
#ifdef STAT_IS_KERNEL_STAT
return INLINE_SYSCALL_ERROR_RETURN_VALUE (EINVAL);
@@ -37,7 +37,7 @@ __fxstat (int vers, int fd, struct stat *buf)
int result;
if (vers == _STAT_VER_KERNEL)
- return INLINE_SYSCALL (fstat, 2, fd, (struct kernel_stat *) buf);
+ return INLINE_SYSCALL (fstat, 2, fd, buf);
{
struct stat64 buf64;
@@ -38,7 +38,7 @@ __lxstat (int vers, const char *name, struct stat *buf)
int result;
if (vers == _STAT_VER_KERNEL)
- return INLINE_SYSCALL (lstat, 2, name, (struct kernel_stat *) buf);
+ return INLINE_SYSCALL (lstat, 2, name, buf);
{
struct stat64 buf64;
@@ -38,7 +38,7 @@ __xstat (int vers, const char *name, struct stat *buf)
int result;
if (vers == _STAT_VER_KERNEL)
- return INLINE_SYSCALL (stat, 2, name, (struct kernel_stat *) buf);
+ return INLINE_SYSCALL (stat, 2, name, buf);
{
struct stat64 buf64;
@@ -35,7 +35,7 @@ int
__lxstat (int vers, const char *name, struct stat *buf)
{
if (vers == _STAT_VER_KERNEL)
- return INLINE_SYSCALL (lstat, 2, name, (struct kernel_stat *) buf);
+ return INLINE_SYSCALL (lstat, 2, name, buf);
#ifdef STAT_IS_KERNEL_STAT
return INLINE_SYSCALL_ERROR_RETURN_VALUE (EINVAL);
@@ -35,7 +35,7 @@ int
__xstat (int vers, const char *name, struct stat *buf)
{
if (vers == _STAT_VER_KERNEL)
- return INLINE_SYSCALL (stat, 2, name, (struct kernel_stat *) buf);
+ return INLINE_SYSCALL (stat, 2, name, buf);
#ifdef STAT_IS_KERNEL_STAT
return INLINE_SYSCALL_ERROR_RETURN_VALUE (EINVAL);