From patchwork Tue Sep 6 11:28:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yury Norov X-Patchwork-Id: 15353 Received: (qmail 44145 invoked by alias); 6 Sep 2016 11:29:12 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 44108 invoked by uid 89); 6 Sep 2016 11:29:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*RU:sk:mail-bn, Hx-spam-relays-external:sk:mail-bn, H*r:sk:mail-bn, H*r:104.47.33 X-HELO: NAM01-BN3-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@caviumnetworks.com; From: Yury Norov To: CC: Yury Norov Subject: [PATCH] struct stat: don't typecast to struct kernel_stat were not needed Date: Tue, 6 Sep 2016 14:28:46 +0300 Message-ID: <1473161326-23562-1-git-send-email-ynorov@caviumnetworks.com> MIME-Version: 1.0 X-ClientProxiedBy: AM3PR03CA021.eurprd03.prod.outlook.com (10.141.191.149) To DM3PR07MB2252.namprd07.prod.outlook.com (10.164.33.150) X-MS-Office365-Filtering-Correlation-Id: f1534652-f594-49e3-e524-08d3d648fd2b X-Microsoft-Exchange-Diagnostics: 1; DM3PR07MB2252; 2:AlTOlsfN3en3BciBrm0+fNCsFi/L5rzxFjPfSDGIvkCLCWPrbdMFAcDkvcPuaZSCnvqtZju/mzDJ/w2ZQWxG0jPsKhw5lyjhPynVPoARJ4fbCRO2FmZTkxC8Ij2uagvg7R87squhE5gzr9DKZc6vME+ogXi2PoM0YDHk7iQw/NsA7y/asScit5hlZw64ijlh; 3:/iC3XxuTNkxcRZrKH00kQkwvqcfrhTJtqvXiqa8kwE66NwYjNWO1i3TIdICUbl8/SXLDSdv6ijn6E54qd9VjMsXUz/VG829JS4uywVfBM3M7VS4ORfl4zLZVoCbQjfEr; 25:9VV2FHKaO+X+jEeoUXgiJQGz9edFckjDOUG3YJ5thnOAcNNV7mpIcGMaE1mCBQSKP1gIIn5msEBpLumfVjFaqA8EU2a7+EZXRPICRKed8Epl/oCeZfSbOw+19IMxzi/2qY82/JJ2rSTpgLZgr3qOmn2YCdANkekDTpZOzaPx0k4Azvedix0gS+6phPy8pOpRm0QHhp9yfDiXrMfMLoGMcy6N5hQDKQ3uU2137fC+RMxHiSe2snrY6WFO18A7YMYMj6NCqJS7gtfPbzx5LKVLPk07Pcp+LDNxtciIHGNSZpeEHpIiwS3HzKxhZR/fPMxz/yAS3McNDsPinRQc5z3n5sP2o5ozo83HfCL8JqQJLxvIN2YZFQGzp6n2Elp1RZ4OKNPdgbMXUjQhEMOte3Do2MP25cR64Ihtfvue24bdImg= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM3PR07MB2252; X-Microsoft-Exchange-Diagnostics: 1; DM3PR07MB2252; 31:fHrjuPoSkajnVvVt4vASahsZXppTIBQdam69kxOcY6aexv4NhgJImh9+xjo2Wy18bnQFaIjKIyVhfO88L6wuACoCKi0OLSNTLzinS72d/4wUpxhpH+24Exrf2u6nbIT6E3X1AJFAnUgJWkxfboTxEaoD7tHwHC5FfAStvcb3dHxs6FrPS1qP+kXxy6Lofughbg6n7AIN/j02PZxPbGgNT9imTG4cT4I/apiMRkR3QIQ=; 20:XwJlaFcFq6/IJG+UgxqiOtH3wsxO9RmaMKVsu24fRIliTmcTEFuTEBkOCMTzIdBrgWMqSJsN1KUHd0sTxtdRCU9u9+N88WZUJnohGfJ6Gev/KF7g+eQFf1OxzW4qmD7RHOIt0gLmd5qx5RuasgD1/cCErA4o4aYY4d37tx6xhratlsan+pKZnbLbZBa/QPcSvTlTC8eL0BeOgz2D7M8DU1uaKA+Zz9WMoY2GGdp6B3J2UPo0Td4EiBMrGU8dwst5KlmJhVY8x8w0YW40Hl56P51Y4D2P39gf08DW8sjZa2D+se6ojmfoseAubQk6nvBRn7s5bKG5Jazz6w/OsUJiEeCsFVlSmNN/5XwctLA2zwoSqppJXa2qumgHnC88w8n6GnhbrtjERk7iQRD+9cL1v/e8R6D/qGFt97hiJrm0Vl/16BAB1p025cVMFh45pHYtOyUOxVkmo3BppdjF8fkg/4H4bUXsTD8dQcjRJbEKdMB+DL4ih1jXcUQoSmIhnbuDuNOvUmZhBJrmnuDJkPQttsm71UD1BTaETdlAEwsXzUHTwPvV9yqBd7+uHdiAueaRLsOntqfV3L2VyuW3i7/EAYgCdwjb8bZ/gY8HC+JyIm8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001); SRVR:DM3PR07MB2252; BCL:0; PCL:0; RULEID:; SRVR:DM3PR07MB2252; X-Microsoft-Exchange-Diagnostics: 1; DM3PR07MB2252; 4:q//ZCe2SdFST1rF4nmLU+k/sN/x+Ns2YGtYuowH1izi5NIP3uXIbeoAQZZuagiq8XoRT5H4S2s56/GQf/RaOIZyUle82Yy8GYJ4deStTH3NmWBSzsRP8YSe2v1lhWioCXBCE4doXIGvMaD0+paAsxXg7w8n2iWMIYfSjGRJUTEprWfHT/4rw+uSA+Tv0rO7bb6aeboV5sjEjxA3TNljGB3IvFLHvJRZ5AHf1akK5GY9tMfJmewSJ9vcobdxtY32o45/yZM2vCqtLmV1QPxLJKvmvCpITJYhA1KbzgWNMvD1athlvXrgRYRMAW76WKcu+4u/J42slM5Mt4R0C8LMCMxA8C+Zl2iJOwWNamEzdq/NSE0fnewvTvpCVnvv+B/hB X-Forefront-PRVS: 0057EE387C X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(189002)(199003)(8676002)(450100001)(50466002)(76506005)(101416001)(48376002)(36756003)(68736007)(19580405001)(19580395003)(3846002)(66066001)(50986999)(106356001)(42186005)(105586002)(6116002)(47776003)(81156014)(81166006)(77096005)(33646002)(586003)(5660300001)(2351001)(229853001)(189998001)(5003940100001)(2906002)(7846002)(110136002)(107886002)(4326007)(92566002)(305945005)(97736004)(50226002)(4001430100002)(7736002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM3PR07MB2252; H:localhost; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: caviumnetworks.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM3PR07MB2252; 23:C4+LYuPMkspnu4UEZK5Hd2i0R0POq23lEPe6yHbl3?= =?us-ascii?Q?/cwLmUnWdZ3JmyssvucgoBhtfmD5QCJs4OumwktsJ8IFfSJ2Ct861SCYahJn?= =?us-ascii?Q?kvtIjn9uvx8RGDQdz2N+LPIWLrGQHqPcnIgyGzmBLF79qHUuCWskkCycWPKt?= =?us-ascii?Q?Xhwqq03yN8nGXx7EqJyVqu+fz4RpWqxLfI41rikP/PG6MLI+Dard/Zpi5goX?= =?us-ascii?Q?/Z8bge2+v8byeY9MH56B2cITsptupEKlvEptr8S52MI9SLcPrJ6IPVaXNlx2?= =?us-ascii?Q?UFEGvt7IdWPCyNZsPHq+ogusCJeG/3C8y8TxWekE9tE8zANE5UL67jggVYwl?= =?us-ascii?Q?LL7DEHN7nUYhLS6yz2hDHMPNjBKpIXWtmc7nU9vjEb8hi2zzX71rFvmSYK9O?= =?us-ascii?Q?MmTh5ObO2mXoH04xkZew4l0uCvw+qPdVVnr42RxF3SxLXYXqOI/b3vdxMv3D?= =?us-ascii?Q?I0mneRUy3K2EjJp/JeR7Ppgo/NVTnjAp6Yqx9yvG8+e6opNXpjfbngySN/EF?= =?us-ascii?Q?/ejWiEoXm0xP6Iq/tTpl8hAboETAN/V6a3MPL1OxTJLqTdDPs0JqPfYFeBee?= =?us-ascii?Q?3weHTVK42H0qeAjuihkm2B5CQZ1hP0+YmF5U/sYQoT3gl2Lr0zaKYNiajYy3?= =?us-ascii?Q?gQA33zJ23E0sro1w5ffX4vyWZ7v6ugKmB9g3hO7Gs+m//aqXEkm8NbvUub7R?= =?us-ascii?Q?l5ze1/2Spxw5+5ibPbNEQU8swq0nU6OQ/bp+jhSM0HtUx+PLebnECANadMA4?= =?us-ascii?Q?Rd3nQ/r7/XCQCmDxj3v9Omh2kBBWP62RHj+6elhAxq1bspSS8ZZ8Q6e07lQa?= =?us-ascii?Q?cCOIS65NRzJ5sCU+G+N5G8qgAyDrj0WN5G1Ebt66So9LyanYK8RZycqyZnhz?= =?us-ascii?Q?csF3ftALDLRrRCJCrjFr7TcnCs5pL2agC1ZBxVlLogQjQPSmvVXceh/M7zx0?= =?us-ascii?Q?QZYBSc/Q2yOwFZkzr1c1ODHetrJ5jW3KdYRwOApkGm1056+ix4BkEeLzR9Fb?= =?us-ascii?Q?ZTqu+SUUcTuuNpAKxTVpv5Kx+xfq3bZdbgo+4L5QNQFiGhuhiROeFxrB4sGt?= =?us-ascii?Q?sL90WXujspCbeXDccvPHkfcYNXmhdtwYNCGXjYZb+3xYj4rmlaOAgZatM1vz?= =?us-ascii?Q?bTPYxWTWm/mtjdazpZ0+Uvw8MRU8LZI?= X-Microsoft-Exchange-Diagnostics: 1; DM3PR07MB2252; 6:klasen5GlP3abhnYiF2Kik+9De3kNoOB49lDEqHV/TsFJH1p47cTITPIZ9mg9HfroemG5OrY90GN9I6lUJctWvXU1SLhLzxHH2FzaDxEP9DqkeArqavOfGOuKt1mON8OGA7FchiE1yzziwmovp+HOBn4oB7028vqfvmIlF+/NdFFph633H4yy7eYwoBF/lZ9b11fsKza3der3ONT4mvyU1E3/opWUoJ85TMYxT86dE8yXXRNESOvM3dOky/uUsni1nXB5JR7WguutEI8ZgqvI9vdpHIlYzlWxbX8dRqREXQ=; 5:aLCG3yXg7RlhQ/SjvxmdvcSt4e5BXu5rIS1n01C3vjBrUhPZPN6gZilCM6vHGHkqvNSjTtrS62mBXL5Lm07/ObE5CW3okkmv8Rm4u/R4tgyB97wou9j46Gtp70aLM7XtfoL/z9pyrVsn7upj8Nv5aw==; 24:PzM7mUGoLTFAsPxzpp2qVfNRzowxzcfsuPSpcKc6Zus3ZAg7KTeoAPqxx8fU62P1v/KyyCQF+0jtcotmuuSUbcoHdJe5e6kDZV4T7uuUUjU=; 7:llJ5s51aZXhYf5+Lz6q9Z9BxLtD9BBmjG2xtbjD/6EProvUPOTX7NfU+oviIdv91yx162ZRES4TdN6pQ60EDTgf2jffG/ORmn44yrbD0ymNAJzN+JoUoJeVMDWljO59hSVn3nhq8aWmF2XLfqwQ6tJQKZvA/VBVqFCFxQAaGm3nXt9YBASWfMUKPPx0Pe1cGkuQHIv4LGa424ONodaP7jAlJua0pZPEYtZFDgu2bDlphLI2ezbaqMi+2XLRv2TYt SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2016 11:28:55.8439 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR07MB2252 The cast comes from the beginning of the git history, and probably was needed when macro CHECK1() was used in syscalls. Now the cast is looking useless, and breaks build if struct kernel_stat is not declared. * sysdeps/unix/sysv/linux/fxstat.c: Remove useless cast. * sysdeps/unix/sysv/linux/lxstat.c: Likewise. * sysdeps/unix/sysv/linux/xstat.c: Likewise. * sysdeps/unix/sysv/linux/i386/fxstat.c: Likewise. * sysdeps/unix/sysv/linux/i386/lxstat.c: Likewise. * sysdeps/unix/sysv/linux/i386/xstat.c: Likewise. Signed-off-by: Yury Norov --- sysdeps/unix/sysv/linux/fxstat.c | 2 +- sysdeps/unix/sysv/linux/i386/fxstat.c | 2 +- sysdeps/unix/sysv/linux/i386/lxstat.c | 2 +- sysdeps/unix/sysv/linux/i386/xstat.c | 2 +- sysdeps/unix/sysv/linux/lxstat.c | 2 +- sysdeps/unix/sysv/linux/xstat.c | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/sysdeps/unix/sysv/linux/fxstat.c b/sysdeps/unix/sysv/linux/fxstat.c index 858679d..e33023b 100644 --- a/sysdeps/unix/sysv/linux/fxstat.c +++ b/sysdeps/unix/sysv/linux/fxstat.c @@ -36,7 +36,7 @@ int __fxstat (int vers, int fd, struct stat *buf) { if (vers == _STAT_VER_KERNEL) - return INLINE_SYSCALL (fstat, 2, fd, (struct kernel_stat *) buf); + return INLINE_SYSCALL (fstat, 2, fd, buf); #ifdef STAT_IS_KERNEL_STAT return INLINE_SYSCALL_ERROR_RETURN_VALUE (EINVAL); diff --git a/sysdeps/unix/sysv/linux/i386/fxstat.c b/sysdeps/unix/sysv/linux/i386/fxstat.c index c1a7613..b21dced 100644 --- a/sysdeps/unix/sysv/linux/i386/fxstat.c +++ b/sysdeps/unix/sysv/linux/i386/fxstat.c @@ -37,7 +37,7 @@ __fxstat (int vers, int fd, struct stat *buf) int result; if (vers == _STAT_VER_KERNEL) - return INLINE_SYSCALL (fstat, 2, fd, (struct kernel_stat *) buf); + return INLINE_SYSCALL (fstat, 2, fd, buf); { struct stat64 buf64; diff --git a/sysdeps/unix/sysv/linux/i386/lxstat.c b/sysdeps/unix/sysv/linux/i386/lxstat.c index 3ddaf74..445d154 100644 --- a/sysdeps/unix/sysv/linux/i386/lxstat.c +++ b/sysdeps/unix/sysv/linux/i386/lxstat.c @@ -38,7 +38,7 @@ __lxstat (int vers, const char *name, struct stat *buf) int result; if (vers == _STAT_VER_KERNEL) - return INLINE_SYSCALL (lstat, 2, name, (struct kernel_stat *) buf); + return INLINE_SYSCALL (lstat, 2, name, buf); { struct stat64 buf64; diff --git a/sysdeps/unix/sysv/linux/i386/xstat.c b/sysdeps/unix/sysv/linux/i386/xstat.c index eb85499..915a80e 100644 --- a/sysdeps/unix/sysv/linux/i386/xstat.c +++ b/sysdeps/unix/sysv/linux/i386/xstat.c @@ -38,7 +38,7 @@ __xstat (int vers, const char *name, struct stat *buf) int result; if (vers == _STAT_VER_KERNEL) - return INLINE_SYSCALL (stat, 2, name, (struct kernel_stat *) buf); + return INLINE_SYSCALL (stat, 2, name, buf); { struct stat64 buf64; diff --git a/sysdeps/unix/sysv/linux/lxstat.c b/sysdeps/unix/sysv/linux/lxstat.c index e36204a..c8bf06d 100644 --- a/sysdeps/unix/sysv/linux/lxstat.c +++ b/sysdeps/unix/sysv/linux/lxstat.c @@ -35,7 +35,7 @@ int __lxstat (int vers, const char *name, struct stat *buf) { if (vers == _STAT_VER_KERNEL) - return INLINE_SYSCALL (lstat, 2, name, (struct kernel_stat *) buf); + return INLINE_SYSCALL (lstat, 2, name, buf); #ifdef STAT_IS_KERNEL_STAT return INLINE_SYSCALL_ERROR_RETURN_VALUE (EINVAL); diff --git a/sysdeps/unix/sysv/linux/xstat.c b/sysdeps/unix/sysv/linux/xstat.c index b8b0750..cbd5aeb 100644 --- a/sysdeps/unix/sysv/linux/xstat.c +++ b/sysdeps/unix/sysv/linux/xstat.c @@ -35,7 +35,7 @@ int __xstat (int vers, const char *name, struct stat *buf) { if (vers == _STAT_VER_KERNEL) - return INLINE_SYSCALL (stat, 2, name, (struct kernel_stat *) buf); + return INLINE_SYSCALL (stat, 2, name, buf); #ifdef STAT_IS_KERNEL_STAT return INLINE_SYSCALL_ERROR_RETURN_VALUE (EINVAL);