Re: Patch for GNU/kFreeBSD

Message ID 20160521080638.GA9777@ubuntubsd.org
State New, archived
Headers

Commit Message

Jon Boden May 21, 2016, 8:06 a.m. UTC
  Hi!

On Thu, May 19, 2016 at 02:33:50PM +0100, Yao Qi wrote:
> Thanks for the explanation.  Could you write this explanation down in
> configure.ac close to your change as a comment?  so people can
> understand easily why do we check util and util-freebsd.

Done that (patch is attached).

> You also need
> 
> 	* configure: Re-generated.
> 
> otherwise, patch is good to me.  If you don't have the account to push
> your patch in, I can do it for you.

I don't have an account, could you do this for me?

Updated ChangeLog entry:

2016-05-21  Jon Boden  <jon@ubuntubsd.org>

	* configure.ac: Search for libutil-freebsd as alternative to libutil.
	* configure: Re-generated.

Thank you
  

Comments

Yao Qi May 23, 2016, 7:50 a.m. UTC | #1
Jon Boden <jon@ubuntubsd.org> writes:

> I don't have an account, could you do this for me?

Your patch is pushed in.
  

Patch

diff -ur gdb-7.11.50.20160521.old/gdb/configure gdb-7.11.50.20160521/gdb/configure
--- gdb-7.11.50.20160521.old/gdb/configure	2016-05-20 21:48:46.000000000 -0400
+++ gdb-7.11.50.20160521/gdb/configure	2016-05-21 04:04:14.000000000 -0400
@@ -7050,6 +7050,7 @@ 
 
 
 # On FreeBSD we may need libutil for kinfo_getvmmap (used by fbsd-nat.c).
+# On GNU/kFreeBSD systems, FreeBSD libutil is renamed to libutil-freebsd.
 { $as_echo "$as_me:${as_lineno-$LINENO}: checking for library containing kinfo_getvmmap" >&5
 $as_echo_n "checking for library containing kinfo_getvmmap... " >&6; }
 if test "${ac_cv_search_kinfo_getvmmap+set}" = set; then :
@@ -7074,7 +7075,7 @@ 
   return 0;
 }
 _ACEOF
-for ac_lib in '' util; do
+for ac_lib in '' util util-freebsd; do
   if test -z "$ac_lib"; then
     ac_res="none required"
   else
diff -ur gdb-7.11.50.20160521.old/gdb/configure.ac gdb-7.11.50.20160521/gdb/configure.ac
--- gdb-7.11.50.20160521.old/gdb/configure.ac	2016-05-20 21:48:46.000000000 -0400
+++ gdb-7.11.50.20160521/gdb/configure.ac	2016-05-21 04:04:05.000000000 -0400
@@ -535,7 +535,8 @@ 
 AM_ZLIB
 
 # On FreeBSD we may need libutil for kinfo_getvmmap (used by fbsd-nat.c).
-AC_SEARCH_LIBS(kinfo_getvmmap, util,
+# On GNU/kFreeBSD systems, FreeBSD libutil is renamed to libutil-freebsd.
+AC_SEARCH_LIBS(kinfo_getvmmap, util util-freebsd,
   [AC_DEFINE(HAVE_KINFO_GETVMMAP, 1,
             [Define to 1 if your system has the kinfo_getvmmap function. ])])