From patchwork Sat May 21 08:06:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jon Boden X-Patchwork-Id: 12439 Received: (qmail 88742 invoked by alias); 21 May 2016 08:06:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 88728 invoked by uid 89); 21 May 2016 08:06:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=UD:twitter.com, 2016-05-21, twitter.com, twittercom X-HELO: gtw.aybabtu.com Received: from archive.ubuntubsd.org (HELO gtw.aybabtu.com) (78.46.208.135) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 21 May 2016 08:06:41 +0000 Received: from jon by gtw.aybabtu.com with local (Exim 4.82) (envelope-from ) id 1b41vi-0002yQ-2Y; Sat, 21 May 2016 10:06:38 +0200 Date: Sat, 21 May 2016 10:06:38 +0200 From: Jon Boden To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Re: Patch for GNU/kFreeBSD Message-ID: <20160521080638.GA9777@ubuntubsd.org> References: <20160513205750.GA23358@ubuntubsd.org> <86k2iu9ml8.fsf@gmail.com> <20160517203454.GA8967@ubuntubsd.org> <86twhu894x.fsf@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <86twhu894x.fsf@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Hi! On Thu, May 19, 2016 at 02:33:50PM +0100, Yao Qi wrote: > Thanks for the explanation. Could you write this explanation down in > configure.ac close to your change as a comment? so people can > understand easily why do we check util and util-freebsd. Done that (patch is attached). > You also need > > * configure: Re-generated. > > otherwise, patch is good to me. If you don't have the account to push > your patch in, I can do it for you. I don't have an account, could you do this for me? Updated ChangeLog entry: 2016-05-21 Jon Boden * configure.ac: Search for libutil-freebsd as alternative to libutil. * configure: Re-generated. Thank you diff -ur gdb-7.11.50.20160521.old/gdb/configure gdb-7.11.50.20160521/gdb/configure --- gdb-7.11.50.20160521.old/gdb/configure 2016-05-20 21:48:46.000000000 -0400 +++ gdb-7.11.50.20160521/gdb/configure 2016-05-21 04:04:14.000000000 -0400 @@ -7050,6 +7050,7 @@ # On FreeBSD we may need libutil for kinfo_getvmmap (used by fbsd-nat.c). +# On GNU/kFreeBSD systems, FreeBSD libutil is renamed to libutil-freebsd. { $as_echo "$as_me:${as_lineno-$LINENO}: checking for library containing kinfo_getvmmap" >&5 $as_echo_n "checking for library containing kinfo_getvmmap... " >&6; } if test "${ac_cv_search_kinfo_getvmmap+set}" = set; then : @@ -7074,7 +7075,7 @@ return 0; } _ACEOF -for ac_lib in '' util; do +for ac_lib in '' util util-freebsd; do if test -z "$ac_lib"; then ac_res="none required" else diff -ur gdb-7.11.50.20160521.old/gdb/configure.ac gdb-7.11.50.20160521/gdb/configure.ac --- gdb-7.11.50.20160521.old/gdb/configure.ac 2016-05-20 21:48:46.000000000 -0400 +++ gdb-7.11.50.20160521/gdb/configure.ac 2016-05-21 04:04:05.000000000 -0400 @@ -535,7 +535,8 @@ AM_ZLIB # On FreeBSD we may need libutil for kinfo_getvmmap (used by fbsd-nat.c). -AC_SEARCH_LIBS(kinfo_getvmmap, util, +# On GNU/kFreeBSD systems, FreeBSD libutil is renamed to libutil-freebsd. +AC_SEARCH_LIBS(kinfo_getvmmap, util util-freebsd, [AC_DEFINE(HAVE_KINFO_GETVMMAP, 1, [Define to 1 if your system has the kinfo_getvmmap function. ])])