diff mbox series

[01/10] sim/sh: use fabs instead of abs

Message ID 4541c5ca4462cd0c813b0c72b37dacf8270580d1.1666192979.git.aburgess@redhat.com
State Committed
Commit ffa2d048221147bad30dde3cfbcb535a824b203d
Headers
Series Building the sim/ tree with clang |

Commit Message

Andrew Burgess Oct. 19, 2022, 3:24 p.m. UTC 
  The sh simulator incorrectly uses integer abs instead of the floating
point fabs on some floating point values, fixed in this commit.
---
 sim/sh/interp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mike Frysinger Oct. 23, 2022, 1:53 p.m. UTC | #1 
lgtm
-mike
Andrew Burgess Oct. 24, 2022, 4:05 p.m. UTC | #2 
Mike Frysinger <vapier@gentoo.org> writes:

> lgtm

Pushed.

Thanks,
Andrew
diff mbox series

Patch

diff --git a/sim/sh/interp.c b/sim/sh/interp.c
index fb92d9f4480..38f3f945a35 100644
--- a/sim/sh/interp.c
+++ b/sim/sh/interp.c
@@ -1401,7 +1401,7 @@  fsca_s (int in, double (*f) (double))
   lower = result - error;
   frac = frexp (lower, &exp);
   lower = ldexp (ceil (ldexp (frac, 24)), exp - 24);
-  return abs (upper - result) >= abs (lower - result) ? upper : lower;
+  return fabs (upper - result) >= fabs (lower - result) ? upper : lower;
 }
 
 static float