From patchwork Wed Oct 19 15:24:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 59070 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1D7D03857830 for ; Wed, 19 Oct 2022 15:27:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1D7D03857830 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666193231; bh=nQVJ1iskUvG5BrhR1VJl0j2/9QTK/oIqmpudBCZwesk=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=L19zg9DPpELueMw9CHwE5/NMpfeR6cXJX4Do5fv1SYYlvEJ0v0QyphcCDSOCrlby2 LxNvhdCzOJQB9vWzAKzE1oM38EgWEVAG42GA6K+ZCmkeylo4avDgYvqasqaIdFhzUG AfZC116PB+piYeOB8TRER8n0J4jB/GiaBMNp17OA= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B49A3385116F for ; Wed, 19 Oct 2022 15:24:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B49A3385116F Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-664-bOrnywxvNXu5qh0MdN52WQ-1; Wed, 19 Oct 2022 11:24:57 -0400 X-MC-Unique: bOrnywxvNXu5qh0MdN52WQ-1 Received: by mail-qv1-f70.google.com with SMTP id 71-20020a0c804d000000b004b2fb260447so10921972qva.10 for ; Wed, 19 Oct 2022 08:24:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nQVJ1iskUvG5BrhR1VJl0j2/9QTK/oIqmpudBCZwesk=; b=ZmVShoLmsmiXmnKeaIythQkhTZcHAxh7EeMOZbYSsPW8j5sXG1KcuaGYX3JumlH6L8 sWz3IXtw25fyeHJZIhQGipqKOB150pbLA3oMaHW0WkutTkR2uRTFUWsPGbHb7otC5KY3 aswOUC0I+YPNySgAypUWY4GWPbDuecLWl1zjqgr1GW1hMCKr87O1uA8YRTk4fKhTPnJX WOHEpHDiOfNOJ3cZPdg+WgtMN5lYiAkl1GJRAWeE2oTVSGooxrQEY4avcpfiYEChg2ri 7t0/6DjpFymaAo+rXgkBjAJYZAv0CPdo2EqKg5Vgk/UWLSBNLy6hO1FBGvpFVvQTxSwp kvQA== X-Gm-Message-State: ACrzQf1z3SDtfsbFll4VTvwuiOe8GlAD1oRR0fTypAZrgcAPr7cYOBiI gz6DQzgzrHdBW2KUw9uLvikWb+PyI8zA9F/Dwn4gVCnI4G9XIml04slCcY8M57qGYBykA5vb8zg /gEBO8VaxCdjyMhzAmvlxIKxV8cvvTm6ephJ5ahB3Y83qt8+3lGGbdfO1+vnuOxPm8wCOFViJYw == X-Received: by 2002:a05:6214:5006:b0:4b6:c5ab:a46 with SMTP id jo6-20020a056214500600b004b6c5ab0a46mr1205460qvb.106.1666193096776; Wed, 19 Oct 2022 08:24:56 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4HRJ6+FYGuk6ZvlGBFs9Ch3VkwMu/yAxIGA5fQeLxyRYO58PYJEhQdmVzrY982s8jzlnSjTw== X-Received: by 2002:a05:6214:5006:b0:4b6:c5ab:a46 with SMTP id jo6-20020a056214500600b004b6c5ab0a46mr1205441qvb.106.1666193096555; Wed, 19 Oct 2022 08:24:56 -0700 (PDT) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id j4-20020a05620a410400b006eef13ef4c8sm3895737qko.94.2022.10.19.08.24.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 08:24:56 -0700 (PDT) To: gdb-patches@sourceware.org Subject: [PATCH 01/10] sim/sh: use fabs instead of abs Date: Wed, 19 Oct 2022 16:24:40 +0100 Message-Id: <4541c5ca4462cd0c813b0c72b37dacf8270580d1.1666192979.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Burgess via Gdb-patches From: Andrew Burgess Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" The sh simulator incorrectly uses integer abs instead of the floating point fabs on some floating point values, fixed in this commit. --- sim/sh/interp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sim/sh/interp.c b/sim/sh/interp.c index fb92d9f4480..38f3f945a35 100644 --- a/sim/sh/interp.c +++ b/sim/sh/interp.c @@ -1401,7 +1401,7 @@ fsca_s (int in, double (*f) (double)) lower = result - error; frac = frexp (lower, &exp); lower = ldexp (ceil (ldexp (frac, 24)), exp - 24); - return abs (upper - result) >= abs (lower - result) ? upper : lower; + return fabs (upper - result) >= fabs (lower - result) ? upper : lower; } static float From patchwork Wed Oct 19 15:24:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 59068 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8A893384B12B for ; Wed, 19 Oct 2022 15:26:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8A893384B12B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666193174; bh=ixV7giNbCuSgs6h4Kf7zWl3gsTQr3+ixysQqZZ0MVnw=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=kFxlna2bY7TanfVbDRPDsjoeQ/o/Rvq8KEugfd4KHuccgZ5CkAYiYigMRLXouxzcf RCtSpuK25sFkD49mZ6uTH0phDFZUFpvtNrjPlnxjUfgUdE+/g5XQk+jZwwN4RfJl2r MKyvYueAHtXhGuRTxFg6OhgKTek3wuXOmKLNSTbc= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B97E83853571 for ; Wed, 19 Oct 2022 15:25:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B97E83853571 Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-621-oKBIcPMCNvCKqWvoeyRCpQ-1; Wed, 19 Oct 2022 11:24:59 -0400 X-MC-Unique: oKBIcPMCNvCKqWvoeyRCpQ-1 Received: by mail-qt1-f198.google.com with SMTP id fy10-20020a05622a5a0a00b0039cd5097697so12262390qtb.7 for ; Wed, 19 Oct 2022 08:24:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ixV7giNbCuSgs6h4Kf7zWl3gsTQr3+ixysQqZZ0MVnw=; b=4Qz6E7txdN0gzJiHnQGGZ7tANT2iDrU2ZkmRyfHdNpJyETVLoSxEhC7mjTdtQltxqy NJpDt8aGx8mkSsUsHPPibMFQ+TmoKdNoQupWjgMImNkjJsoOYNclKeQKwFkqMl8PmgHF p7aSB0uyDLtf+otLiQNlfNPwHlk5jcMJRZ4Vn59pR5lq3zYP5r8XpH3bf9BaFHbRpTc9 sOKP4E3BlWYPL/LFFg1sKjDAD9yxZ7sPQaPT9jKnteKlx4fw9lF3Qiz7DaYFj3v2+V9P uRcLKsVwXD9cjfk1eu7GsqYtPQw0eozTaxhFBAwYlPeO6t5uzovGL+y/dVok7ti1pPur HJlA== X-Gm-Message-State: ACrzQf2huQ54FOwqBaqvlBbNOwHfs00NrBq6BXTr+0/At25dddxM14Uy KjmUp4psBfDOK6WTI7cXAfj006cTUViV2RNO7ghKkoyRXO7rNMv0r3C1f9XZ63aZ1Himmix4nlh bb3MvfSUS+OfeN4aQ0TQUiI44/n0N7brhJKuG1dbWw9sjzXjWD/If7N3/sX5voTCkJK0TmqmoFA == X-Received: by 2002:a05:6214:2306:b0:473:f77a:85a7 with SMTP id gc6-20020a056214230600b00473f77a85a7mr7068379qvb.106.1666193099073; Wed, 19 Oct 2022 08:24:59 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5740C0Wh0WgBpCeK16pvcfVepntTOF10HEvNzL4Cc9U4lD6RRqCC5WjAJuStzps2qP+XB8jw== X-Received: by 2002:a05:6214:2306:b0:473:f77a:85a7 with SMTP id gc6-20020a056214230600b00473f77a85a7mr7068340qvb.106.1666193098507; Wed, 19 Oct 2022 08:24:58 -0700 (PDT) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id y2-20020a05620a0e0200b006ee8874f5d8sm4969117qkm.28.2022.10.19.08.24.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 08:24:58 -0700 (PDT) To: gdb-patches@sourceware.org Subject: [PATCH 02/10] sim/ppc: don't try to print an uninitialized variable Date: Wed, 19 Oct 2022 16:24:41 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Burgess via Gdb-patches From: Andrew Burgess Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" The ppc simulator, in sim_create_inferior, tries to print the function local entry_point variable before the variable is initialized. In this commit, I defer the debug print line until the variable has been initialized. --- sim/ppc/sim_calls.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sim/ppc/sim_calls.c b/sim/ppc/sim_calls.c index 729f6dcb6f3..3dcce19f628 100644 --- a/sim/ppc/sim_calls.c +++ b/sim/ppc/sim_calls.c @@ -161,8 +161,6 @@ sim_create_inferior (SIM_DESC sd, char * const *envp) { unsigned_word entry_point; - TRACE(trace_gdb, ("sim_create_inferior(start_address=0x%x, ...)\n", - entry_point)); if (simulator == NULL) error ("No program loaded"); @@ -172,6 +170,9 @@ sim_create_inferior (SIM_DESC sd, else entry_point = 0xfff00000; /* ??? */ + TRACE(trace_gdb, ("sim_create_inferior(start_address=0x%x, ...)\n", + entry_point)); + psim_init(simulator); psim_stack(simulator, argv, envp); From patchwork Wed Oct 19 15:24:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 59066 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BCF14384D18F for ; Wed, 19 Oct 2022 15:25:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BCF14384D18F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666193144; bh=NCgz7xQ5GlxL4lUCRpx14/zvTMRl0SyBfGfibEmCWDs=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=qd7WrSirlf7nMOz6qRkdMF3774NG9ZP6VRka5Ff7XZnIHo3GdjecbaQaR8t/BTA3h Di4Xn6VTaRfihOMgdtDDevw9Ybi3I/54lhWujcRiFxN9j4E2scFeJhuQ1O29M7qJ7y x+1TQy5igFvPXiZy/1dikuSrbvfbpDdbDtnnoG6o= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B96BC3853560 for ; Wed, 19 Oct 2022 15:25:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B96BC3853560 Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-172-VnUPAFmPP0q8ukexT2didQ-1; Wed, 19 Oct 2022 11:25:01 -0400 X-MC-Unique: VnUPAFmPP0q8ukexT2didQ-1 Received: by mail-qv1-f70.google.com with SMTP id 71-20020a0c804d000000b004b2fb260447so10922093qva.10 for ; Wed, 19 Oct 2022 08:25:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NCgz7xQ5GlxL4lUCRpx14/zvTMRl0SyBfGfibEmCWDs=; b=TPkI5biuvbIRxCgsV3AEURs5Ymn6RoFuVoagBwu7iLpztnwzlJTOyHPF4XSZsRX67T oHbmJ0WcqROhoyV41pkZjgmX+PmvSkuAQ4JTfhGt6ooBHCUKySm21g1UOQ+Oxs77f1PJ UgSNTv21I/1hDzRRd+plpLg9b1m6IIDXcXaGmyw3VY2Ll68yvP3lpCARVAwWpfct/6Gr 4u++O/K/TeI7sIWqCRsqI5mg0z71jjofH17Fmw/BdsELYr2VP6rBAaphWx9rDoTQerE4 bFpOKuhBzfBiZocGxIIyb/l/fRxoGqHv0MQUvvaVmFr6viu6y6MYb2uS7qaqHwaQYpfB eFLw== X-Gm-Message-State: ACrzQf0iBAm9Q8CqFRzKmGZLuao06RmFmDXprXJs6HzTfRJlPH9pVPmC IP/wvpJhwvFt6Ew4f6zHXHayUwJ2/BYnX/BwGt1Jslc8wFb2t44Frlvly1VTgnK03M+m2NdAAtQ hVKUJ5Q2IBilU2UjdkuKj0osHhQzSXjwiopQtgXp50X/LS7XEl5CW7CGu6adtW0l6SpIyFMV3fg == X-Received: by 2002:a05:620a:4054:b0:6ec:5735:2e20 with SMTP id i20-20020a05620a405400b006ec57352e20mr5855043qko.321.1666193100906; Wed, 19 Oct 2022 08:25:00 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4o8VxbdpjmO0NbXs/tiuYsn9JLI2JqSqfOJlVnIS+gsHKHqRv9dMMyRkc1WnoR9LLRJgGB6g== X-Received: by 2002:a05:620a:4054:b0:6ec:5735:2e20 with SMTP id i20-20020a05620a405400b006ec57352e20mr5855025qko.321.1666193100589; Wed, 19 Oct 2022 08:25:00 -0700 (PDT) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id cb23-20020a05622a1f9700b0039cc22a2c49sm4201072qtb.47.2022.10.19.08.25.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 08:25:00 -0700 (PDT) To: gdb-patches@sourceware.org Subject: [PATCH 03/10] sim/ppc: initialize a memory buffer in all cases Date: Wed, 19 Oct 2022 16:24:42 +0100 Message-Id: <0bd7df35b8c709a72d6f2a0900e60fa12727779e.1666192979.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Burgess via Gdb-patches From: Andrew Burgess Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" In the ppc simulator's do_fstat function, which provides the fstat call for the simulator, if the fstat is going to fail then we current write an uninitialized buffer into the inferior. In theory, I think this is fine, we also write the error status into the simulated target, so, given that the fstat has failed, the target shouldn't be relying on the buffer contents. However, writing an uninitialized buffer means we might leak simulator private data into the simulated target, which is probably a bad thing. Plus it probably makes life easier if something consistent, like all zeros, is written rather than random junk, that might look like a successful call. So, in this commit, I clear the stat buffer to zero before writing it into the simulated target, if the fstat call is not run (due to a bad file descriptor). Another option would be to just not write the buffer into the inferior (rather than zeroing it, and writing all zeros). This would solve the problem of copying simulator data into the target, but I think the all zeros will make debugging things in the simulator easier. --- sim/ppc/emul_netbsd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sim/ppc/emul_netbsd.c b/sim/ppc/emul_netbsd.c index 322b584a3f1..f5fa8499bde 100644 --- a/sim/ppc/emul_netbsd.c +++ b/sim/ppc/emul_netbsd.c @@ -888,6 +888,8 @@ do_fstat(os_emul_data *emul, status = fdbad (fd); if (status == 0) status = fstat(fd, &buf); + else + memset (&buf, 0, sizeof (buf)); emul_write_status(processor, status, errno); write_stat(stat_buf_addr, buf, processor, cia); } From patchwork Wed Oct 19 15:24:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 59072 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B5F6538560A9 for ; Wed, 19 Oct 2022 15:28:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B5F6538560A9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666193292; bh=9UtDGilkQltRfWFRUUzhjVVD4XRvpTIpMci0RF7Sf+w=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=ZSigzM30MmjSoEInQNg4rz3sTtmwon2Z+jmVMdf9UGmU5fWijUJXrvAFsz2Pegyo7 R2Ot4T0rK2kGWdyMd0OjGhCPwTocIU38pYSK71ChpaIvJNYR++UBsK5xRAKCqIhzmr Fsm1VZnBha76L/Cgz5PnqZEskdrNdezV35n+HOMg= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 52E733850862 for ; Wed, 19 Oct 2022 15:25:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 52E733850862 Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-478-6rpgTgsoMDqLE1VfX43Gzw-1; Wed, 19 Oct 2022 11:25:03 -0400 X-MC-Unique: 6rpgTgsoMDqLE1VfX43Gzw-1 Received: by mail-qt1-f199.google.com with SMTP id d1-20020ac80601000000b00388b0fc84beso12996632qth.3 for ; Wed, 19 Oct 2022 08:25:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9UtDGilkQltRfWFRUUzhjVVD4XRvpTIpMci0RF7Sf+w=; b=nCNM9tTnN3HtrhJjxtyehhX6BJIhEValyVPHdeZv342bJ4CkWcekUK9H6zrPyKTZjd dCQuo+Fqaz67e8F3C7v8x3rQ9OwWgKesqulwE3rAqpPQwbkTJL/P+NSyAkrOaYj6Ps8X TzAxw6MnjzcKXuOsuy+GcWP8LIT37LtU6HiysYoS0AxaI4hq+3nFqjrL8yJFOlK2zLn/ yiS8d4JnN265W0ddvzx5t9l7OIuZpd62JJfetVJOvKHyt8bKnwRLbsCJF3AU+HJ/ipaq kAf7I8CgLHuwkAmJEjxFoeGuij9lfyVVodk+lFcswpKS4H84lieEpAbL7HbA4CdG23y6 79Vw== X-Gm-Message-State: ACrzQf3UWV4KWfU7mBrxp4QhcOnK//BljbEsr1eM3pFNHcmaU9SjqoKU /95vVAaVz45elsQYo/B6Gc+oKIGfIoSkJmFouHNyYe8vcCeQbVd/wKdxi8s6DSK1iSR3obaw/QJ KnxRcsbU57p3GBgEMyepNOj28r5fw+9KlnEJ4r+a4K3wDYQ62A9GtIhnYSseBXMqb0aG7DtiMyQ == X-Received: by 2002:a05:622a:206:b0:39c:f2cf:f9fa with SMTP id b6-20020a05622a020600b0039cf2cff9famr7031442qtx.669.1666193102783; Wed, 19 Oct 2022 08:25:02 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7T+z+q/RQdrchsWblUiJJLxIxbAerrhbo9EvI5Cny03pOfa9R+YklJW2ZC7vRODKrk0Y8tVg== X-Received: by 2002:a05:622a:206:b0:39c:f2cf:f9fa with SMTP id b6-20020a05622a020600b0039cf2cff9famr7031419qtx.669.1666193102503; Wed, 19 Oct 2022 08:25:02 -0700 (PDT) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id t12-20020ac8588c000000b0039cd4d87aacsm4314013qta.15.2022.10.19.08.25.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 08:25:02 -0700 (PDT) To: gdb-patches@sourceware.org Subject: [PATCH 04/10] sim/ppc: don't pass uninitialized value to semctl for GETVAL calls Date: Wed, 19 Oct 2022 16:24:43 +0100 Message-Id: <5155a6bb36800aa1a8bdb214f59f85f9d92b6989.1666192979.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Burgess via Gdb-patches From: Andrew Burgess Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" When calling semctl with an GETVAL action, the 'union semun' argument is unused. Rather than passing an uninitialized variable (as we currently do), just pass the integer 0. This silences some compiler warnings, and is just as correct (given the argument is ignored). To be honest, it might be the case that the argument is not needed at all, however, I'm a little nervous to make this change as the amount of testing I can do of this code is limited. Every example I found online for a semctl/GETVAL call did pass the final argument, so that's what I've continued to do. --- sim/ppc/hw_sem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sim/ppc/hw_sem.c b/sim/ppc/hw_sem.c index 937e2ad6f81..78e3dda9ae6 100644 --- a/sim/ppc/hw_sem.c +++ b/sim/ppc/hw_sem.c @@ -148,7 +148,7 @@ hw_sem_init_data(device *me) error("hw_sem_init_data() semget failed\n"); } - sem->count = semctl( sem->id, 0, GETVAL, help ); + sem->count = semctl( sem->id, 0, GETVAL, 0 ); if (sem->count == -1) error("hw_sem_init_data() semctl -- get value failed\n"); DTRACE(sem, ("semaphore OS value (%d)\n", sem->count) ); @@ -241,7 +241,7 @@ hw_sem_io_read_buffer(device *me, } /* assume target is big endian */ - u32 = H2T_4(semctl( sem->id, 0, GETVAL, help )); + u32 = H2T_4(semctl( sem->id, 0, GETVAL, 0 )); DTRACE(sem, ("semaphore OS value (%d)\n", u32) ); if (u32 == 0xffffffff) { From patchwork Wed Oct 19 15:24:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 59071 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 61AD93851153 for ; Wed, 19 Oct 2022 15:27:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 61AD93851153 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666193261; bh=aa8/YU7VD9BQDdmy6R5Vr5h3X9SPyflEAYbnSsDh0ZA=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=xsblqD7gOVF6O8ZS6Ufi0VVQbFjI3PL7OPBquAjoCniNjS/zlgFnAhimxoYwuDsik E1vHnB9LYwOXVFmm+oIo4L4GKIETJ4GGzBUwxtrxSDd/S2dyYuPkS4Ttbm40lLBS47 XGQzpbj9WyomQfVS3nIpWR7SgXyMkcNusD4VH6bs= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 1D5CE3852770 for ; Wed, 19 Oct 2022 15:25:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1D5CE3852770 Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-153-6QGd2Jj6OF6QRrhJ7tLr7g-1; Wed, 19 Oct 2022 11:25:05 -0400 X-MC-Unique: 6QGd2Jj6OF6QRrhJ7tLr7g-1 Received: by mail-qt1-f197.google.com with SMTP id cr15-20020a05622a428f00b0039cf1f8c94fso4606700qtb.5 for ; Wed, 19 Oct 2022 08:25:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aa8/YU7VD9BQDdmy6R5Vr5h3X9SPyflEAYbnSsDh0ZA=; b=1hzc2cIsv2roZi4pNtdB5yZSAq762vhZijh+zOB8l+5didbSvNvhuhB8fS83aze5K1 eps0QYXABwdF8C1fXTwKw/DQASpy5iWwbjmifFAl83p4Lkq1omGs6upCIsCmSkFDf9g3 XTk+jr/vdTQejhAE1R4GCIzBnEePjnEA08sxZzxgoYApod8HYMzFx+2fs4rMU0v4yxHT fRKsy99FDZv4E7vg0hcKk9niXkGAHmbvHbb9CZzeqg3DUYoC6lSBh0p4lNcwHLCoELzR U6bDns3uURYT27qqV+X2yzSlsaeJlufbpUV5yhCF2vXnzC3o3D0jzmKCsXRjDl6V6/Rp GBBg== X-Gm-Message-State: ACrzQf2z8A3wEY4kGmZIM7zJuQDPFjENw8q311eIncHzUvXDgQx66Bqu gLRs6Q85w+BvgMt46geHEyEeIsOF+LN9Rq4+U5GR0ayIzIzTDK9mdzM7y61+U2Cx+JBkGpRVvBv YYrkCuKdQyA+k2qVHwfeoH3RtiAa/Y4kqGptyPJQSuGJ17ZMUyyr0ciSoILCcSmMHPtpV7WMk/Q == X-Received: by 2002:a05:620a:4547:b0:6ee:dc16:d67a with SMTP id u7-20020a05620a454700b006eedc16d67amr5997915qkp.23.1666193105003; Wed, 19 Oct 2022 08:25:05 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4K0Uw4w/DW1P9mJKbyyRazXOPrUmn1Z3RxKgorSpu/yQ86zbZLTouK2/6WEOr6p92BEVteyg== X-Received: by 2002:a05:620a:4547:b0:6ee:dc16:d67a with SMTP id u7-20020a05620a454700b006eedc16d67amr5997884qkp.23.1666193104557; Wed, 19 Oct 2022 08:25:04 -0700 (PDT) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id fe5-20020a05622a4d4500b00342f8984348sm4194854qtb.87.2022.10.19.08.25.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 08:25:04 -0700 (PDT) To: gdb-patches@sourceware.org Subject: [PATCH 05/10] sim/ppc: fix for operator precedence warning from clang Date: Wed, 19 Oct 2022 16:24:44 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Burgess via Gdb-patches From: Andrew Burgess Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" In the ppc simulator, clang was warning about some code like this: busy_ptr->nr_writebacks = 1 + (PPC_ONE_BIT_SET_P(out_vmask)) ? 1 : 2; The warning was: operator '?:' has lower precedence than '+'; '+' will be evaluated first I suspect that this is not the original authors intention. PPC_ONE_BIT_SET_P is going to be 0 or 1, so if we evaluate the '+' first, the condition will always be non-zero, so true. The whole expression could then be simplified to just '1', which doesn't make much sense. I suspect the answer the author was expecting was either 2 or 3. Why they didn't just write: busy_ptr->nr_writebacks = (PPC_ONE_BIT_SET_P(out_vmask)) ? 2 : 3; I have no clue, however, to keep the structure of the code unchanged, I've updated things to: busy_ptr->nr_writebacks = 1 + ((PPC_ONE_BIT_SET_P(out_vmask)) ? 1 : 2); which silences the warning from clang, and is, I am guessing, what the original author intended. --- sim/ppc/altivec.igen | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sim/ppc/altivec.igen b/sim/ppc/altivec.igen index 63fe95a53d5..e7962027bd6 100644 --- a/sim/ppc/altivec.igen +++ b/sim/ppc/altivec.igen @@ -231,7 +231,7 @@ void::model-function::ppc_insn_vr_vscr:itable_index index, model_data *model_ptr busy_ptr->vscr_busy = 1; if (out_vmask) - busy_ptr->nr_writebacks = 1 + (PPC_ONE_BIT_SET_P(out_vmask)) ? 1 : 2; + busy_ptr->nr_writebacks = 1 + ((PPC_ONE_BIT_SET_P(out_vmask)) ? 1 : 2); if (WITH_TRACE && ppc_trace[trace_model]) model_trace_altivec_make_busy(model_ptr, vr_mask, 0); From patchwork Wed Oct 19 15:24:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 59073 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5E0CB385483A for ; Wed, 19 Oct 2022 15:28:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5E0CB385483A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666193323; bh=qr5DxL77hTFr3s/LyrXfwSe4CWgxQb8g774gZbBk1RI=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=xf8O0JYIpew6AjBaqIgrxjVU65nfGlRj2rec0306paDLJu+H1g4dNfCqfYc7wqsbu LFMv5g7mfvNNT6le6hz0qhPvKOa6xyvYV3hM9PB8JQqSsgIi6a9rdoLq/erawpBXdt aCYagdVmJkV84osHlsA/3/VZOe7HY9SVEFkBkLEc= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 00C7F385085F for ; Wed, 19 Oct 2022 15:25:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 00C7F385085F Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-599-BRJkI8twMS-yjPbmPNmkaA-1; Wed, 19 Oct 2022 11:25:07 -0400 X-MC-Unique: BRJkI8twMS-yjPbmPNmkaA-1 Received: by mail-qk1-f199.google.com with SMTP id h8-20020a05620a284800b006b5c98f09fbso15270054qkp.21 for ; Wed, 19 Oct 2022 08:25:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qr5DxL77hTFr3s/LyrXfwSe4CWgxQb8g774gZbBk1RI=; b=A9eHangc7AvoAD0M3AaAvTY4D5oi4QF3iIYNvfijzr5ZjsLd+oGiYCELNVdnMyKRFD wSvB/uKUu+rz8kI4TQ9o+VFqHfCY4LsGKHmNKUBgVXK2Yon3Ug9gNFTsUd77YX8kf1Dz LdWLpExjM6BGcIQouSugrS+2DGIjGgxIqpiTD5gh+5edugyp/vmWPQ6zkPyDO0mERQcs qyGt77s9i8iOtLWKcWstQ6RUQ2blP2t4gDt9TVPCPH9ZB46ORao/JOS9+TlAi5HTFSqP zPTGT8jPqpzjwlbExwVEKEEiOIbSiEGT+x3c3XrsuSBQhS4SGpt2tyFCvSonfhJpqHS5 OmTg== X-Gm-Message-State: ACrzQf1KHW/8U/yRKRgxtgrembfPUrOVjABVD3CQRxHt3ANBR+aOCrn4 DxHB+6GPT7RoexfHqh2cw2paMzPDRzAwpD/CRnxfh1CpRph23xPuHCx/06Fc9VtdnEnYU1nDqhU S7oyU6+oi5MtBRcQ3TFO/zzzGalbCiWRqyAVKSVUuef+TjNfL6+MXXCoDuU19GrkYQ9wJge9tTQ == X-Received: by 2002:a05:6214:19c5:b0:4b1:863b:805c with SMTP id j5-20020a05621419c500b004b1863b805cmr7039670qvc.20.1666193106738; Wed, 19 Oct 2022 08:25:06 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4Ohkfp3tTsG7rVWEjeKf+A7mw4SmgWO420ljxf82j9w/cgDG30XIPtOpkk2yqGipowYdvpoQ== X-Received: by 2002:a05:6214:19c5:b0:4b1:863b:805c with SMTP id j5-20020a05621419c500b004b1863b805cmr7039642qvc.20.1666193106484; Wed, 19 Oct 2022 08:25:06 -0700 (PDT) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id f7-20020a05620a280700b006dfa0891397sm5224983qkp.32.2022.10.19.08.25.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 08:25:06 -0700 (PDT) To: gdb-patches@sourceware.org Subject: [PATCH 06/10] sim/aarch64: remove two unused functions Date: Wed, 19 Oct 2022 16:24:45 +0100 Message-Id: <4e799e1e8eec565afacdf31e689d8f97ce71c498.1666192979.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Burgess via Gdb-patches From: Andrew Burgess Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" These functions are not used. Clang warns about the unused functions, which is then converted into an error by -Werror. Delete the unused functions. --- sim/aarch64/simulator.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/sim/aarch64/simulator.c b/sim/aarch64/simulator.c index 516a7830522..5881725cefd 100644 --- a/sim/aarch64/simulator.c +++ b/sim/aarch64/simulator.c @@ -83,22 +83,6 @@ } \ while (0) -/* Helper functions used by expandLogicalImmediate. */ - -/* for i = 1, ... N result = 1 other bits are zero */ -static inline uint64_t -ones (int N) -{ - return (N == 64 ? (uint64_t)-1UL : ((1UL << N) - 1)); -} - -/* result<0> to val */ -static inline uint64_t -pickbit (uint64_t val, int N) -{ - return pickbits64 (val, N, N); -} - static uint64_t expand_logical_immediate (uint32_t S, uint32_t R, uint32_t N) { From patchwork Wed Oct 19 15:24:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 59067 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 13804384BC00 for ; Wed, 19 Oct 2022 15:25:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 13804384BC00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666193154; bh=5XoqEC0yoA0hd1J0Gt2m2xl1pTEicLV3+0TyWo1Bu/M=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=n9/uqCOHe6Jmv/8M3qVeQicznznBUzKdB+w4SGXFoOKj55+WjBvdekwcdzeGNCOyw Bra3XPP6BlOxydcE728sUDS9ERaGRonPBIp+NamkI07P6nv2hhQ0bSCLU2kyIcw1iZ 5E7BJiUGGzC1dTIEONxvu0jSmLa7J2s4IPHrg+x4= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0D13A3854158 for ; Wed, 19 Oct 2022 15:25:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0D13A3854158 Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-635-DHJcCy9yNtiH6Fzt0GdP8w-1; Wed, 19 Oct 2022 11:25:09 -0400 X-MC-Unique: DHJcCy9yNtiH6Fzt0GdP8w-1 Received: by mail-qv1-f72.google.com with SMTP id y2-20020a0ce802000000b004b1ce1c4a70so10807689qvn.9 for ; Wed, 19 Oct 2022 08:25:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5XoqEC0yoA0hd1J0Gt2m2xl1pTEicLV3+0TyWo1Bu/M=; b=Fqmv7KNIBi7UBFAXHPA0yubphW5g8CGfgloe57199q2F5Z1whcSkvXJyjy/YbY60YA d1w10ZJAfwPd9fycYfFOl4+9CPapunLTAHkayhBfYmbQOBHoRQqI+SQD7NZfulxbqqX6 6iZsLulBg4S+aUzS+WtNTCQ0G/gE/Y1prQ3EVkLPBbENiwrbSYzmGKFC31FRrqLROBOa XYZioZhTv84Upk8i4b/VLXoJpd0wMBkZZbEbrLW1ZfqJ0BHaKbmAR7QRIMJhnZRuh626 /h8fm8FNqAZjLxIvLz9kpuxgmFE8isAmVZfcLjQjIMtKSy/CkjPFNMXh+P3tfBU6LuBN 6nBw== X-Gm-Message-State: ACrzQf0gvlg9FGniaI4YTRd5EYgCZXgWFFYDCdi7G/j+EbNt3fzTfEoW VJBnnGtssxiURBFvupz+1nVkeKDGealfOVcKjMHZwbuP2/gZYij0BYRy6SRZQ5WzIN/eQ5SKuoB sR6W1jVc1cFKOkYepXNwmDuEJ7+vqcCVyUy6EZaWjBfExkdpknPWIqw8zkv8A1OVI1/+P4z4XZQ == X-Received: by 2002:a05:6214:29e3:b0:4b3:f368:de31 with SMTP id jv3-20020a05621429e300b004b3f368de31mr7175954qvb.127.1666193108650; Wed, 19 Oct 2022 08:25:08 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6ZjZLicKXKFN27VOHNuFSN8ymjg1JU90Dta04+mJ344IN+FA70OaiUHobWTKmhbdxd5SaMmQ== X-Received: by 2002:a05:6214:29e3:b0:4b3:f368:de31 with SMTP id jv3-20020a05621429e300b004b3f368de31mr7175924qvb.127.1666193108328; Wed, 19 Oct 2022 08:25:08 -0700 (PDT) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id k11-20020a05620a414b00b006e99290e83fsm5236274qko.107.2022.10.19.08.25.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 08:25:08 -0700 (PDT) To: gdb-patches@sourceware.org Subject: [PATCH 07/10] sim/rx: delete an unused function Date: Wed, 19 Oct 2022 16:24:46 +0100 Message-Id: <822c1b483bf6f6739d61ee1fceff3e1afb073382.1666192979.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Burgess via Gdb-patches From: Andrew Burgess Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Delete a single unused function from the rx simulator. Clang warns about the function being unused, which is converted into an error by -Werror. --- sim/rx/rx.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/sim/rx/rx.c b/sim/rx/rx.c index 70b1b9729b7..7e812c16fd7 100644 --- a/sim/rx/rx.c +++ b/sim/rx/rx.c @@ -754,14 +754,6 @@ typedef union { float f; } FloatInt; -static inline int -float2int (float f) -{ - FloatInt fi; - fi.f = f; - return fi.i; -} - static inline float int2float (int i) { From patchwork Wed Oct 19 15:24:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 59069 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 451873853835 for ; Wed, 19 Oct 2022 15:26:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 451873853835 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666193203; bh=oO0hSlTLXnxt49LqH9/Iv2Mt5hC+V+dnsE31Nwx8vWk=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=DQx/FG27gRH21nJV9vdVmFzeusw9CjOxwlAWbmUufyw+2q/wgIVcaErO3lDnLjiVI mutNzCGid7/9wfJ5+qbz3tAj2xk+nVLhXIde0SA5JKd850Cw1j0WA1RFoajqHwGIcg bJ8V4TYnWqPWU69rauE92/SHJh61i1n4wyk/g93U= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C9EDE3850864 for ; Wed, 19 Oct 2022 15:25:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C9EDE3850864 Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-93-uwWY6YyiOmyGn1anVwWA9w-1; Wed, 19 Oct 2022 11:25:11 -0400 X-MC-Unique: uwWY6YyiOmyGn1anVwWA9w-1 Received: by mail-qk1-f199.google.com with SMTP id v1-20020a05620a440100b006eee30cb799so8335875qkp.23 for ; Wed, 19 Oct 2022 08:25:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oO0hSlTLXnxt49LqH9/Iv2Mt5hC+V+dnsE31Nwx8vWk=; b=Et1CGgNWJtnrxj/F3vurtY+XN58ztLS3q0ua/D9lucKQ6qHM3GDc4mDl+FxYl7C4pb 51WDo3gFX31s/c5Qe9YOKInEzZ0vkpMRyRp+mc23EWQUEPJ9hw26VlQ1cmNKhv2F/WVn eDRYfaqGQOGD1+Dp5myvhKPs6Nz70a6kYQhxcxuvT84m7HDCCeiXSyte1EMt8Tseyd+9 QPaAiOaW21AwAW5EPPdWPjAc7x2OyxzaBFstFPenDNXFIwdByNaeriINa65UmzdRNSbl ddd04pxq0pbjH3zKw7UWNl/mvT5oRSaAySs2D0EQk/dAAlUvSIq9Rv3fPCIQkv/jrXY8 p1DA== X-Gm-Message-State: ACrzQf3CgKuqQm1VKlc6HZx1gSQr6RFfBwTUeArTrbR+ccyeoBI19/nn 10D6QecrT4kOgwgeyMw824Yf0cbxMhsbOlogG40VfifzHE9QKVFNSzBdX2cCdZSU494jLprekrO Prb0x8lHK7Zlt5tSFV5ArvUYnu06yYBoKXqQgZL///a1RtcWbMbU5NXM9xonQgCpUx+qlAAkNFQ == X-Received: by 2002:a05:620a:158f:b0:6ee:93d5:e249 with SMTP id d15-20020a05620a158f00b006ee93d5e249mr5912439qkk.505.1666193110559; Wed, 19 Oct 2022 08:25:10 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5Tw5hBZLNbADHX/ithfqW0DrTBBtBjup0PXE5ed2/8oy78bQ6X/Gs8yFm4Fel8iLOZydHJZQ== X-Received: by 2002:a05:620a:158f:b0:6ee:93d5:e249 with SMTP id d15-20020a05620a158f00b006ee93d5e249mr5912424qkk.505.1666193110268; Wed, 19 Oct 2022 08:25:10 -0700 (PDT) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id o24-20020ac85558000000b0039bde72b14asm4104677qtr.92.2022.10.19.08.25.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 08:25:10 -0700 (PDT) To: gdb-patches@sourceware.org Subject: [PATCH 08/10] sim/h8300: avoid self assignment Date: Wed, 19 Oct 2022 16:24:47 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Burgess via Gdb-patches From: Andrew Burgess Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" There are two places in the h8300 simulator where we assign a variable to itself. Clang gives a warning for this, which is converted into an error by -Werror. Silence the warning by removing the self assignments. As these assignments were in a complex if/then/else tree, rather than try to adjust all the conditions, I've just replaced the self assignments with a comment and an empty statement. --- sim/h8300/compile.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sim/h8300/compile.c b/sim/h8300/compile.c index 9be7dd565a9..5f64b4752f0 100644 --- a/sim/h8300/compile.c +++ b/sim/h8300/compile.c @@ -4141,7 +4141,7 @@ step_once (SIM_DESC sd, SIM_CPU *cpu) res = GET_B_REG (code->src.reg); /* FIXME fetch? */ if (!c && (0 <= (res >> 4) && (res >> 4) <= 9) && !h && (0 <= (res & 0xf) && (res & 0xf) <= 9)) - res = res; /* Value added == 0. */ + /* Nothing. */; /* Value added == 0. */ else if (!c && (0 <= (res >> 4) && (res >> 4) <= 8) && !h && (10 <= (res & 0xf) && (res & 0xf) <= 15)) res = res + 0x6; /* Value added == 6. */ @@ -4174,7 +4174,7 @@ step_once (SIM_DESC sd, SIM_CPU *cpu) res = GET_B_REG (code->src.reg); /* FIXME fetch, fetch2... */ if (!c && (0 <= (res >> 4) && (res >> 4) <= 9) && !h && (0 <= (res & 0xf) && (res & 0xf) <= 9)) - res = res; /* Value added == 0. */ + /* Nothing. */; /* Value added == 0. */ else if (!c && (0 <= (res >> 4) && (res >> 4) <= 8) && h && (6 <= (res & 0xf) && (res & 0xf) <= 15)) res = res + 0xfa; /* Value added == 0xfa. */ From patchwork Wed Oct 19 15:24:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 59074 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5FB1E3857017 for ; Wed, 19 Oct 2022 15:29:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5FB1E3857017 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666193376; bh=6Q0OefYiPZ4ptKU+YgDrwjna7IrKDIU8cNHqwlBizMA=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=AoccFFWiCT/+lFUjV8AX73N/QI3r4bVKaUPo0/Lzux2fBCY+1odqbTm/HnlVGPTnt zniACh/0bE5aqM0hBQhZ83oNtc1occ7I1wAeJVJuWIFLSlTEtU5jwPh22x9mEvmNTe RPUwg/ke14bZj1IyTjcIWjYYTFl89h/P4IoiEaEI= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 96B23386075F for ; Wed, 19 Oct 2022 15:25:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 96B23386075F Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-558-aPH4T_zUN9-AVtTgFtYCgA-1; Wed, 19 Oct 2022 11:25:13 -0400 X-MC-Unique: aPH4T_zUN9-AVtTgFtYCgA-1 Received: by mail-qk1-f198.google.com with SMTP id f12-20020a05620a408c00b006ced53b80e5so15120168qko.17 for ; Wed, 19 Oct 2022 08:25:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6Q0OefYiPZ4ptKU+YgDrwjna7IrKDIU8cNHqwlBizMA=; b=VFTgeAkpf+8Fxbxdjg5vWH/RwxbLldqXQhl9dkFoHbgIWcapfuHJAevKp/UtgMh9Sw AQ7U4shdLkTpzTb3rxAqy4TJkVxZp0S2l8Nwe0XNs2aa4exdCo1fgbjsgR0oAiW7IAKz 7pdehwuvDaCRqlR17M3HSYe9yVR5Hxa6neozzYG7z4aPEkdzCyh0M1x3ST5mhTodLCJz m2WRrNr22kaJcumJJaEde1+h+rkrXs1ofevUZyd3IV4SsIMEruFK93KBDHOLyjKQfmTv DZW/m0bXALy9CrUybZapmj5KufI5G82USr7qp57yiqwpdWpchiEw70fr6f73frtOr5nO 9mHw== X-Gm-Message-State: ACrzQf2bMCImbCILDrCA2kc1Z9NYfetc1pH6fdU1WhPz0IJ4Z9cVA8JC aYBS2mTQHcAQFHf4kYMyvzmAcnHvX1L+m2JIkMYGcdIlHsO7Rvb0gW2IF5WXRb0wV0ZTLBNzIAE LOLasMpdivi+T45TkRtG0NEKPPE1Jwb5506JcaMfJGJYpOT9S5hYyF+GO9Y6TEY/QZ1XBy1Hrgw == X-Received: by 2002:a05:620a:158f:b0:6ee:93d5:e249 with SMTP id d15-20020a05620a158f00b006ee93d5e249mr5912572qkk.505.1666193112590; Wed, 19 Oct 2022 08:25:12 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7dE3BMDLyN5lRLK/O0twxxf/IK1slS43ddw0eLsyUD29+t+D/qnjjcm33UqDn4huzBJ9bQXQ== X-Received: by 2002:a05:620a:158f:b0:6ee:93d5:e249 with SMTP id d15-20020a05620a158f00b006ee93d5e249mr5912542qkk.505.1666193112253; Wed, 19 Oct 2022 08:25:12 -0700 (PDT) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id q26-20020a37f71a000000b006ed519554cfsm4823347qkj.61.2022.10.19.08.25.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 08:25:12 -0700 (PDT) To: gdb-patches@sourceware.org Subject: [PATCH 09/10] sim/lm32: fix some missing function declaration warnings Date: Wed, 19 Oct 2022 16:24:48 +0100 Message-Id: <4eed8f0ebf777a6c88317041690e53fcf1cfb975.1666192979.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Burgess via Gdb-patches From: Andrew Burgess Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" In the lm32 simulator, I was seeing some warnings about missing function declarations. The lm32 simulator has a weird header structure, in order to pull in the full cpu.h header we need to define WANT_CPU_LM32BF. This is done in some files, but not in others. Critically, it's not done in some files that then use functions declared in cpu.h In this commit I added the missing #define so that the full cpu.h can be included. After doing this there are still a few functions that are used undeclared, these functions appear to be missing any declarations at all, so I've added some to cpu.h. With this done all the warnings when compiling lm32 are resolved for both gcc and clang, so I've removed the SIM_WERROR_CFLAGS line from Makefile.in, this allows lm32 to build with -Werror. --- sim/lm32/Makefile.in | 3 --- sim/lm32/cpu.h | 11 +++++++++++ sim/lm32/dv-lm32cpu.c | 3 +++ sim/lm32/user.c | 3 +++ 4 files changed, 17 insertions(+), 3 deletions(-) diff --git a/sim/lm32/Makefile.in b/sim/lm32/Makefile.in index d827b711d45..db15bef47a7 100644 --- a/sim/lm32/Makefile.in +++ b/sim/lm32/Makefile.in @@ -24,9 +24,6 @@ SIM_EXTRA_DEPS = $(CGEN_INCLUDE_DEPS) $(srcdir)/../../opcodes/lm32-desc.h \ SIM_EXTRA_CLEAN = lm32-clean -# Some modules don't build cleanly yet. -dv-lm32cpu.o mloop.o sem.o traps.o user.o: SIM_WERROR_CFLAGS = - ## COMMON_POST_CONFIG_FRAG arch = lm32 diff --git a/sim/lm32/cpu.h b/sim/lm32/cpu.h index 05b98be8cf1..d025065f2ba 100644 --- a/sim/lm32/cpu.h +++ b/sim/lm32/cpu.h @@ -163,6 +163,17 @@ struct scache { struct argbuf argbuf; }; +/* From traps.c. */ +extern USI lm32bf_b_insn (SIM_CPU * current_cpu, USI r0, USI f_r0); +extern USI lm32bf_divu_insn (SIM_CPU * current_cpu, IADDR pc, USI r0, USI r1, USI r2); +extern USI lm32bf_modu_insn (SIM_CPU * current_cpu, IADDR pc, USI r0, USI r1, USI r2); +extern void lm32bf_wcsr_insn (SIM_CPU * current_cpu, USI f_csr, USI r1); +extern USI lm32bf_break_insn (SIM_CPU * current_cpu, IADDR pc); +extern USI lm32bf_scall_insn (SIM_CPU * current_cpu, IADDR pc); + +/* From user.c. */ +extern UINT lm32bf_user_insn (SIM_CPU * current_cpu, INT r0, INT r1, UINT imm); + /* Macros to simplify extraction, reading and semantic code. These define and assign the local vars that contain the insn's fields. */ diff --git a/sim/lm32/dv-lm32cpu.c b/sim/lm32/dv-lm32cpu.c index b97580e80a3..15a08eee815 100644 --- a/sim/lm32/dv-lm32cpu.c +++ b/sim/lm32/dv-lm32cpu.c @@ -18,6 +18,9 @@ You should have received a copy of the GNU General Public License along with this program. If not, see . */ +#define WANT_CPU lm32bf +#define WANT_CPU_LM32BF + /* This must come before any other includes. */ #include "defs.h" diff --git a/sim/lm32/user.c b/sim/lm32/user.c index 3cc21a208ee..d301d482c1b 100644 --- a/sim/lm32/user.c +++ b/sim/lm32/user.c @@ -21,6 +21,9 @@ /* This must come before any other includes. */ #include "defs.h" +#define WANT_CPU lm32bf +#define WANT_CPU_LM32BF + #include "sim-main.h" /* Handle user defined instructions. */ From patchwork Wed Oct 19 15:24:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 59075 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9E7373856DF1 for ; Wed, 19 Oct 2022 15:30:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9E7373856DF1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666193411; bh=xvQiIxZ5kLlechieVNtLr2rl5b3azTxbUDztKJalIbc=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=BKCRa28z5udy96iJcnjaoIi3sEAUbvU72+9VGfESN/vxc0vMWiFklmISjYGB3DdUg hF2fsyh8rjGHa4cQOHApi7NjzIOv8y0KzkFIO/pZmM0VcHt6mtr8VXWT90tIax9jRH msvwO4EYyREBFI3iodwaLAfLiy918PMjnCkFxR3w= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id DBE1D385086D for ; Wed, 19 Oct 2022 15:25:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DBE1D385086D Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-108-JdncMQQGOoSyH_0GFBIz4g-1; Wed, 19 Oct 2022 11:25:14 -0400 X-MC-Unique: JdncMQQGOoSyH_0GFBIz4g-1 Received: by mail-qv1-f72.google.com with SMTP id lu3-20020a0562145a0300b004b1d6f4130eso10768543qvb.1 for ; Wed, 19 Oct 2022 08:25:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xvQiIxZ5kLlechieVNtLr2rl5b3azTxbUDztKJalIbc=; b=ZDdN6kVyG0Xe2X7a9XQNG3oK3C3RUBON70K2Xh6zXVUEFlDnO+DLCP2Kl/XeIP21tO 6pB+5a7SueLC/p9rh0rJCz+7kafPulHVa6UPhqSPlwQwUdaHIFd8YYlWO6UQc8Sbo+tY 0smQnuEdwMD1e7DK069aFH1Qzo4o6VUw+U+JINLi8xEYD2q4SmtWCYhkJwtLzO5m8Qs+ V6f+Fw7Z8hA3MApr7ckOxpVvEY/HLXSX/N8qz7lu9PV+rFFda9D1MrCX1Nbg6+pqZ+h/ 2p/5sGPM8cAzh/fyzCZIUZ4qLSflAX9K0rOvKs0BBZ/r/yA31Luj5keUhL31xNAku1sa 272g== X-Gm-Message-State: ACrzQf2jbKm37HNhigcdgPkMmN0Hx8NGJkKIWRwkldz3YTsbXFzCzGkb vNhDxqeilxMVJdIi2JYw/oX3mMfxshjg0rP0hHKVCUfZBjh3uLzF33iyNz3m1PYU+BFd2wCPVSN IhqrLaWSHzFWhdSqOrX9mJ379ew7BAHd3zCGBz43dfMSwGCNUJNz6BM9Me/gO4GpetNpzE7nYGw == X-Received: by 2002:a05:622a:286:b0:39c:d621:610b with SMTP id z6-20020a05622a028600b0039cd621610bmr6771127qtw.608.1666193114429; Wed, 19 Oct 2022 08:25:14 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7bjo/l9Mos0cQx2oauMLHTz5Axi5hUlhrmrE/TVnJT1RdpleUSD/WV5OxJaWJoSufcmNR1zA== X-Received: by 2002:a05:622a:286:b0:39c:d621:610b with SMTP id z6-20020a05622a028600b0039cd621610bmr6771109qtw.608.1666193114154; Wed, 19 Oct 2022 08:25:14 -0700 (PDT) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id cm24-20020a05622a251800b0039492d503cdsm4267422qtb.51.2022.10.19.08.25.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 08:25:13 -0700 (PDT) To: gdb-patches@sourceware.org Subject: [PATCH 10/10] sim/cris/m32c/sh: disable use of -Werror Date: Wed, 19 Oct 2022 16:24:49 +0100 Message-Id: <42c09bcd56bb7bf0a84d58ffad71894f284b5401.1666192979.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Burgess via Gdb-patches From: Andrew Burgess Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" When building the cris, m32c, and sh simulators with Clang I am seeing build warnings from a few objects. These three simulators currently build with -Werror, and so these warnings cause the build to fail. When built with gcc I don't see any warnings from these targets, so the -Werror is fine. As the warnings are not new, in this commit, I propose that we disable the use of -Werror for these three simulators. With this done it is now possible to build the complete simulator tree using clang. --- sim/cris/Makefile.in | 3 +++ sim/m32c/Makefile.in | 3 +++ sim/sh/Makefile.in | 3 +++ 3 files changed, 9 insertions(+) diff --git a/sim/cris/Makefile.in b/sim/cris/Makefile.in index d58aeee9363..53e485dca02 100644 --- a/sim/cris/Makefile.in +++ b/sim/cris/Makefile.in @@ -41,6 +41,9 @@ SIM_EXTRA_DEPS = \ SIM_EXTRA_CLEAN = cris-clean +# Some modules don't build cleanly yet. +mloopv10f.o mloopv32f.o: SIM_WERROR_CFLAGS = + ## COMMON_POST_CONFIG_FRAG arch = cris diff --git a/sim/m32c/Makefile.in b/sim/m32c/Makefile.in index 2436eb940f4..dd9b3aaf175 100644 --- a/sim/m32c/Makefile.in +++ b/sim/m32c/Makefile.in @@ -40,4 +40,7 @@ SIM_OBJS = \ trace.o \ $(ENDLIST) +# Some modules don't build cleanly yet. +mem.o: SIM_WERROR_CFLAGS = + ## COMMON_POST_CONFIG_FRAG diff --git a/sim/sh/Makefile.in b/sim/sh/Makefile.in index fc794f30687..a496095e767 100644 --- a/sim/sh/Makefile.in +++ b/sim/sh/Makefile.in @@ -24,4 +24,7 @@ SIM_OBJS = \ SIM_EXTRA_LIBS = -lm SIM_EXTRA_DEPS = table.c code.c ppi.c +# Some modules don't build cleanly yet. +interp.o: SIM_WERROR_CFLAGS = + ## COMMON_POST_CONFIG_FRAG