diff mbox series

[pushed,6/8,gdb/testsuite] Fix gdb.tui/completion.exp for local-remote-host-notty

Message ID 20230313162051.488-7-tdevries@suse.de
State Committed
Headers
Series Fix remote host issues in TUI tests |

Commit Message

Tom de Vries March 13, 2023, 4:20 p.m. UTC 
  When running test-case gdb.tui/completion.exp with host board
local-remote-host-notty and target board native-gdbserver, I get:
...
FAIL: gdb.tui/completion.exp: completion of layout names: \
  tab completion (timeout)
...

The test-case contains a few tests that do tab completion, which requires
readline, which is unavailable with host board local-remote-host-notty.

Fix this by adding the missing check for readline_is_used.

Tested on x86_64-linux.
---
 gdb/testsuite/gdb.tui/completion.exp | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)
diff mbox series

Patch

diff --git a/gdb/testsuite/gdb.tui/completion.exp b/gdb/testsuite/gdb.tui/completion.exp
index 0a959b4ff8b..85abd4a958b 100644
--- a/gdb/testsuite/gdb.tui/completion.exp
+++ b/gdb/testsuite/gdb.tui/completion.exp
@@ -48,12 +48,15 @@  proc test_tab_completion {input_line expected_re} {
     }
 }
 
-with_test_prefix "completion of layout names" {
-    test_tab_completion "layout" "asm *next *prev *regs *split *src *"
-}
+if { [readline_is_used] } {
+    with_test_prefix "completion of layout names" {
+	test_tab_completion "layout" "asm *next *prev *regs *split *src *"
+    }
 
-with_test_prefix "completion of focus command" {
-    test_tab_completion "focus" "cmd *next *prev *src *"
+
+    with_test_prefix "completion of focus command" {
+	test_tab_completion "focus" "cmd *next *prev *src *"
+    }
 }
 
 # Now run some completion tests when TUI mode is enabled.