diff mbox series

[pushed,8/8,gdb/testsuite] Fix gdb.python/tui-window-factory.exp for remote host

Message ID 20230313162051.488-9-tdevries@suse.de
State Committed
Headers
Series Fix remote host issues in TUI tests |

Commit Message

Tom de Vries March 13, 2023, 4:20 p.m. UTC 
  When running gdb.python/tui-window.exp with host board
local-remote-host-notty and target board native-gdbserver, I get:
...
FAIL: gdb.python/tui-window-factory.exp: msg_2: \
  check test_window box (box check: ul corner is l, not +)
...

The problem is that the result of Term::prepare_for_tui is not checked.

Fix this by adding the missing check.

Tested on x86_64-linux.
---
 gdb/testsuite/gdb.python/tui-window-factory.exp | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/gdb/testsuite/gdb.python/tui-window-factory.exp b/gdb/testsuite/gdb.python/tui-window-factory.exp
index 3e898d01c7b..e3b403bdea0 100644
--- a/gdb/testsuite/gdb.python/tui-window-factory.exp
+++ b/gdb/testsuite/gdb.python/tui-window-factory.exp
@@ -32,7 +32,10 @@  set pyfile [gdb_remote_download host \
 		${srcdir}/${subdir}/${gdb_test_file_name}.py]
 
 Term::clean_restart 24 80
-Term::prepare_for_tui
+if { ![Term::prepare_for_tui] } {
+    unsupported "TUI not supported"
+    return
+}
 
 gdb_test "source ${pyfile}" "Python script imported" \
     "import python scripts"