diff mbox series

[v2,45/48] Make ~value private

Message ID	20230209-submit-value-fixups-2023-v2-45-b0b27fd97177@tromey.com
State	New
Headers	DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DA0F53858409 From: Tom Tromey <tom@tromey.com> Date: Fri, 10 Feb 2023 14:53:03 -0700 Subject: [PATCH v2 45/48] Make ~value private MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230209-submit-value-fixups-2023-v2-45-b0b27fd97177@tromey.com> References: <20230209-submit-value-fixups-2023-v2-0-b0b27fd97177@tromey.com> In-Reply-To: <20230209-submit-value-fixups-2023-v2-0-b0b27fd97177@tromey.com> To: gdb-patches@sourceware.org Cc: Simon Marchi <simon.marchi@efficios.com> Precedence: list Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org>
Series	Use methods for struct value \| [v2,00/48] Use methods for struct value [v2,01/48] Rename all fields of struct value [v2,02/48] Move ~value body out-of-line [v2,03/48] Move struct value to value.h [v2,04/48] Turn value_type into method [v2,05/48] Turn deprecated_set_value_type into a method [v2,06/48] Turn value_arch into method [v2,07/48] Turn value_bitsize into method [v2,08/48] Turn value_bitpos into method [v2,09/48] Turn value_parent into method [v2,10/48] Turn value_offset into method [v2,11/48] Turn deprecated_value_modifiable into method [v2,12/48] Turn value_enclosing_type into method [v2,13/48] Turn some value offset functions into method [v2,14/48] Turn value_lazy and set_value_lazy functions into methods [v2,15/48] Turn value_stack and set_value_stack functions into methods [v2,16/48] Turn value_computed_closure and value_computed_funcs functions into methods [v2,17/48] Convert value_lval_const and deprecated_lval_hack to methods [v2,18/48] Turn value_initialized and set_value_initialized functions into methods [v2,19/48] Turn value_address and set_value_address functions into methods [v2,20/48] Turn more deprecated_* functions into methods [v2,21/48] Turn allocate_value_lazy into a static "constructor" [v2,22/48] Turn allocate_value into a static "constructor" [v2,23/48] Turn allocate_computed_value into static "constructor" [v2,24/48] Turn allocate_optimized_out_value into static "constructor" [v2,25/48] Turn value_zero into static "constructor" [v2,26/48] Turn some value_contents functions into methods [v2,27/48] Turn value_fetch_lazy into a method [v2,28/48] Turn allocate_value_contents into a method [v2,29/48] Turn value_contents_eq into a method [v2,30/48] Turn value_bits_synthetic_pointer into a method [v2,31/48] Move value_ref_policy methods out-of-line [v2,32/48] Turn value_incref and value_decref into methods [v2,33/48] Turn remaining value_contents functions into methods [v2,34/48] Fully qualify calls to copy in value.c [v2,35/48] Turn value_copy into a method [v2,36/48] Turn many optimized-out value functions into methods [v2,37/48] Turn value_non_lval and value_force_lval into methods [v2,38/48] Turn set_value_component_location into method [v2,39/48] Change some code to use value methods [v2,40/48] Turn some xmethod functions into methods [v2,41/48] Turn preserve_one_value into method [v2,42/48] Turn various value copying-related functions into methods [v2,43/48] Add value::set_modifiable [v2,44/48] Make struct value data members private [v2,45/48] Make ~value private [v2,46/48] Introduce set_lval method on value [v2,47/48] Remove deprecated_lval_hack [v2,48/48] Rely on value_ref_ptr::operator->

Commit Message

Tom Tromey Feb. 10, 2023, 9:53 p.m. UTC

  At the end of this series, I belatedly realized that values should
only be destroyed by value_decref.  This patch marks the the
destructor private to enforce this.

Approved-By: Simon Marchi <simon.marchi@efficios.com>
---
 gdb/value.h | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff mbox series

Patch

diff --git a/gdb/value.h b/gdb/value.h
index cef027d9c4c..a78c8c22937 100644
--- a/gdb/value.h
+++ b/gdb/value.h
@@ -142,6 +142,12 @@  struct value
   {
   }
 
+  /* Values can only be destroyed via the reference-counting
+     mechanism.  */
+  ~value ();
+
+  DISABLE_COPY_AND_ASSIGN (value);
+
 public:
 
   /* Allocate a lazy value for type TYPE.  Its actual content is
@@ -169,10 +175,6 @@  struct value
      but it's a different block of storage.  */
   struct value *copy () const;
 
-  ~value ();
-
-  DISABLE_COPY_AND_ASSIGN (value);
-
   /* Type of the value.  */
   struct type *type () const
   { return m_type; }