diff mbox series

[v2,06/48] Turn value_arch into method

Message ID	20230209-submit-value-fixups-2023-v2-6-b0b27fd97177@tromey.com
State	New
Headers	DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B4B20385B52C From: Tom Tromey <tom@tromey.com> Date: Fri, 10 Feb 2023 14:52:24 -0700 Subject: [PATCH v2 06/48] Turn value_arch into method MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230209-submit-value-fixups-2023-v2-6-b0b27fd97177@tromey.com> References: <20230209-submit-value-fixups-2023-v2-0-b0b27fd97177@tromey.com> In-Reply-To: <20230209-submit-value-fixups-2023-v2-0-b0b27fd97177@tromey.com> To: gdb-patches@sourceware.org Cc: Simon Marchi <simon.marchi@efficios.com> Precedence: list Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org>
Series	Use methods for struct value \| [v2,00/48] Use methods for struct value [v2,01/48] Rename all fields of struct value [v2,02/48] Move ~value body out-of-line [v2,03/48] Move struct value to value.h [v2,04/48] Turn value_type into method [v2,05/48] Turn deprecated_set_value_type into a method [v2,06/48] Turn value_arch into method [v2,07/48] Turn value_bitsize into method [v2,08/48] Turn value_bitpos into method [v2,09/48] Turn value_parent into method [v2,10/48] Turn value_offset into method [v2,11/48] Turn deprecated_value_modifiable into method [v2,12/48] Turn value_enclosing_type into method [v2,13/48] Turn some value offset functions into method [v2,14/48] Turn value_lazy and set_value_lazy functions into methods [v2,15/48] Turn value_stack and set_value_stack functions into methods [v2,16/48] Turn value_computed_closure and value_computed_funcs functions into methods [v2,17/48] Convert value_lval_const and deprecated_lval_hack to methods [v2,18/48] Turn value_initialized and set_value_initialized functions into methods [v2,19/48] Turn value_address and set_value_address functions into methods [v2,20/48] Turn more deprecated_* functions into methods [v2,21/48] Turn allocate_value_lazy into a static "constructor" [v2,22/48] Turn allocate_value into a static "constructor" [v2,23/48] Turn allocate_computed_value into static "constructor" [v2,24/48] Turn allocate_optimized_out_value into static "constructor" [v2,25/48] Turn value_zero into static "constructor" [v2,26/48] Turn some value_contents functions into methods [v2,27/48] Turn value_fetch_lazy into a method [v2,28/48] Turn allocate_value_contents into a method [v2,29/48] Turn value_contents_eq into a method [v2,30/48] Turn value_bits_synthetic_pointer into a method [v2,31/48] Move value_ref_policy methods out-of-line [v2,32/48] Turn value_incref and value_decref into methods [v2,33/48] Turn remaining value_contents functions into methods [v2,34/48] Fully qualify calls to copy in value.c [v2,35/48] Turn value_copy into a method [v2,36/48] Turn many optimized-out value functions into methods [v2,37/48] Turn value_non_lval and value_force_lval into methods [v2,38/48] Turn set_value_component_location into method [v2,39/48] Change some code to use value methods [v2,40/48] Turn some xmethod functions into methods [v2,41/48] Turn preserve_one_value into method [v2,42/48] Turn various value copying-related functions into methods [v2,43/48] Add value::set_modifiable [v2,44/48] Make struct value data members private [v2,45/48] Make ~value private [v2,46/48] Introduce set_lval method on value [v2,47/48] Remove deprecated_lval_hack [v2,48/48] Rely on value_ref_ptr::operator->

Commit Message

Tom Tromey Feb. 10, 2023, 9:52 p.m. UTC

  This changes value_arch to be a method of value.  Much of this patch
was written by script.

Approved-By: Simon Marchi <simon.marchi@efficios.com>
---
 gdb/valops.c |  2 +-
 gdb/value.c  | 12 ++++++------
 gdb/value.h  |  7 +++----
 3 files changed, 10 insertions(+), 11 deletions(-)

diff mbox series

Patch

diff --git a/gdb/valops.c b/gdb/valops.c
index 1cac2496183..ae876b795d0 100644
--- a/gdb/valops.c
+++ b/gdb/valops.c
@@ -1045,7 +1045,7 @@  read_value_memory (struct value *val, LONGEST bit_offset,
 		   gdb_byte *buffer, size_t length)
 {
   ULONGEST xfered_total = 0;
-  struct gdbarch *arch = get_value_arch (val);
+  struct gdbarch *arch = val->arch ();
   int unit_size = gdbarch_addressable_memory_unit_size (arch);
   enum target_object object;
 
diff --git a/gdb/value.c b/gdb/value.c
index bde8f3da4d2..26fc592147b 100644
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -163,9 +163,9 @@  value::~value ()
 /* See value.h.  */
 
 struct gdbarch *
-get_value_arch (const struct value *value)
+value::arch () const
 {
-  return value->type ()->arch ();
+  return type ()->arch ();
 }
 
 int
@@ -944,7 +944,7 @@  set_value_parent (struct value *value, struct value *parent)
 gdb::array_view<gdb_byte>
 value_contents_raw (struct value *value)
 {
-  struct gdbarch *arch = get_value_arch (value);
+  struct gdbarch *arch = value->arch ();
   int unit_size = gdbarch_addressable_memory_unit_size (arch);
 
   allocate_value_contents (value);
@@ -1121,7 +1121,7 @@  value_contents_copy_raw (struct value *dst, LONGEST dst_offset,
 			 struct value *src, LONGEST src_offset, LONGEST length)
 {
   LONGEST src_bit_offset, dst_bit_offset, bit_length;
-  struct gdbarch *arch = get_value_arch (src);
+  struct gdbarch *arch = src->arch ();
   int unit_size = gdbarch_addressable_memory_unit_size (arch);
 
   /* A lazy DST would make that this copy operation useless, since as
@@ -2160,7 +2160,7 @@  set_internalvar_component (struct internalvar *var,
     {
     case INTERNALVAR_VALUE:
       addr = value_contents_writeable (var->u.value).data ();
-      arch = get_value_arch (var->u.value);
+      arch = var->u.value->arch ();
       unit_size = gdbarch_addressable_memory_unit_size (arch);
 
       if (bitsize)
@@ -2884,7 +2884,7 @@  value_primitive_field (struct value *arg1, LONGEST offset,
 {
   struct value *v;
   struct type *type;
-  struct gdbarch *arch = get_value_arch (arg1);
+  struct gdbarch *arch = arg1->arch ();
   int unit_size = gdbarch_addressable_memory_unit_size (arch);
 
   arg_type = check_typedef (arg_type);
diff --git a/gdb/value.h b/gdb/value.h
index cb92b872bc6..c455ce36ac1 100644
--- a/gdb/value.h
+++ b/gdb/value.h
@@ -169,6 +169,9 @@  struct value
   void deprecated_set_type (struct type *type)
   { m_type = type; }
 
+  /* Return the gdbarch associated with the value. */
+  struct gdbarch *arch () const;
+
 
   /* Type of value; either not an lval, or one of the various
      different possible kinds of lval.  */
@@ -336,10 +339,6 @@  struct value
   std::vector<range> m_optimized_out;
 };
 
-/* Return the gdbarch associated with the value. */
-
-extern struct gdbarch *get_value_arch (const struct value *value);
-
 /* Only used for bitfields; number of bits contained in them.  */
 
 extern LONGEST value_bitsize (const struct value *);