diff mbox

[PATCHv2,2/2] gdb: Make some test names unique

Message ID 20170713201511.GH27353@embecosm.com
State New
Headers show

Commit Message

Andrew Burgess July 13, 2017, 8:15 p.m. UTC
Thanks for the review and feedback.  I've taken on-board what you both
said, and I have a new patch which I think should be fine, in this I:

  - Add '(...text...)' at the end, but only _without_ a space before
    the '('.

  - I no longer use line numbers to make test names unique, instead I
    use more descriptive text.

  - I've not changed the names of any tests that were already unique,
    even if those names included a line number.

OK to apply?

Thanks,
Andrew

---

gdb: Make some test names unique

Make sure all of the tests have unique names in
gdb.mi/mi-vla-fortran.exp.

gdb/testsuite/ChangeLog:

	* gdb.mi/mi-vla-fortran.exp: Make test names unique.

Comments

Pedro Alves July 13, 2017, 10:40 p.m. UTC | #1
On 07/13/2017 09:15 PM, Andrew Burgess wrote:
> Thanks for the review and feedback.  I've taken on-board what you both
> said, and I have a new patch which I think should be fine, in this I:
> 
>   - Add '(...text...)' at the end, but only _without_ a space before
>     the '('.
> 
>   - I no longer use line numbers to make test names unique, instead I
>     use more descriptive text.
> 
>   - I've not changed the names of any tests that were already unique,
>     even if those names included a line number.
> 
> OK to apply?

OK.

Though I'd think avoiding ()s entirely in the cases that the
()s are not part of the expression would be less surprising,
like e.g.:

 -"evaluate filled vla(contents modified)"
 +"evaluate filled vla, contents modified"

OK with that change too.

Thanks,
Pedro Alves
diff mbox

Patch

diff --git a/gdb/testsuite/gdb.mi/mi-vla-fortran.exp b/gdb/testsuite/gdb.mi/mi-vla-fortran.exp
index c7f9bd49dab..313a00a165f 100644
--- a/gdb/testsuite/gdb.mi/mi-vla-fortran.exp
+++ b/gdb/testsuite/gdb.mi/mi-vla-fortran.exp
@@ -44,7 +44,7 @@  mi_run_cmd
 mi_expect_stop "breakpoint-hit" "vla" "" ".*vla.f90" "$bp_lineno" \
   { "" "disp=\"del\"" } "run to breakpoint at line $bp_lineno"
 mi_gdb_test "500-data-evaluate-expression vla1" \
-  "500\\^done,value=\"<not allocated>\"" "evaluate not allocated vla"
+  "500\\^done,value=\"<not allocated>\"" "evaluate not allocated vla(before allocation)"
 
 mi_create_varobj_checked vla1_not_allocated vla1 "<not allocated>" \
   "create local variable vla1_not_allocated"
@@ -95,7 +95,7 @@  mi_run_cmd
 mi_expect_stop "breakpoint-hit" "vla" "" ".*vla.f90" "$bp_lineno" \
   { "" "disp=\"del\"" } "run to breakpoint at line $bp_lineno"
 mi_gdb_test "520-data-evaluate-expression vla1" \
-  "520\\^done,value=\"\\(1, 1, 1, 1, 1\\)\"" "evaluate filled vla"
+  "520\\^done,value=\"\\(1, 1, 1, 1, 1\\)\"" "evaluate filled vla(filled all 1s)"
 
 
 set bp_lineno [gdb_get_line_number "vla1-modified"]
@@ -106,13 +106,13 @@  mi_run_cmd
 mi_expect_stop "breakpoint-hit" "vla" "" ".*vla.f90" "$bp_lineno" \
   { "" "disp=\"del\"" } "run to breakpoint at line $bp_lineno"
 mi_gdb_test "530-data-evaluate-expression vla1" \
-  "530\\^done,value=\"\\(1, 42, 1, 24, 1\\)\"" "evaluate filled vla"
+  "530\\^done,value=\"\\(1, 42, 1, 24, 1\\)\"" "evaluate filled vla(contents modified)"
 mi_gdb_test "540-data-evaluate-expression vla1(1)" \
-  "540\\^done,value=\"1\"" "evaluate filled vla"
+  "540\\^done,value=\"1\"" "evaluate filled vla(1)"
 mi_gdb_test "550-data-evaluate-expression vla1(2)" \
-  "550\\^done,value=\"42\"" "evaluate filled vla"
+  "550\\^done,value=\"42\"" "evaluate filled vla(2)"
 mi_gdb_test "560-data-evaluate-expression vla1(4)" \
-  "560\\^done,value=\"24\"" "evaluate filled vla"
+  "560\\^done,value=\"24\"" "evaluate filled vla(4)"
 
 
 set bp_lineno [gdb_get_line_number "vla1-deallocated"]
@@ -123,7 +123,7 @@  mi_run_cmd
 mi_expect_stop "breakpoint-hit" "vla" "" ".*vla.f90" "$bp_lineno" \
   { "" "disp=\"del\"" } "run to breakpoint at line $bp_lineno"
 mi_gdb_test "570-data-evaluate-expression vla1" \
-  "570\\^done,value=\"<not allocated>\"" "evaluate not allocated vla"
+  "570\\^done,value=\"<not allocated>\"" "evaluate not allocated vla(after deallocation)"
 
 
 set bp_lineno [gdb_get_line_number "pvla2-not-associated"]