From patchwork Thu Jul 13 20:15:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 21609 Received: (qmail 130765 invoked by alias); 13 Jul 2017 20:15:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 111980 invoked by uid 89); 13 Jul 2017 20:15:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=del X-HELO: mail-wr0-f182.google.com Received: from mail-wr0-f182.google.com (HELO mail-wr0-f182.google.com) (209.85.128.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Jul 2017 20:15:24 +0000 Received: by mail-wr0-f182.google.com with SMTP id r103so58303983wrb.0 for ; Thu, 13 Jul 2017 13:15:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QJrdlCUL9szWytHiBRi2iVwRiUqHABlDmfPpMD/s/w8=; b=SJ2Jn/bsRuejqMtQqtPlnNrHW2WxtEh7t61lLfpf3E52qnleaudQr0CkWmBmgktsTo MTjvR6HFLEm0+BJ0EXXwa0RWeXvDS5pN8oEJdgac8LR34YYyCNcA4GC6LGrTgSVDrh0h vxsfq3irClRqhrp3MawEWkQEMSWxTycPwCYndiGSxMr1huODT8M903lLEptajIuFrO+E uVpw0PKkuqxlddtx0eyROo5m9CPANsjadDhxBDLSQSCOJPKEOTV2ODSJirze5lEDv3IB iMJmjRPTJK9hsMVIPV4Vj5HRlhAws4qeOTLkDycBPqiIWmL+W69Z8ITxGaSUNz8dIKgH Og0A== X-Gm-Message-State: AIVw113vR8wcaCktdSJUPvHaJ3Kpq9SaTAXleV3EwFrbFQ6TTZwwjEJt dIoZHj5vE0+3lBQL6CA= X-Received: by 10.223.179.65 with SMTP id k1mr2910982wrd.5.1499976922026; Thu, 13 Jul 2017 13:15:22 -0700 (PDT) Received: from localhost (host86-150-45-83.range86-150.btcentralplus.com. [86.150.45.83]) by smtp.gmail.com with ESMTPSA id 31sm4778519wrd.20.2017.07.13.13.15.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jul 2017 13:15:20 -0700 (PDT) Date: Thu, 13 Jul 2017 21:15:11 +0100 From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Pedro Alves , Yao Qi Subject: [PATCHv2 2/2] gdb: Make some test names unique Message-ID: <20170713201511.GH27353@embecosm.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.6.1 (2016-04-27) X-IsSubscribed: yes Thanks for the review and feedback. I've taken on-board what you both said, and I have a new patch which I think should be fine, in this I: - Add '(...text...)' at the end, but only _without_ a space before the '('. - I no longer use line numbers to make test names unique, instead I use more descriptive text. - I've not changed the names of any tests that were already unique, even if those names included a line number. OK to apply? Thanks, Andrew --- gdb: Make some test names unique Make sure all of the tests have unique names in gdb.mi/mi-vla-fortran.exp. gdb/testsuite/ChangeLog: * gdb.mi/mi-vla-fortran.exp: Make test names unique. diff --git a/gdb/testsuite/gdb.mi/mi-vla-fortran.exp b/gdb/testsuite/gdb.mi/mi-vla-fortran.exp index c7f9bd49dab..313a00a165f 100644 --- a/gdb/testsuite/gdb.mi/mi-vla-fortran.exp +++ b/gdb/testsuite/gdb.mi/mi-vla-fortran.exp @@ -44,7 +44,7 @@ mi_run_cmd mi_expect_stop "breakpoint-hit" "vla" "" ".*vla.f90" "$bp_lineno" \ { "" "disp=\"del\"" } "run to breakpoint at line $bp_lineno" mi_gdb_test "500-data-evaluate-expression vla1" \ - "500\\^done,value=\"\"" "evaluate not allocated vla" + "500\\^done,value=\"\"" "evaluate not allocated vla(before allocation)" mi_create_varobj_checked vla1_not_allocated vla1 "" \ "create local variable vla1_not_allocated" @@ -95,7 +95,7 @@ mi_run_cmd mi_expect_stop "breakpoint-hit" "vla" "" ".*vla.f90" "$bp_lineno" \ { "" "disp=\"del\"" } "run to breakpoint at line $bp_lineno" mi_gdb_test "520-data-evaluate-expression vla1" \ - "520\\^done,value=\"\\(1, 1, 1, 1, 1\\)\"" "evaluate filled vla" + "520\\^done,value=\"\\(1, 1, 1, 1, 1\\)\"" "evaluate filled vla(filled all 1s)" set bp_lineno [gdb_get_line_number "vla1-modified"] @@ -106,13 +106,13 @@ mi_run_cmd mi_expect_stop "breakpoint-hit" "vla" "" ".*vla.f90" "$bp_lineno" \ { "" "disp=\"del\"" } "run to breakpoint at line $bp_lineno" mi_gdb_test "530-data-evaluate-expression vla1" \ - "530\\^done,value=\"\\(1, 42, 1, 24, 1\\)\"" "evaluate filled vla" + "530\\^done,value=\"\\(1, 42, 1, 24, 1\\)\"" "evaluate filled vla(contents modified)" mi_gdb_test "540-data-evaluate-expression vla1(1)" \ - "540\\^done,value=\"1\"" "evaluate filled vla" + "540\\^done,value=\"1\"" "evaluate filled vla(1)" mi_gdb_test "550-data-evaluate-expression vla1(2)" \ - "550\\^done,value=\"42\"" "evaluate filled vla" + "550\\^done,value=\"42\"" "evaluate filled vla(2)" mi_gdb_test "560-data-evaluate-expression vla1(4)" \ - "560\\^done,value=\"24\"" "evaluate filled vla" + "560\\^done,value=\"24\"" "evaluate filled vla(4)" set bp_lineno [gdb_get_line_number "vla1-deallocated"] @@ -123,7 +123,7 @@ mi_run_cmd mi_expect_stop "breakpoint-hit" "vla" "" ".*vla.f90" "$bp_lineno" \ { "" "disp=\"del\"" } "run to breakpoint at line $bp_lineno" mi_gdb_test "570-data-evaluate-expression vla1" \ - "570\\^done,value=\"\"" "evaluate not allocated vla" + "570\\^done,value=\"\"" "evaluate not allocated vla(after deallocation)" set bp_lineno [gdb_get_line_number "pvla2-not-associated"]