Copy file1.txt to remote host in dw2-filename.exp and dw2-anonymous-func.exp
Commit Message
Some gdb.dwarf2/*.exp tests copy file1.txt to host via gdb_remote_download
but dw2-filename.exp and dw2-anonymous-func.exp don't do that. Looks like
an oversight in this patch
https://sourceware.org/ml/gdb-patches/2013-08/msg00365.html
There are some fails in remote host testing.
FAIL: gdb.dwarf2/dw2-anonymous-func.exp: list file1.txt
FAIL: gdb.dwarf2/dw2-filename.exp: interpreter-exec mi -file-list-exec-source-files
FAIL: gdb.dwarf2/dw2-filename.exp: info sources
This patch is to invoke gdb_remote_download to copy file1.txt to host
and remove it at the end. This patch fixes these fails above.
gdb/testsuite:
2014-05-15 Yao Qi <yao@codesourcery.com>
* gdb.dwarf2/dw2-filename.exp: Copy file1.txt to host. Remove
file1.txt from host at the end.
* gdb.dwarf2/dw2-anonymous-func.exp: Likewise.
---
gdb/testsuite/gdb.dwarf2/dw2-anonymous-func.exp | 5 +++++
gdb/testsuite/gdb.dwarf2/dw2-filename.exp | 6 ++++++
2 files changed, 11 insertions(+)
Comments
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> 2014-05-15 Yao Qi <yao@codesourcery.com>
Yao> * gdb.dwarf2/dw2-filename.exp: Copy file1.txt to host. Remove
Yao> file1.txt from host at the end.
Yao> * gdb.dwarf2/dw2-anonymous-func.exp: Likewise.
This is ok. Thanks for finding and fixing this.
Tom
On 05/16/2014 01:19 AM, Tom Tromey wrote:
>>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
>
> Yao> 2014-05-15 Yao Qi <yao@codesourcery.com>
> Yao> * gdb.dwarf2/dw2-filename.exp: Copy file1.txt to host. Remove
> Yao> file1.txt from host at the end.
> Yao> * gdb.dwarf2/dw2-anonymous-func.exp: Likewise.
>
> This is ok. Thanks for finding and fixing this.
>
Patch is pushed in.
@@ -29,6 +29,11 @@ if {[prepare_for_testing_full $testfile.exp \
return -1
}
+set remote_dwarf_srcfile [gdb_remote_download host \
+ ${srcdir}/${subdir}/${dwarf_srcfile}]
+
# Force the debugger to create the file1.txt symtab, to make sure that
# the debugger does not crash doing so.
gdb_test "list file1.txt:1" "File 1 Line 1.*File 1 Line 8" "list file1.txt"
+
+remote_file host delete ${remote_dwarf_srcfile}
@@ -22,11 +22,15 @@ if {![dwarf2_support]} {
}
standard_testfile .S
+set dwarf_srcfile "file1.txt"
if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" object {nodebug}] != "" } {
return -1
}
+set remote_dwarf_srcfile [gdb_remote_download host \
+ ${srcdir}/${subdir}/${dwarf_srcfile}]
+
clean_restart ${testfile}
# Verify that -file-list-exec-source-files returns a list where
@@ -38,3 +42,5 @@ gdb_test "interpreter-exec mi -file-list-exec-source-files" \
# And `info sources' should return the fullname incl. the directories.
gdb_test "info sources" {[/\\]file1\.txt}
+
+remote_file host delete ${remote_dwarf_srcfile}