From patchwork Thu May 15 04:53:01 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 934 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx23.g.dreamhost.com (mx2.sub5.homie.mail.dreamhost.com [208.113.200.128]) by wilcox.dreamhost.com (Postfix) with ESMTP id A9FA336006F for ; Wed, 14 May 2014 21:56:07 -0700 (PDT) Received: by homiemail-mx23.g.dreamhost.com (Postfix, from userid 14314964) id 5EB8D6399AE42; Wed, 14 May 2014 21:56:07 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx23.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx23.g.dreamhost.com (Postfix) with ESMTPS id 34D806399AE47 for ; Wed, 14 May 2014 21:56:07 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:mime-version :content-type; q=dns; s=default; b=yRWqPLzSy8JmHTXWEb53FrkW9w+bS ZtpgH2eyHAdljM0jtzHIztyn5w/BnX7CTywxPGHShoWquNzovIxSQFbsWs6VYb0T peudwtxZN8lh9o93r3XLfqo0KjimrqkPy8vHRFh1gF5sjF/+/HWW+UUVHO3d59z2 sjnpf5eZyIPAPE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:mime-version :content-type; s=default; bh=6Qryop7zpSCvrfswGKMxcKQaPVc=; b=XNI uEfzaCzAGKps0UUDtCbSLft4L40cGBLkfq1ZsJyUalSnx/7UsY7lIr7bHyebNi45 Ick64KX0bjgg0BohGoJYCPFVf3TcpDo5k4B9arscF8PDwZe+Bo2ITuN7uxJ2oqAK 9zrx/ZrtuCY6vDpuWmABsW46zRrpEb/zQU+52vBc= Received: (qmail 2367 invoked by alias); 15 May 2014 04:56:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 2356 invoked by uid 89); 15 May 2014 04:56:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 May 2014 04:56:01 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1Wkni2-0004j1-CY from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Wed, 14 May 2014 21:55:58 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 14 May 2014 21:55:57 -0700 Received: from qiyao.dyndns.org.com (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Wed, 14 May 2014 21:55:56 -0700 From: Yao Qi To: Subject: [PATCH] Copy file1.txt to remote host in dw2-filename.exp and dw2-anonymous-func.exp Date: Thu, 15 May 2014 12:53:01 +0800 Message-ID: <1400129581-25570-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 X-IsSubscribed: yes X-DH-Original-To: gdb@patchwork.siddhesh.in Some gdb.dwarf2/*.exp tests copy file1.txt to host via gdb_remote_download but dw2-filename.exp and dw2-anonymous-func.exp don't do that. Looks like an oversight in this patch https://sourceware.org/ml/gdb-patches/2013-08/msg00365.html There are some fails in remote host testing. FAIL: gdb.dwarf2/dw2-anonymous-func.exp: list file1.txt FAIL: gdb.dwarf2/dw2-filename.exp: interpreter-exec mi -file-list-exec-source-files FAIL: gdb.dwarf2/dw2-filename.exp: info sources This patch is to invoke gdb_remote_download to copy file1.txt to host and remove it at the end. This patch fixes these fails above. gdb/testsuite: 2014-05-15 Yao Qi * gdb.dwarf2/dw2-filename.exp: Copy file1.txt to host. Remove file1.txt from host at the end. * gdb.dwarf2/dw2-anonymous-func.exp: Likewise. --- gdb/testsuite/gdb.dwarf2/dw2-anonymous-func.exp | 5 +++++ gdb/testsuite/gdb.dwarf2/dw2-filename.exp | 6 ++++++ 2 files changed, 11 insertions(+) diff --git a/gdb/testsuite/gdb.dwarf2/dw2-anonymous-func.exp b/gdb/testsuite/gdb.dwarf2/dw2-anonymous-func.exp index d363a19..029104b 100644 --- a/gdb/testsuite/gdb.dwarf2/dw2-anonymous-func.exp +++ b/gdb/testsuite/gdb.dwarf2/dw2-anonymous-func.exp @@ -29,6 +29,11 @@ if {[prepare_for_testing_full $testfile.exp \ return -1 } +set remote_dwarf_srcfile [gdb_remote_download host \ + ${srcdir}/${subdir}/${dwarf_srcfile}] + # Force the debugger to create the file1.txt symtab, to make sure that # the debugger does not crash doing so. gdb_test "list file1.txt:1" "File 1 Line 1.*File 1 Line 8" "list file1.txt" + +remote_file host delete ${remote_dwarf_srcfile} diff --git a/gdb/testsuite/gdb.dwarf2/dw2-filename.exp b/gdb/testsuite/gdb.dwarf2/dw2-filename.exp index 9575504..c9ead979 100644 --- a/gdb/testsuite/gdb.dwarf2/dw2-filename.exp +++ b/gdb/testsuite/gdb.dwarf2/dw2-filename.exp @@ -22,11 +22,15 @@ if {![dwarf2_support]} { } standard_testfile .S +set dwarf_srcfile "file1.txt" if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" object {nodebug}] != "" } { return -1 } +set remote_dwarf_srcfile [gdb_remote_download host \ + ${srcdir}/${subdir}/${dwarf_srcfile}] + clean_restart ${testfile} # Verify that -file-list-exec-source-files returns a list where @@ -38,3 +42,5 @@ gdb_test "interpreter-exec mi -file-list-exec-source-files" \ # And `info sources' should return the fullname incl. the directories. gdb_test "info sources" {[/\\]file1\.txt} + +remote_file host delete ${remote_dwarf_srcfile}