mbox series

[0/6] Use bool in value

Message ID 20230214-submit-more-value-stuff-v1-0-2fb85efbaa72@tromey.com
Headers
Series Use bool in value |

Message

Tom Tromey Feb. 14, 2023, 8:23 p.m. UTC 
  There are a few spots in struct value that should use 'bool'.  This
short series fixes these up.

Regression tested on x86-64 Fedora 36.

---
Tom Tromey (6):
      Change value::m_modifiable to bool
      Change value::m_lazy to bool
      Change value::m_initialized to bool
      Change value::m_stack to bool
      Have value::bits_synthetic_pointer return bool
      Return bool from more value methods

 gdb/breakpoint.c    |  3 +--
 gdb/dwarf2/expr.c   | 12 ++++-----
 gdb/dwarf2/expr.h   |  6 ++---
 gdb/dwarf2/loc.c    |  2 +-
 gdb/frame-unwind.c  |  2 +-
 gdb/gnu-v2-abi.c    |  2 +-
 gdb/opencl-lang.c   | 10 ++++----
 gdb/ppc-linux-nat.c |  2 +-
 gdb/valops.c        |  4 +--
 gdb/valprint.c      |  2 +-
 gdb/value.c         | 48 +++++++++++++++++------------------
 gdb/value.h         | 72 ++++++++++++++++++++++++++---------------------------
 12 files changed, 82 insertions(+), 83 deletions(-)
---
base-commit: 5bed9dc992a0136d403a7addb29a2ed822fd4fd2
change-id: 20230214-submit-more-value-stuff-dea23b091773

Best regards,

Comments

Guinevere Larsen Feb. 15, 2023, 12:22 p.m. UTC | #1 
On 14/02/2023 21:23, Tom Tromey wrote:
> There are a few spots in struct value that should use 'bool'.  This
> short series fixes these up.
>
> Regression tested on x86-64 Fedora 36.
>
> ---
> Tom Tromey (6):
>        Change value::m_modifiable to bool
>        Change value::m_lazy to bool
>        Change value::m_initialized to bool
>        Change value::m_stack to bool
>        Have value::bits_synthetic_pointer return bool
>        Return bool from more value methods
>
>   gdb/breakpoint.c    |  3 +--
>   gdb/dwarf2/expr.c   | 12 ++++-----
>   gdb/dwarf2/expr.h   |  6 ++---
>   gdb/dwarf2/loc.c    |  2 +-
>   gdb/frame-unwind.c  |  2 +-
>   gdb/gnu-v2-abi.c    |  2 +-
>   gdb/opencl-lang.c   | 10 ++++----
>   gdb/ppc-linux-nat.c |  2 +-
>   gdb/valops.c        |  4 +--
>   gdb/valprint.c      |  2 +-
>   gdb/value.c         | 48 +++++++++++++++++------------------
>   gdb/value.h         | 72 ++++++++++++++++++++++++++---------------------------
>   12 files changed, 82 insertions(+), 83 deletions(-)
> ---
> base-commit: 5bed9dc992a0136d403a7addb29a2ed822fd4fd2
> change-id: 20230214-submit-more-value-stuff-dea23b091773
>
> Best regards,

I've double checked the testing and changes, and apart from a comment on 
patch #2 everything looks ready to go. You may apply my tag to the whole 
series:

Reviewed-By: Bruno Larsen <blarsen@redhat.com>
Tom Tromey Feb. 15, 2023, 9:54 p.m. UTC | #2 
Bruno> I've double checked the testing and changes, and apart from a comment
Bruno> on patch #2 everything looks ready to go. You may apply my tag to the
Bruno> whole series:

Bruno> Reviewed-By: Bruno Larsen <blarsen@redhat.com>

Thanks.  I'm going to check this in.

Tom