Message ID | dae0f576-85fd-4955-5cec-256e08e43ae7@linux.ibm.com |
---|---|
State | New |
Headers |
Return-Path: <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 119213864830 for <patchwork@sourceware.org>; Mon, 8 Apr 2024 09:24:04 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id C76F2385841E for <gcc-patches@gcc.gnu.org>; Mon, 8 Apr 2024 09:23:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C76F2385841E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C76F2385841E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712568199; cv=none; b=sk3DfS2WvbFP/f9h6tpjFadZ7h66MvCq/emqK21VNLKqL/vDpAne4VfEmSxNk/h7pV3YWc0VRRTZ0gSRv4pJEoTK4lpJdFT4+5FzRusuDg1+tQQ3EZaufEN7KVFT27+qS1qjE4w6KnPByE4LG5ZFAcRqkDs4V0KorEaIbNFiZW4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712568199; c=relaxed/simple; bh=QGAojCdZleuQzB6+ICcBQs0LBSIOSU61Yh/Pq4FK7Xs=; h=DKIM-Signature:Message-ID:Date:MIME-Version:To:From:Subject; b=KeeMaKXrg4PZHetiK1rR7OkgugkZ2qYJug4RIh2Qk4EsGXgSIchgxvnKYfad+EOF4wlNRh5LxB9R6RkvTpJqVBIFhYl3wAlF+GrAA9D8ntH0wWkV5npW3jDwWKdM1KmMiaDTHLElxWFPgrI6AxPPfrp5a3qRD0QRxC8a6R0S1VM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353726.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43897NjL014903; Mon, 8 Apr 2024 09:23:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : to : cc : from : subject : content-type : content-transfer-encoding; s=pp1; bh=K15VTY8ZdbG3AIDFIuyKsCx3dGffqCkFSVukUQeiEPM=; b=BwB4BtIFcYy9JjGN3GsTcIYzz0uEpwx08ObfuZipy8utKs5zJDPKoGvlPZPs4sG1J0NV d7qm0a1YU9b8CSVNYKrGmRDPFCWSaj44SMvScBduLAorSHVWgi+7cRFuZmx2SNDBKl/5 IcoG2JvRUthtE90zukE+AMvhaeB7tux6UULrOJWPJmtlpawQkgAvvJE+QQnG07Qwc1eG XbPQvHKY8+6gww3TjTdN0XTk6YAMUd5T6WfyZdDvbjFw5/1AJphVtdonQ9rzxR/Ct4Dq K83vKuYbzUErYcK2X5rh863Y5C4BI3IxZ5eLZtyBrY39JjB3E6DQ4gPEZBDB5jj/HyKp Hw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xcdnsr1a4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 08 Apr 2024 09:23:14 +0000 Received: from m0353726.ppops.net (m0353726.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 4389NDsB011088; Mon, 8 Apr 2024 09:23:13 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xcdnsr19s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 08 Apr 2024 09:23:13 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 4388gYmr029889; Mon, 8 Apr 2024 09:23:12 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3xbj7ky5jj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 08 Apr 2024 09:23:12 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4389N8ms39190904 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 8 Apr 2024 09:23:10 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6599320049; Mon, 8 Apr 2024 09:23:08 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 876782004B; Mon, 8 Apr 2024 09:23:06 +0000 (GMT) Received: from [9.197.228.82] (unknown [9.197.228.82]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 8 Apr 2024 09:23:06 +0000 (GMT) Message-ID: <dae0f576-85fd-4955-5cec-256e08e43ae7@linux.ibm.com> Date: Mon, 8 Apr 2024 17:23:05 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Content-Language: en-US To: GCC Patches <gcc-patches@gcc.gnu.org> Cc: Richard Biener <richard.guenther@gmail.com>, j@lambda.is, Peter Bergner <bergner@linux.ibm.com>, Segher Boessenkool <segher@kernel.crashing.org> From: "Kewen.Lin" <linkw@linux.ibm.com> Subject: [PATCH] testsuite: Add profile_update_atomic check to gcov-20.c [PR114614] Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: iw6OwgSfZS0G6tTSd37WS9SOkqcuUdkD X-Proofpoint-ORIG-GUID: 6Q9uAYdcyFWSdpsHT9Tl7-IOOpJsVIEg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-08_07,2024-04-05_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 clxscore=1011 spamscore=0 impostorscore=0 suspectscore=0 phishscore=0 mlxlogscore=937 mlxscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404080072 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org |
Series |
testsuite: Add profile_update_atomic check to gcov-20.c [PR114614]
|
|
Checks
Context | Check | Description |
---|---|---|
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 | success | Testing passed |
linaro-tcwg-bot/tcwg_gcc_check--master-aarch64 | success | Testing passed |
linaro-tcwg-bot/tcwg_gcc_build--master-arm | success | Testing passed |
linaro-tcwg-bot/tcwg_gcc_check--master-arm | warning | Patch is already merged |
Commit Message
Kewen.Lin
April 8, 2024, 9:23 a.m. UTC
Hi, As PR114614 shows, the newly added test case gcov-20.c by commit r14-9789-g08a52331803f66 failed on targets which do not support atomic profile update, there would be a message like: warning: target does not support atomic profile update, single mode is selected Since the test case adopts -fprofile-update=atomic, it requires effective target check profile_update_atomic, this patch is to add the check accordingly. Tested well on x86_64-redhat-linux, powerpc64-linux-gnu P8/P9 and powerpc64le-linux-gnu P9/P10. Is it ok for trunk? BR, Kewen ----- PR testsuite/114614 gcc/testsuite/ChangeLog: * gcc.misc-tests/gcov-20.c: Add effective target check profile_update_atomic. --- gcc/testsuite/gcc.misc-tests/gcov-20.c | 1 + 1 file changed, 1 insertion(+) -- 2.43.0
Comments
On Mon, Apr 8, 2024 at 11:23 AM Kewen.Lin <linkw@linux.ibm.com> wrote: > > Hi, > > As PR114614 shows, the newly added test case gcov-20.c by > commit r14-9789-g08a52331803f66 failed on targets which do > not support atomic profile update, there would be a message > like: > > warning: target does not support atomic profile update, > single mode is selected > > Since the test case adopts -fprofile-update=atomic, it > requires effective target check profile_update_atomic, this > patch is to add the check accordingly. > > Tested well on x86_64-redhat-linux, powerpc64-linux-gnu P8/P9 > and powerpc64le-linux-gnu P9/P10. > > Is it ok for trunk? OK > BR, > Kewen > ----- > PR testsuite/114614 > > gcc/testsuite/ChangeLog: > > * gcc.misc-tests/gcov-20.c: Add effective target check > profile_update_atomic. > --- > gcc/testsuite/gcc.misc-tests/gcov-20.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/gcc/testsuite/gcc.misc-tests/gcov-20.c b/gcc/testsuite/gcc.misc-tests/gcov-20.c > index 215faffc980..ca8c12aad2b 100644 > --- a/gcc/testsuite/gcc.misc-tests/gcov-20.c > +++ b/gcc/testsuite/gcc.misc-tests/gcov-20.c > @@ -1,5 +1,6 @@ > /* { dg-options "-fcondition-coverage -ftest-coverage -fprofile-update=atomic" } */ > /* { dg-do run { target native } } */ > +/* { dg-require-effective-target profile_update_atomic } */ > > /* Some side effect to stop branches from being pruned */ > int x = 0; > -- > 2.43.0
on 2024/4/8 18:47, Richard Biener wrote: > On Mon, Apr 8, 2024 at 11:23 AM Kewen.Lin <linkw@linux.ibm.com> wrote: >> >> Hi, >> >> As PR114614 shows, the newly added test case gcov-20.c by >> commit r14-9789-g08a52331803f66 failed on targets which do >> not support atomic profile update, there would be a message >> like: >> >> warning: target does not support atomic profile update, >> single mode is selected >> >> Since the test case adopts -fprofile-update=atomic, it >> requires effective target check profile_update_atomic, this >> patch is to add the check accordingly. >> >> Tested well on x86_64-redhat-linux, powerpc64-linux-gnu P8/P9 >> and powerpc64le-linux-gnu P9/P10. >> >> Is it ok for trunk? > > OK Thanks, pushed as r14-9851. BR, Kewen > >> BR, >> Kewen >> ----- >> PR testsuite/114614 >> >> gcc/testsuite/ChangeLog: >> >> * gcc.misc-tests/gcov-20.c: Add effective target check >> profile_update_atomic. >> --- >> gcc/testsuite/gcc.misc-tests/gcov-20.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/gcc/testsuite/gcc.misc-tests/gcov-20.c b/gcc/testsuite/gcc.misc-tests/gcov-20.c >> index 215faffc980..ca8c12aad2b 100644 >> --- a/gcc/testsuite/gcc.misc-tests/gcov-20.c >> +++ b/gcc/testsuite/gcc.misc-tests/gcov-20.c >> @@ -1,5 +1,6 @@ >> /* { dg-options "-fcondition-coverage -ftest-coverage -fprofile-update=atomic" } */ >> /* { dg-do run { target native } } */ >> +/* { dg-require-effective-target profile_update_atomic } */ >> >> /* Some side effect to stop branches from being pruned */ >> int x = 0; >> -- >> 2.43.0
diff --git a/gcc/testsuite/gcc.misc-tests/gcov-20.c b/gcc/testsuite/gcc.misc-tests/gcov-20.c index 215faffc980..ca8c12aad2b 100644 --- a/gcc/testsuite/gcc.misc-tests/gcov-20.c +++ b/gcc/testsuite/gcc.misc-tests/gcov-20.c @@ -1,5 +1,6 @@ /* { dg-options "-fcondition-coverage -ftest-coverage -fprofile-update=atomic" } */ /* { dg-do run { target native } } */ +/* { dg-require-effective-target profile_update_atomic } */ /* Some side effect to stop branches from being pruned */ int x = 0;