Message ID | 20200208152758.29385-2-tom@tromey.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 69313 invoked by alias); 8 Feb 2020 15:28:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 69145 invoked by uid 89); 8 Feb 2020 15:28:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-20.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.53.25) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 08 Feb 2020 15:28:02 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 94907400C6455 for <gdb-patches@sourceware.org>; Sat, 8 Feb 2020 08:14:36 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 0S1YjXKrAAGTX0S1YjkPnB; Sat, 08 Feb 2020 09:28:00 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iSU8ebBxjy2Yp2/26tBm1e7WFgDeWiCv94UD7IlfUqU=; b=Ulym8YCTW+tYcCqAPI5ORpyJKH l1bUskILrkx+HT5b3aGiOo+ZFU1DTLzamqbLOidZYthBdIZr5veYqjeXdqtHDnkulVBEqeAlwsFX8 7W1sZgkrHFfcwXiDIwBNVIU99; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:38112 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from <tom@tromey.com>) id 1j0S1Y-001WwE-At; Sat, 08 Feb 2020 08:28:00 -0700 From: Tom Tromey <tom@tromey.com> To: gdb-patches@sourceware.org Cc: Tom Tromey <tom@tromey.com> Subject: [PATCH 1/8] Don't forward-declare struct objfile in frame.h Date: Sat, 8 Feb 2020 08:27:51 -0700 Message-Id: <20200208152758.29385-2-tom@tromey.com> In-Reply-To: <20200208152758.29385-1-tom@tromey.com> References: <20200208152758.29385-1-tom@tromey.com> |
Commit Message
Tom Tromey
Feb. 8, 2020, 3:27 p.m. UTC
dwarf2/frame.h forward-declares struct objfile, but there's no need for this. gdb/ChangeLog 2020-02-08 Tom Tromey <tom@tromey.com> * dwarf2/frame.h (struct objfile): Don't forward declare. Change-Id: I4d54d46ac9422eeb64dc5f0b934792e77a875aa5 --- gdb/ChangeLog | 4 ++++ gdb/dwarf2/frame.h | 1 - 2 files changed, 4 insertions(+), 1 deletion(-)
Comments
On 2020-02-08 10:27 a.m., Tom Tromey wrote: > dwarf2/frame.h forward-declares struct objfile, but there's no need > for this. > > gdb/ChangeLog > 2020-02-08 Tom Tromey <tom@tromey.com> > > * dwarf2/frame.h (struct objfile): Don't forward declare. > > Change-Id: I4d54d46ac9422eeb64dc5f0b934792e77a875aa5 > --- > gdb/ChangeLog | 4 ++++ > gdb/dwarf2/frame.h | 1 - > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/gdb/dwarf2/frame.h b/gdb/dwarf2/frame.h > index a0ec3615a45..dd7315c8515 100644 > --- a/gdb/dwarf2/frame.h > +++ b/gdb/dwarf2/frame.h > @@ -23,7 +23,6 @@ > #define DWARF2_FRAME_H 1 > > struct gdbarch; > -struct objfile; > struct frame_info; > struct dwarf2_per_cu_data; > struct agent_expr; > -- > 2.17.2 > I'd say "dwarf2/frame.h" in the subject, since there's also a frame.h in the gdb directory. But other than that, I think you could push patches like this one right away. Simon
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
Simon> I'd say "dwarf2/frame.h" in the subject, since there's also a frame.h in
Simon> the gdb directory.
Good idea, I did that.
Simon> But other than that, I think you could push patches like
Simon> this one right away.
Yeah, I will try to do that, since there's little point in anybody
having to review these.
Tom
diff --git a/gdb/dwarf2/frame.h b/gdb/dwarf2/frame.h index a0ec3615a45..dd7315c8515 100644 --- a/gdb/dwarf2/frame.h +++ b/gdb/dwarf2/frame.h @@ -23,7 +23,6 @@ #define DWARF2_FRAME_H 1 struct gdbarch; -struct objfile; struct frame_info; struct dwarf2_per_cu_data; struct agent_expr;