Message ID | 20191224122452.1668-1-ssbssa@yahoo.de |
---|---|
State | New, archived |
Headers |
Received: (qmail 130716 invoked by alias); 24 Dec 2019 12:25:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 130704 invoked by uid 89); 24 Dec 2019 12:25:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.0 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: sonic311-30.consmr.mail.ir2.yahoo.com Received: from sonic311-30.consmr.mail.ir2.yahoo.com (HELO sonic311-30.consmr.mail.ir2.yahoo.com) (77.238.176.162) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 24 Dec 2019 12:25:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1577190310; bh=3sNpEr6lqaDguPoXK9GgVVE/zCzzSND7VmqJibDy9xM=; h=From:To:Subject:Date:References:From:Subject; b=Dd0N1PbEIY4r42H8LP9f9XVU39ikg3PrUREAtu+Wv34NkdSDXTncxJ9JgdnIaUAR/vHra98bLJk+fNsXW8o46UrVljH1uOJVfdcvxxYRiqpPbemaPDezg8PYFk+RPteBD7ovwjikjBacT7sZIDUvTrsfKI2xHQS9gDb0CZ7uDKxI7UYo0Ats2FbrqYzulC75LP65X73GY2SoAhQJZF8Dz1dbj4eI8ylLK49+igG901zghAawDXH/7gatER8T/zNflhhovIXhreVV4Hd7cT6t3cVJcnNQd7Kb9GznRO9ic67AqA9JNagjPcPZ4dgAVgSsccbp3bgcVyzfJXWpg2Hh0g== Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ir2.yahoo.com with HTTP; Tue, 24 Dec 2019 12:25:10 +0000 Received: by smtp410.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID ef393b39daf56326d92bc0063080e006; Tue, 24 Dec 2019 12:25:08 +0000 (UTC) From: "Hannes Domani via gdb-patches" <gdb-patches@sourceware.org> Reply-To: Hannes Domani <ssbssa@yahoo.de> To: gdb-patches@sourceware.org Subject: [PATCH 1/3] pe_bfd_read_buildid memory leak Date: Tue, 24 Dec 2019 13:24:50 +0100 Message-Id: <20191224122452.1668-1-ssbssa@yahoo.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit References: <20191224122452.1668-1-ssbssa.ref@yahoo.de> Content-Length: 426 X-IsSubscribed: yes |
Commit Message
Terekhov, Mikhail via Gdb-patches
Dec. 24, 2019, 12:24 p.m. UTC
bfd/ChangeLog: 2019-12-24 Hannes Domani <ssbssa@yahoo.de> * peicode.h (pe_bfd_read_buildid): Free data. --- bfd/peicode.h | 2 ++ 1 file changed, 2 insertions(+)
Comments
* Hannes Domani via gdb-patches <gdb-patches@sourceware.org> [2019-12-24 13:24:50 +0100]: > bfd/ChangeLog: > > 2019-12-24 Hannes Domani <ssbssa@yahoo.de> > > * peicode.h (pe_bfd_read_buildid): Free data. > --- > bfd/peicode.h | 2 ++ > 1 file changed, 2 insertions(+) Patches for binutils-gdb/bfd/* should be posted to the binutils list (binutils@sourceware.org) for review. Thanks, Andrew > > diff --git a/bfd/peicode.h b/bfd/peicode.h > index e9d205a01a..00ccfa0a44 100644 > --- a/bfd/peicode.h > +++ b/bfd/peicode.h > @@ -1396,6 +1396,8 @@ pe_bfd_read_buildid (bfd *abfd) > break; > } > } > + > + free (data); > } > > static const bfd_target * > -- > 2.24.1 >
Am Mittwoch, 25. Dezember 2019, 14:47:11 MEZ hat Andrew Burgess <andrew.burgess@embecosm.com> Folgendes geschrieben: > * Hannes Domani via gdb-patches <gdb-patches@sourceware.org> [2019-12-24 13:24:50 +0100]: > > > bfd/ChangeLog: > > > > 2019-12-24 Hannes Domani <ssbssa@yahoo.de> > > > > * peicode.h (pe_bfd_read_buildid): Free data. > > --- > > bfd/peicode.h | 2 ++ > > 1 file changed, 2 insertions(+) > > Patches for binutils-gdb/bfd/* should be posted to the binutils list > (binutils@sourceware.org) for review. Done. But what about patches that change both bfd/* and gdb/*? Send to both mailing lists? > Thanks, > Andrew > > > > > > > diff --git a/bfd/peicode.h b/bfd/peicode.h > > index e9d205a01a..00ccfa0a44 100644 > > --- a/bfd/peicode.h > > +++ b/bfd/peicode.h > > @@ -1396,6 +1396,8 @@ pe_bfd_read_buildid (bfd *abfd) > > break; > > } > > } > > + > > + free (data); > > } > > > > static const bfd_target * > > -- > > 2.24.1 > >
* Hannes Domani via gdb-patches <gdb-patches@sourceware.org> [2019-12-25 14:13:59 +0000]: > Am Mittwoch, 25. Dezember 2019, 14:47:11 MEZ hat Andrew Burgess <andrew.burgess@embecosm.com> Folgendes geschrieben: > > > * Hannes Domani via gdb-patches <gdb-patches@sourceware.org> [2019-12-24 13:24:50 +0100]: > > > > > bfd/ChangeLog: > > > > > > 2019-12-24 Hannes Domani <ssbssa@yahoo.de> > > > > > > * peicode.h (pe_bfd_read_buildid): Free data. > > > --- > > > bfd/peicode.h | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > Patches for binutils-gdb/bfd/* should be posted to the binutils list > > (binutils@sourceware.org) for review. > > Done. > But what about patches that change both bfd/* and gdb/*? > Send to both mailing lists? Absolutely, if they really can't be split into two parts then just post to both lists. Thanks, Andrew > > > Thanks, > > Andrew > > > > > > > > > > > > diff --git a/bfd/peicode.h b/bfd/peicode.h > > > index e9d205a01a..00ccfa0a44 100644 > > > --- a/bfd/peicode.h > > > +++ b/bfd/peicode.h > > > @@ -1396,6 +1396,8 @@ pe_bfd_read_buildid (bfd *abfd) > > > break; > > > } > > > } > > > + > > > + free (data); > > > } > > > > > > static const bfd_target * > > > -- > > > 2.24.1 > > > >
diff --git a/bfd/peicode.h b/bfd/peicode.h index e9d205a01a..00ccfa0a44 100644 --- a/bfd/peicode.h +++ b/bfd/peicode.h @@ -1396,6 +1396,8 @@ pe_bfd_read_buildid (bfd *abfd) break; } } + + free (data); } static const bfd_target *