Match any kind of error after "cannot resolve name" on lib/gdbserver-support.exp:gdbserver_start
Commit Message
On commit:
commit 7f1f7e23939adc7d71036a17fc6081e3af7ca585
Author: Sergio Durigan Junior <sergiodj@redhat.com>
Date: Fri Jul 13 16:20:34 2018 -0400
Expect for another variant of error message when gdbserver cannot resolve hostname
I extended the regular expression being used to identify whether
gdbserver could not resolve a (host)name. This was needed because the
error message being printed had a different variation across some
systems. However, as it turns out, I've just noticed that the message
has yet another variation:
target remote tcp8:123:2353
tcp8:123:2353: cannot resolve name: System error
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
tcp8:123:2353: No such file or directory.
(gdb) FAIL: gdb.server/server-connect.exp: tcp8: connect to gdbserver using tcp8:123
which is causing FAILs on some systems (namely, Fedora-i686 on
BuildBot).
So instead of trying to predict everything that can be printed, I
decided to just match anything after the "cannot resolve name: " part.
This patch implements that.
Regression tested on the BuildBot.
gdb/testsuite/ChangeLog:
2018-07-30 Sergio Durigan Junior <sergiodj@redhat.com>
* lib/gdbserver-support.exp (gdbserver_start): Match any kind of
error after "cannot resolve name" string.
---
gdb/testsuite/ChangeLog | 5 +++++
gdb/testsuite/lib/gdbserver-support.exp | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
Comments
>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
Sergio> Regression tested on the BuildBot.
Sergio> gdb/testsuite/ChangeLog:
Sergio> 2018-07-30 Sergio Durigan Junior <sergiodj@redhat.com>
Sergio> * lib/gdbserver-support.exp (gdbserver_start): Match any kind of
Sergio> error after "cannot resolve name" string.
Thanks Sergio. This is ok.
Tom
On Monday, July 30 2018, Tom Tromey wrote:
>>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>
> Sergio> Regression tested on the BuildBot.
>
> Sergio> gdb/testsuite/ChangeLog:
> Sergio> 2018-07-30 Sergio Durigan Junior <sergiodj@redhat.com>
>
> Sergio> * lib/gdbserver-support.exp (gdbserver_start): Match any kind of
> Sergio> error after "cannot resolve name" string.
>
> Thanks Sergio. This is ok.
Thanks, Tom. Pushed:
fb66cde8a42a383b111f0f1f48eb9f6daf9d736c
@@ -1,3 +1,8 @@
+2018-07-30 Sergio Durigan Junior <sergiodj@redhat.com>
+
+ * lib/gdbserver-support.exp (gdbserver_start): Match any kind of
+ error after "cannot resolve name" string.
+
2018-07-28 Andrew Burgess <andrew.burgess@embecosm.com>
* gdb.trace/tspeed.exp: Only call gdb_load_shlib after gdb has
@@ -326,7 +326,7 @@ proc gdbserver_start { options arguments } {
continue
}
}
- -re ".*: cannot resolve name: \(No address associated with hostname|Name or service not known\)\r\n" {
+ -re ".*: cannot resolve name: .*\r\n" {
error "gdbserver cannot resolve name."
}
timeout {