[RFA/RFC] Clarify contents of NEWS entry re: Python "rbreak" (waa: "Re: [python][patch] Python rbreak")
Commit Message
> > > > [hi Eli -- not sure if the attached patch is obvious or not, so I will
> > > > wait for your approval, assuming Phil confirms. Thank you!]
> > >
> > > Are you asking about the NEWS entry or about the entire patch? If
> > > the latter, I don't think I saw it, and neither do I see it in the
> > > list archives. I think. What am I missing?
> >
> > Just asking whether you approve the patch I attached, or if you
> > have some comments.
>
> Ah, OK. But where was it posted? I don't seem to be able to find it,
> neither in my inbox nor in the list archives. How did I miss it?
I was posted ... in my head! Another example of the forgetting to
attach the patch classic. Sorry about that.
gdb/ChangeLog:
* NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
Python function, rather than a new command.
Thanks,
Comments
Hi Eli,
> I was posted ... in my head! Another example of the forgetting to
> attach the patch classic. Sorry about that.
>
> gdb/ChangeLog:
>
> * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
> Python function, rather than a new command.
I don't think this patch was reviewed; do you think the patch is OK?
Thank you!
> >From 1db141b40e47bd5fc19dc4ee2a4c6f9c4fe2881b Mon Sep 17 00:00:00 2001
> From: Joel Brobecker <brobecker@adacore.com>
> Date: Thu, 1 Feb 2018 13:41:52 +0400
> Subject: [PATCH] gdb/NEWS: Clarify the news entry for "rbreak" in GDB 8.1
>
> gdb/ChangeLog:
>
> * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
> Python function, rather than a new command.
> ---
> gdb/NEWS | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gdb/NEWS b/gdb/NEWS
> index 9cd38f3d91..1767cef920 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -125,9 +125,9 @@
> gdb.new_thread are emitted. See the manual for further
> description of these.
>
> - ** A new command, "rbreak" has been added to the Python API. This
> - command allows the setting of a large number of breakpoints via a
> - regex pattern in Python. See the manual for further details.
> + ** A new function, "gdb.rbreak" has been added to the Python API.
> + This function allows the setting of a large number of breakpoints
> + via a regex pattern in Python. See the manual for further details.
>
> ** Python breakpoints can now accept explicit locations. See the
> manual for a further description of this feature.
> --
> 2.11.0
>
> Date: Fri, 9 Feb 2018 08:30:05 +0400
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: pmuldoon@redhat.com, simon.marchi@polymtl.ca,
> gdb-patches@sourceware.org
>
> > gdb/ChangeLog:
> >
> > * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
> > Python function, rather than a new command.
>
> I don't think this patch was reviewed; do you think the patch is OK?
The documentation part LGTM, thanks.
> > > gdb/ChangeLog:
> > >
> > > * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
> > > Python function, rather than a new command.
> >
> > I don't think this patch was reviewed; do you think the patch is OK?
>
> The documentation part LGTM, thanks.
Thank you, Eli. Patch pushed to master and gdb-8.1-branch
(using GDB PR gdb/22824).
From 1db141b40e47bd5fc19dc4ee2a4c6f9c4fe2881b Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Thu, 1 Feb 2018 13:41:52 +0400
Subject: [PATCH] gdb/NEWS: Clarify the news entry for "rbreak" in GDB 8.1
gdb/ChangeLog:
* NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
Python function, rather than a new command.
---
gdb/NEWS | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
@@ -125,9 +125,9 @@
gdb.new_thread are emitted. See the manual for further
description of these.
- ** A new command, "rbreak" has been added to the Python API. This
- command allows the setting of a large number of breakpoints via a
- regex pattern in Python. See the manual for further details.
+ ** A new function, "gdb.rbreak" has been added to the Python API.
+ This function allows the setting of a large number of breakpoints
+ via a regex pattern in Python. See the manual for further details.
** Python breakpoints can now accept explicit locations. See the
manual for a further description of this feature.
--
2.11.0