Remove unused Linux libthread_db callbacks
Commit Message
gdb/proc-service.c includes several libthread_db callbacks that do not
exist in gdb/gdbserver/proc-service.c. Other than in proc_service.h,
there is no reference to any of these callbacks in any revision of
nptl_db or linuxthreads_db in glibc's git repo so it seems likely that
these functions have never been called. This commit removes them.
gdb/
2014-07-01 Gary Benson <gbenson@redhat.com>
* proc-service.c (ps_xfer_memory): Update comment.
(ps_pstop): Remove unused function.
(ps_pcontinue): Likewise.
(ps_lstop): Likewise.
(ps_lcontinue): Likewise.
(ps_lgetxregsize): Likewise.
(ps_lgetxregs): Likewise.
(ps_lsetxregs): Likewise.
(ps_plog): Likewise.
(ps_ptread): Likewise.
(ps_ptwrite): Likewise.
---
gdb/ChangeLog | 14 +++++++
gdb/proc-service.c | 104 +---------------------------------------------------
2 files changed, 15 insertions(+), 103 deletions(-)
Comments
>>>>> "Gary" == Gary Benson <gbenson@redhat.com> writes:
Gary> gdb/proc-service.c includes several libthread_db callbacks that do not
Gary> exist in gdb/gdbserver/proc-service.c. Other than in proc_service.h,
Gary> there is no reference to any of these callbacks in any revision of
Gary> nptl_db or linuxthreads_db in glibc's git repo so it seems likely that
Gary> these functions have never been called. This commit removes them.
Ok.
Tom
Tom Tromey wrote:
> >>>>> "Gary" == Gary Benson <gbenson@redhat.com> writes:
>
> >>>>> gdb/proc-service.c includes several libthread_db callbacks
> >>>>> that do not exist in gdb/gdbserver/proc-service.c. Other
> >>>>> than in proc_service.h, there is no reference to any of these
> >>>>> callbacks in any revision of nptl_db or linuxthreads_db in
> >>>>> glibc's git repo so it seems likely that these functions have
> >>>>> never been called. This commit removes them.
>
> Ok.
Pushed.
Cheers,
Gary
@@ -81,8 +81,7 @@ core_addr_to_ps_addr (CORE_ADDR addr)
else transfer them from the process. Returns PS_OK for success,
PS_ERR on failure.
- This is a helper function for ps_pdread, ps_pdwrite, ps_ptread and
- ps_ptwrite. */
+ This is a helper function for ps_pdread and ps_pdwrite. */
static ps_err_e
ps_xfer_memory (const struct ps_prochandle *ph, psaddr_t addr,
@@ -105,88 +104,6 @@ ps_xfer_memory (const struct ps_prochandle *ph, psaddr_t addr,
}
-/* Stop the target process PH. */
-
-ps_err_e
-ps_pstop (gdb_ps_prochandle_t ph)
-{
- /* The process is always stopped when under control of GDB. */
- return PS_OK;
-}
-
-/* Resume the target process PH. */
-
-ps_err_e
-ps_pcontinue (gdb_ps_prochandle_t ph)
-{
- /* Pretend we did successfully continue the process. GDB will take
- care of it later on. */
- return PS_OK;
-}
-
-/* Stop the lightweight process LWPID within the target process PH. */
-
-ps_err_e
-ps_lstop (gdb_ps_prochandle_t ph, lwpid_t lwpid)
-{
- /* All lightweight processes are stopped when under control of GDB. */
- return PS_OK;
-}
-
-/* Resume the lightweight process (LWP) LWPID within the target
- process PH. */
-
-ps_err_e
-ps_lcontinue (gdb_ps_prochandle_t ph, lwpid_t lwpid)
-{
- /* Pretend we did successfully continue LWPID. GDB will take care
- of it later on. */
- return PS_OK;
-}
-
-/* Get the size of the architecture-dependent extra state registers
- for LWP LWPID within the target process PH and return it in
- *XREGSIZE. */
-
-ps_err_e
-ps_lgetxregsize (gdb_ps_prochandle_t ph, lwpid_t lwpid, int *xregsize)
-{
- /* FIXME: Not supported yet. */
- return PS_OK;
-}
-
-/* Get the extra state registers of LWP LWPID within the target
- process PH and store them in XREGSET. */
-
-ps_err_e
-ps_lgetxregs (gdb_ps_prochandle_t ph, lwpid_t lwpid, caddr_t xregset)
-{
- /* FIXME: Not supported yet. */
- return PS_OK;
-}
-
-/* Set the extra state registers of LWP LWPID within the target
- process PH from XREGSET. */
-
-ps_err_e
-ps_lsetxregs (gdb_ps_prochandle_t ph, lwpid_t lwpid, caddr_t xregset)
-{
- /* FIXME: Not supported yet. */
- return PS_OK;
-}
-
-/* Log (additional) diognostic information. */
-
-void
-ps_plog (const char *fmt, ...)
-{
- va_list args;
-
- va_start (args, fmt);
- vfprintf_filtered (gdb_stderr, fmt, args);
- va_end (args);
-}
-
/* Search for the symbol named NAME within the object named OBJ within
the target process PH. If the symbol is found the address of the
symbol is stored in SYM_ADDR. */
@@ -235,25 +152,6 @@ ps_pdwrite (gdb_ps_prochandle_t ph, psaddr_t addr,
return ps_xfer_memory (ph, addr, (gdb_byte *) buf, size, 1);
}
-/* Read SIZE bytes from the target process PH at address ADDR and copy
- them into BUF. */
-
-ps_err_e
-ps_ptread (gdb_ps_prochandle_t ph, psaddr_t addr,
- gdb_ps_read_buf_t buf, gdb_ps_size_t size)
-{
- return ps_xfer_memory (ph, addr, (gdb_byte *) buf, size, 0);
-}
-
-/* Write SIZE bytes from BUF into the target process PH at address ADDR. */
-
-ps_err_e
-ps_ptwrite (gdb_ps_prochandle_t ph, psaddr_t addr,
- gdb_ps_write_buf_t buf, gdb_ps_size_t size)
-{
- return ps_xfer_memory (ph, addr, (gdb_byte *) buf, size, 1);
-}
-
/* Get the general registers of LWP LWPID within the target process PH
and store them in GREGSET. */