[testsuite] i386 regression for funcargs.exp [Re: [PATCH 3/3] Remove HP-UX references fom testsuite]
Message ID | 20160108193033.GA2812@host1.jankratochvil.net |
---|---|
State | New, archived |
Headers |
Received: (qmail 51037 invoked by alias); 8 Jan 2016 19:30:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 51004 invoked by uid 89); 8 Jan 2016 19:30:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=funcargs.exp, UD:funcargs.exp, funcargsexp, HTo:D*ca X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 08 Jan 2016 19:30:40 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id C27E2C0A8468; Fri, 8 Jan 2016 19:30:38 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-116-99.ams2.redhat.com [10.36.116.99]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u08JUXbP013304 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 8 Jan 2016 14:30:37 -0500 Date: Fri, 8 Jan 2016 20:30:33 +0100 From: Jan Kratochvil <jan.kratochvil@redhat.com> To: Simon Marchi <simon.marchi@polymtl.ca> Cc: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org Subject: [testsuite patch] i386 regression for funcargs.exp [Re: [PATCH 3/3] Remove HP-UX references fom testsuite] Message-ID: <20160108193033.GA2812@host1.jankratochvil.net> References: <1450567845-27030-1-git-send-email-simon.marchi@polymtl.ca> <1450567845-27030-3-git-send-email-simon.marchi@polymtl.ca> <5677F519.2010000@redhat.com> <CAFXXi0nW5vE+ydzZcASbtgD6OxEGK2RcTGSuCJ4hPEeB2=h5_A@mail.gmail.com> <567831CD.2090406@redhat.com> <CAFXXi0nz4PUiOH5yNVeU_qYX4+giNEC11A1v3a4Nhe3CNeXqwg@mail.gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="EeQfGwPcQSOJBaQU" Content-Disposition: inline In-Reply-To: <CAFXXi0nz4PUiOH5yNVeU_qYX4+giNEC11A1v3a4Nhe3CNeXqwg@mail.gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes |
Commit Message
Jan Kratochvil
Jan. 8, 2016, 7:30 p.m. UTC
On Mon, 21 Dec 2015 18:52:59 +0100, Simon Marchi wrote:
> Ok, I pushed this one in. Thanks!
3ca22649a6dfeb71058c33be4d0542b98f1f0ff5 is the first bad commit
commit 3ca22649a6dfeb71058c33be4d0542b98f1f0ff5
Author: Simon Marchi <simon.marchi@polymtl.ca>
Date: Mon Dec 21 12:51:54 2015 -0500
Remove HP-UX references fom testsuite
### a/gdb/testsuite/gdb.base/funcargs.exp
### b/gdb/testsuite/gdb.base/funcargs.exp
@@ -1013,13 +1013,6 @@ proc localvars_in_indirect_call { } {
#
gdb_test_multiple "finish" "finish from indirectly called function" {
- -re "\\(\\*pointer_to_call0a\\) \\(c, s, i, l\\);.*First.*$gdb_prompt $" {
- #On hppa2.0w-hp-hpux11.00, gdb finishes at one line earlier than
- #hppa1.1-hp-hpux11.00. Therefore, an extra "step" is necessary
- #to continue the test.
- send_gdb "step\n"
- exp_continue
- }
-re ".*\\(\\*pointer_to_call0a\\) \\(c, s, i, l\\);.*Second.*$gdb_prompt $" {
pass "finish from indirectly called function"
}
->
finish^M
Run till exit from #0 call0a (c=97 'a', s=1, i=2, l=3) at ./gdb.base/funcargs.c:82^M
0x0804a189 in main () at ./gdb.base/funcargs.c:583^M
583 (*pointer_to_call0a) (c, s, i, l); /* First step into call0a. */^M
-(gdb) step^M
-584 (*pointer_to_call0a) (c, s, i, l); /* Second step into call0a. */^M
-(gdb) PASS: gdb.base/funcargs.exp: finish from indirectly called function
+(gdb) FAIL: gdb.base/funcargs.exp: finish from indirectly called function
step^M
-call0a (c=97 'a', s=1, i=2, l=3) at ./gdb.base/funcargs.c:82^M
-82 c = 'a';^M
-(gdb) PASS: gdb.base/funcargs.exp: stepping into indirectly called function
+584 (*pointer_to_call0a) (c, s, i, l); /* Second step into call0a. */^M
+(gdb) FAIL: gdb.base/funcargs.exp: stepping into indirectly called function
At least on x86_64 with testsuite in -m32 (expecting native i386 would be the
same).
OK for check-in?
Jan
gdb/testsuite/ChangeLog
2016-01-08 Jan Kratochvil <jan.kratochvil@redhat.com>
* gdb.base/funcargs.exp (finish from indirectly called function):
Reintroduce the case for 'First'.
Comments
On 16-01-08 02:30 PM, Jan Kratochvil wrote: > 3ca22649a6dfeb71058c33be4d0542b98f1f0ff5 is the first bad commit > commit 3ca22649a6dfeb71058c33be4d0542b98f1f0ff5 > Author: Simon Marchi <simon.marchi@polymtl.ca> > Date: Mon Dec 21 12:51:54 2015 -0500 > Remove HP-UX references fom testsuite > ### a/gdb/testsuite/gdb.base/funcargs.exp > ### b/gdb/testsuite/gdb.base/funcargs.exp > @@ -1013,13 +1013,6 @@ proc localvars_in_indirect_call { } { > # > > gdb_test_multiple "finish" "finish from indirectly called function" { > - -re "\\(\\*pointer_to_call0a\\) \\(c, s, i, l\\);.*First.*$gdb_prompt $" { > - #On hppa2.0w-hp-hpux11.00, gdb finishes at one line earlier than > - #hppa1.1-hp-hpux11.00. Therefore, an extra "step" is necessary > - #to continue the test. > - send_gdb "step\n" > - exp_continue > - } > -re ".*\\(\\*pointer_to_call0a\\) \\(c, s, i, l\\);.*Second.*$gdb_prompt $" { > pass "finish from indirectly called function" > } > > -> > > finish^M > Run till exit from #0 call0a (c=97 'a', s=1, i=2, l=3) at ./gdb.base/funcargs.c:82^M > 0x0804a189 in main () at ./gdb.base/funcargs.c:583^M > 583 (*pointer_to_call0a) (c, s, i, l); /* First step into call0a. */^M > -(gdb) step^M > -584 (*pointer_to_call0a) (c, s, i, l); /* Second step into call0a. */^M > -(gdb) PASS: gdb.base/funcargs.exp: finish from indirectly called function > +(gdb) FAIL: gdb.base/funcargs.exp: finish from indirectly called function > step^M > -call0a (c=97 'a', s=1, i=2, l=3) at ./gdb.base/funcargs.c:82^M > -82 c = 'a';^M > -(gdb) PASS: gdb.base/funcargs.exp: stepping into indirectly called function > +584 (*pointer_to_call0a) (c, s, i, l); /* Second step into call0a. */^M > +(gdb) FAIL: gdb.base/funcargs.exp: stepping into indirectly called function > > At least on x86_64 with testsuite in -m32 (expecting native i386 would be the > same). > > OK for check-in? > > > Jan I also don't see this on Ubuntu 14.04.3 LTS, gdb master, gcc 4.8.4. $ make check RUNTESTFLAGS="--target_board=unix/-m32 funcargs.exp" make[1]: Entering directory `/home/emaisin/build/binutils-gdb/gdb/testsuite' Nothing to be done for all... make check-single make[2]: Entering directory `/home/emaisin/build/binutils-gdb/gdb/testsuite' rootme=`pwd`; export rootme; srcdir=/home/emaisin/src/binutils-gdb/gdb/testsuite ; export srcdir ; EXPECT=`if [ "${READ1}" != "" ] ; then echo ${rootme}/expect-read1; elif [ -f ${rootme}/../../expect/expect ] ; then echo ${rootme}/../../expect/expect ; else echo expect ; fi` ; export EXPECT ; EXEEXT= ; export EXEEXT ; LD_LIBRARY_PATH=$rootme/../../expect:$rootme/../../libstdc++:$rootme/../../tk/unix:$rootme/../../tcl/unix:$rootme/../../bfd:$rootme/../../opcodes:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; if [ -f ${rootme}/../../expect/expect ] ; then TCL_LIBRARY=${srcdir}/../../tcl/library ; export TCL_LIBRARY ; fi ; runtest --target_board=unix/-m32 funcargs.exp WARNING: Couldn't find the global config file. Test Run By emaisin on Fri Jan 8 16:10:58 2016 Native configuration is x86_64-pc-linux-gnu === gdb tests === Schedule of variations: unix/-m32 Running target unix/-m32 Using /usr/local/share/dejagnu/baseboards/unix.exp as board description file for target. Using /usr/local/share/dejagnu/config/unix.exp as generic interface file for target. Using /home/emaisin/src/binutils-gdb/gdb/testsuite/config/unix.exp as tool-and-target-specific interface file. Running /home/emaisin/src/binutils-gdb/gdb/testsuite/gdb.base/funcargs.exp ... === gdb Summary === # of expected passes 141 /home/emaisin/build/binutils-gdb/gdb/testsuite/../../gdb/gdb version 7.10.50.20160108-git -nw -nx -data-directory /home/emaisin/build/binutils-gdb/gdb/testsuite/../data-directory make[2]: Leaving directory `/home/emaisin/build/binutils-gdb/gdb/testsuite' make[1]: Leaving directory `/home/emaisin/build/binutils-gdb/gdb/testsuite' $ ag "finish from indirectly called function" testsuite/gdb.sum 146:PASS: gdb.base/funcargs.exp: finish from indirectly called function But if there is a configuration where this is needed, then yes, it should be re-added.
diff --git a/gdb/testsuite/gdb.base/funcargs.exp b/gdb/testsuite/gdb.base/funcargs.exp index e5b6ced..a476169 100644 --- a/gdb/testsuite/gdb.base/funcargs.exp +++ b/gdb/testsuite/gdb.base/funcargs.exp @@ -1013,6 +1013,12 @@ proc localvars_in_indirect_call { } { # gdb_test_multiple "finish" "finish from indirectly called function" { + -re "\\(\\*pointer_to_call0a\\) \\(c, s, i, l\\);.*First.*$gdb_prompt $" { + # On i386, gdb finishes at one line earlier than on x86_64. + # Therefore, an extra "step" is necessary to continue the test. + send_gdb "step\n" + exp_continue + } -re ".*\\(\\*pointer_to_call0a\\) \\(c, s, i, l\\);.*Second.*$gdb_prompt $" { pass "finish from indirectly called function" }