Message ID | 20240404113858.854167-1-iii@linux.ibm.com |
---|---|
State | New |
Headers |
Return-Path: <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CA411385840C for <patchwork@sourceware.org>; Thu, 4 Apr 2024 11:39:41 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 368063858C98; Thu, 4 Apr 2024 11:39:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 368063858C98 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 368063858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712230750; cv=none; b=eY2wPDA/MlfqvTJ2eiZa/3Y1f6k+msaLt/kPpdPAzj5FoL2t92z9B5H0B3OIDzmdHmOkFv2/swPpR6d4iQyW9fHvUlh4//BvNWT1uRJmQw3w4qSFUQFlRXeVKo2HY9cEnvM7IE27e5ycalqXqHE4Q8djdHU+5BAUBWKSybk9Xxk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712230750; c=relaxed/simple; bh=N7E01XgCpkfArzejL88wdd8xAjO2c9BnD1pFYM6lPEY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=bYNHfq51GXYyts37fdFTYkRVklVD0tB+oquAry3DIy2+MIu7UGAoquhy0qIenTrafmlhj3zPCXXnm8AQQJkcqId+PUStSfafavjGlFLKMnkRS0sZZpAolPfGOjsA83qDRVWHS5tM2wBR8MHYJ9nApNHeaD9bv1dX6s6gIj6wlAw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 434BRClh023928; Thu, 4 Apr 2024 11:39:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=pp1; bh=98HmE7NyB/QJv4Xqhn7QGChrI1gRUCX7Pd7poOqAD64=; b=JMqGe8PZGJXWqoJupCVHTN4diKxLgVH+t4KoowiNu4F8W9nRoUr7M0+nXIBot3/W8leq xZCA/CnjpefYC435fPIfokjIIWdmxUlmTxU6ZfFIZqAUi1anLQgfwM+l/V1FcyUAlPWq s5+diZeFhfvl5iI7Y+0EzW/WfM0gu2N4UYXzRdy9OghniYYHncXxKif7VnXSWwyVcOF7 QGiEN06DVuf1gz37JfDQidvdcIeI6c1lucUULEEdkZk5BI+pMftxJH7FJBSSAjX5YiOe NiaeqKKrpxaAFKb2ju3tw/IEk/R7saP8Kj9mvgcqBuoQ65VLD3oTe9i2idOhWndqH7FU EQ== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3x9ube80hm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 04 Apr 2024 11:39:06 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 434AKLhi009115; Thu, 4 Apr 2024 11:39:05 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3x9epxuurd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 04 Apr 2024 11:39:05 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 434BcxDN46203292 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 4 Apr 2024 11:39:01 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 715392004D; Thu, 4 Apr 2024 11:38:59 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3B6802004B; Thu, 4 Apr 2024 11:38:59 +0000 (GMT) Received: from black.boeblingen.de.ibm.com (unknown [9.155.200.166]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 4 Apr 2024 11:38:59 +0000 (GMT) From: Ilya Leoshkevich <iii@linux.ibm.com> To: Andreas Krebbel <krebbel@gcc.gnu.org> Cc: gcc-patches@gcc.gnu.org, Stefan Schulze Frielinghaus <stefansf@linux.ibm.com>, Juergen Christ <jchrist@linux.ibm.com>, Ilya Leoshkevich <iii@linux.ibm.com> Subject: [PATCH] libsanitizer: Do not mention MSan and DFSan in an error message Date: Thu, 4 Apr 2024 13:38:29 +0200 Message-ID: <20240404113858.854167-1-iii@linux.ibm.com> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: l-tKQVg2K4biYaw3gSuMRz3VFQfGfnfG X-Proofpoint-GUID: l-tKQVg2K4biYaw3gSuMRz3VFQfGfnfG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-04_08,2024-04-04_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 impostorscore=0 adultscore=0 mlxlogscore=678 clxscore=1011 mlxscore=0 priorityscore=1501 malwarescore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404040079 X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org |
Series |
libsanitizer: Do not mention MSan and DFSan in an error message
|
|
Checks
Context | Check | Description |
---|---|---|
linaro-tcwg-bot/tcwg_gcc_build--master-arm | success | Testing passed |
linaro-tcwg-bot/tcwg_gcc_check--master-arm | success | Testing passed |
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 | success | Testing passed |
linaro-tcwg-bot/tcwg_gcc_check--master-aarch64 | success | Testing passed |
Commit Message
Ilya Leoshkevich
April 4, 2024, 11:38 a.m. UTC
Bootstrapped and regtested on s390x-redhat-linux. Ok for master? libsanitizer/ChangeLog: * sanitizer_common/sanitizer_linux_s390.cpp (AvoidCVE_2016_2143): Do not mention MSan and DFSan, which are not supported by GCC. --- libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 4/4/24 13:38, Ilya Leoshkevich wrote: > Bootstrapped and regtested on s390x-redhat-linux. Ok for master? > > > libsanitizer/ChangeLog: > > * sanitizer_common/sanitizer_linux_s390.cpp (AvoidCVE_2016_2143): > Do not mention MSan and DFSan, which are not supported by GCC. Ok, Thanks! Andreas > --- > libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp b/libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp > index 74db831b0aa..65ba825fa97 100644 > --- a/libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp > +++ b/libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp > @@ -212,7 +212,7 @@ void AvoidCVE_2016_2143() { > return; > Report( > "ERROR: Your kernel seems to be vulnerable to CVE-2016-2143. Using ASan,\n" > - "MSan, TSan, DFSan or LSan with such kernel can and will crash your\n" > + "TSan or LSan with such kernel can and will crash your\n" > "machine, or worse.\n" > "\n" > "If you are certain your kernel is not vulnerable (you have compiled it\n"
On Thu, Apr 04, 2024 at 02:19:08PM +0200, Andreas Krebbel wrote: > On 4/4/24 13:38, Ilya Leoshkevich wrote: > > Bootstrapped and regtested on s390x-redhat-linux. Ok for master? > > > > > > libsanitizer/ChangeLog: > > > > * sanitizer_common/sanitizer_linux_s390.cpp (AvoidCVE_2016_2143): > > Do not mention MSan and DFSan, which are not supported by GCC. > > Ok, Thanks! This then needs to be added to libsanitizer/LOCAL_PATCHES , otherwise it will disappear on the next merge from upstream. Though, I must say I'm not entirely convinced the change is worth the hassle on every libsanitizer merge. > > diff --git a/libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp b/libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp > > index 74db831b0aa..65ba825fa97 100644 > > --- a/libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp > > +++ b/libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp > > @@ -212,7 +212,7 @@ void AvoidCVE_2016_2143() { > > return; > > Report( > > "ERROR: Your kernel seems to be vulnerable to CVE-2016-2143. Using ASan,\n" > > - "MSan, TSan, DFSan or LSan with such kernel can and will crash your\n" > > + "TSan or LSan with such kernel can and will crash your\n" > > "machine, or worse.\n" > > "\n" > > "If you are certain your kernel is not vulnerable (you have compiled it\n" Jakub
On 4/4/24 14:22, Jakub Jelinek wrote: > On Thu, Apr 04, 2024 at 02:19:08PM +0200, Andreas Krebbel wrote: >> On 4/4/24 13:38, Ilya Leoshkevich wrote: >>> Bootstrapped and regtested on s390x-redhat-linux. Ok for master? >>> >>> >>> libsanitizer/ChangeLog: >>> >>> * sanitizer_common/sanitizer_linux_s390.cpp (AvoidCVE_2016_2143): >>> Do not mention MSan and DFSan, which are not supported by GCC. >> >> Ok, Thanks! > > This then needs to be added to libsanitizer/LOCAL_PATCHES , otherwise > it will disappear on the next merge from upstream. > > Though, I must say I'm not entirely convinced the change is worth the > hassle on every libsanitizer merge. You are right. We will leave the message as is. Thanks! Andreas > >>> diff --git a/libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp b/libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp >>> index 74db831b0aa..65ba825fa97 100644 >>> --- a/libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp >>> +++ b/libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp >>> @@ -212,7 +212,7 @@ void AvoidCVE_2016_2143() { >>> return; >>> Report( >>> "ERROR: Your kernel seems to be vulnerable to CVE-2016-2143. Using ASan,\n" >>> - "MSan, TSan, DFSan or LSan with such kernel can and will crash your\n" >>> + "TSan or LSan with such kernel can and will crash your\n" >>> "machine, or worse.\n" >>> "\n" >>> "If you are certain your kernel is not vulnerable (you have compiled it\n" > > Jakub >
diff --git a/libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp b/libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp index 74db831b0aa..65ba825fa97 100644 --- a/libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp +++ b/libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp @@ -212,7 +212,7 @@ void AvoidCVE_2016_2143() { return; Report( "ERROR: Your kernel seems to be vulnerable to CVE-2016-2143. Using ASan,\n" - "MSan, TSan, DFSan or LSan with such kernel can and will crash your\n" + "TSan or LSan with such kernel can and will crash your\n" "machine, or worse.\n" "\n" "If you are certain your kernel is not vulnerable (you have compiled it\n"