Update comments to target_can_use_hardware_watchpoint
Commit Message
From: Yao Qi <yao.qi@linaro.org>
The return value of target_can_use_hardware_watchpoint isn't well
documented, so this patch is to update the comments to reflect the
fact. This patch also removes a trailing ";" which is picked up
from Pedro's patch https://sourceware.org/ml/gdb-patches/2015-04/msg00527.html
gdb:
2015-04-17 Yao Qi <yao.qi@linaro.org>
Pedro Alves <palves@redhat.com>
* target.h (target_can_use_hardware_watchpoint): Update comments.
Remove trailing ";".
---
gdb/target.h | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
Comments
On 04/17/2015 10:37 AM, Yao Qi wrote:
> From: Yao Qi <yao.qi@linaro.org>
>
> The return value of target_can_use_hardware_watchpoint isn't well
> documented, so this patch is to update the comments to reflect the
> fact. This patch also removes a trailing ";" which is picked up
> from Pedro's patch https://sourceware.org/ml/gdb-patches/2015-04/msg00527.html
>
Thanks for doing this. Looks fine to me.
Thanks,
Pedro Alves
Pedro Alves <palves@redhat.com> writes:
> Thanks for doing this. Looks fine to me.
Patch is pushed in.
@@ -1807,14 +1807,17 @@ extern char *target_thread_name (struct thread_info *);
/* If the *_hw_beakpoint functions have not been defined
elsewhere use the definitions in the target vector. */
-/* Returns non-zero if we can set a hardware watchpoint of type TYPE. TYPE is
- one of bp_hardware_watchpoint, bp_read_watchpoint, bp_write_watchpoint, or
- bp_hardware_breakpoint. CNT is the number of such watchpoints used so far
- (including this one?). OTHERTYPE is who knows what... */
+/* Returns positive if we can set a hardware watchpoint of type TYPE.
+ Returns negative if the target doesn't have enough hardware debug
+ registers available. Return zero if hardware watchpoint of type
+ TYPE isn't supported. TYPE is one of bp_hardware_watchpoint,
+ bp_read_watchpoint, bp_write_watchpoint, or bp_hardware_breakpoint.
+ CNT is the number of such watchpoints used so far, including this
+ one. OTHERTYPE is who knows what... */
#define target_can_use_hardware_watchpoint(TYPE,CNT,OTHERTYPE) \
(*current_target.to_can_use_hw_breakpoint) (¤t_target, \
- TYPE, CNT, OTHERTYPE);
+ TYPE, CNT, OTHERTYPE)
/* Returns the number of debug registers needed to watch the given
memory region, or zero if the requested memory region is not