Message ID | 85bf6edd-748e-492f-a511-3bdb53edf49a@arm.com |
---|---|
State | Committed |
Commit | 8bc06e8302116267c47c640b03c5eceef9da15ca |
Headers |
Return-Path: <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 176F0385AC2E for <patchwork@sourceware.org>; Fri, 1 Dec 2023 11:29:31 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2080.outbound.protection.outlook.com [40.107.7.80]) by sourceware.org (Postfix) with ESMTPS id 6A4723858404 for <gcc-patches@gcc.gnu.org>; Fri, 1 Dec 2023 11:29:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6A4723858404 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6A4723858404 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.7.80 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1701430154; cv=pass; b=O7dNpPrgt6Rn9HZevBJWc9CLBel4QTmOU9IoQ60bBjinVi8O8J+WgQIZlOvyrK2HVUUgCvB9E1hZhjeR+MWRA1BNHfH80TVxXCzxGigsxEXQGCgvHHiOjl5adC/KKpdAIjZl15HvtawPSdWhFTFgJm8Ijs+zU4YvXRZ+PkJwf3U= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1701430154; c=relaxed/simple; bh=SLi6KQdKqAoXi7hLDOa/HpyWm6iENuf25vjnSopexAQ=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:To:From:Subject: MIME-Version; b=EweS0SQbaniw7szIwnkWm/ajbvit4BkPQ1i31DFTRAWw4q96AS7R5K/F/fqmHx/qOv6ALE1t/oARv8mNG/sGgDUQyh61SJSdolIFaZSJShVmsX2aEVLhmNRVzypxrDqUCiel5hmC4V/l7LkN6I30XKjgPx2J/k13NbqT9rjxt5U= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=BLEdWGhlRt9JIY2/RCJKZhDXcjy3S2L16/4WzhyGFA6srTac6wp2o0VX19XvSbUe2Fb3r0qUvTmA8HxXgcCujdAFcoCzpI+jZN9+hJFitYWoaJhAIMmINimlQUO0kf/5f6e/gcf2DZZRv9hHp+2TrkSKzx3Y7T+MEzye+1CTcYf06ZTKso6UIa3RjnvaEzYBDChrPnJSAMeNokcEdJZsI9V1bmZbDpry2Adlnq0hwXh8tDqaOHrzSLafbs7YpBRjiFHCHfQKAcCuBkNvBdUSdprM48JFikqWLCSt/8+ZqCS8Nn15kVeB5n6/V0STe13jqJvftw7Xe4vMOHehRj2xSQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bNDqcRkmjTyPD0w7+Ga8rZU7Kf+EA1FF3HM36rfUbBM=; b=FbSnbN9GVM4bTybAAI+yvA3Kt+lAIZWlVTCHx6W4L4gnDwzLyV6DKxjN1Gyf5r84tPrKA0bR0343DZ5Cou3MWJBi8UMT9md1Hjsb+MYSwAKr0G3Wm6gTXNjD/WNWsUC9AuS7qAH5pkK4lne6Xqh69iME5w8j3fDu0YktjJS13DvwHenl6b9x2GI224BxKT/GBSzzs6yV2ZsVO5uG8h+e/fO9Skc+w0yAk8Lb0o0BZtFfUIQOwgJ9CHwjfgmSgI3kn/6Em2miAZUzc5bHtnonKJbEzLBCTjquW2KRLQgfRR0RX6BvTxjTNTaRj3rYnpNS2lDamMnlvLyRfIeRU/1I0g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bNDqcRkmjTyPD0w7+Ga8rZU7Kf+EA1FF3HM36rfUbBM=; b=9S77i0SUCmfBc//e9KzrFyjosu+/PgjvJEBWIwZlj02FJYCmhtwiuj7hhrxPsDSUvQgpGzWFYPm6MVeu3GEn3liAbOwsv2ZHaj/HP7Pffum219mMFGEPATjdt83Jf/NOKI85LAtCxS9j8DmyqIJyFdpRb0aLWbdma0QBuT9N84A= Received: from AS4P191CA0050.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:657::26) by VI0PR08MB10800.eurprd08.prod.outlook.com (2603:10a6:800:205::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.26; Fri, 1 Dec 2023 11:29:03 +0000 Received: from AM4PEPF00025F9C.EURPRD83.prod.outlook.com (2603:10a6:20b:657:cafe::a3) by AS4P191CA0050.outlook.office365.com (2603:10a6:20b:657::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.26 via Frontend Transport; Fri, 1 Dec 2023 11:29:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM4PEPF00025F9C.mail.protection.outlook.com (10.167.16.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.1 via Frontend Transport; Fri, 1 Dec 2023 11:29:03 +0000 Received: ("Tessian outbound e243565b0037:v228"); Fri, 01 Dec 2023 11:29:03 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 04ab321d1b13878f X-CR-MTA-TID: 64aa7808 Received: from 4844d89df90b.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 67B78653-F4D3-4BF7-819A-5396C813C671.1; Fri, 01 Dec 2023 11:28:52 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4844d89df90b.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 01 Dec 2023 11:28:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iy8hLW1Mpg2hMRpHpy1PtZPLe+4dFL+NH4/tyNDQF9kSjoBpEy3gDW8dqapG41qVxReYZaaL+6wKETAlP8vPuiunLgNLWUe9e+rx9w215XhawB0/T8VkS1F1tTBqjAtzyzyU+5Od7uADZ9ipraTxnFhYF174yjFkJ/4YSBSnItqSC5XPqZ4HtMLUzl1yhbtXptlOnh+V7ciQ6dUZC5fT/OPXvpKNj5lcN2mPqoc7Vg5r66s9kCJPtx8tGS4EYDjwISbJ0u77GShqGg+IFhillBHXjEzdOlCr8FWv6lTNscxR/RZ82y3HZDMItSsXqnNayBP4qDQzLGREfwTOUr4mow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bNDqcRkmjTyPD0w7+Ga8rZU7Kf+EA1FF3HM36rfUbBM=; b=IRCcplXwxgb+N2CLcahp19rzLRe0LVm/rkG+X6ghiCy4sXhPwpZ20hSVU7jcSz93J8yW4w2XKx3SGoiOjoaKlZVVVt2vUKk8yNBRTX+FcuQIm5gltVh960nzC6/5oFZmRmZuNc9M5e03ea9EtUefVKAHwff84dKXjfkGslAZLd6DBY5a1xQaC/26M564lgJKiAAgeBTOcpgeaQdPaZPT5CvDRDeBrSgFjWE9w57QdCBO3sGR+Kko4HfgchI2mD4V0fiX3t+B7Tyivod8eHbFWPL8w+dI9nfXe4G+r3ePPJJT/AyG5Ehv69uYVNejNIuPqclDrR3cM95znN/w/VQvdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bNDqcRkmjTyPD0w7+Ga8rZU7Kf+EA1FF3HM36rfUbBM=; b=9S77i0SUCmfBc//e9KzrFyjosu+/PgjvJEBWIwZlj02FJYCmhtwiuj7hhrxPsDSUvQgpGzWFYPm6MVeu3GEn3liAbOwsv2ZHaj/HP7Pffum219mMFGEPATjdt83Jf/NOKI85LAtCxS9j8DmyqIJyFdpRb0aLWbdma0QBuT9N84A= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DBBPR08MB6091.eurprd08.prod.outlook.com (2603:10a6:10:1f4::5) by DB5PR08MB10163.eurprd08.prod.outlook.com (2603:10a6:10:4a2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.22; Fri, 1 Dec 2023 11:28:50 +0000 Received: from DBBPR08MB6091.eurprd08.prod.outlook.com ([fe80::adea:b196:c278:cc83]) by DBBPR08MB6091.eurprd08.prod.outlook.com ([fe80::adea:b196:c278:cc83%7]) with mapi id 15.20.7046.024; Fri, 1 Dec 2023 11:28:50 +0000 Content-Type: multipart/mixed; boundary="------------Wz5bL3lKs3BZAxH0Qv6y5vxw" Message-ID: <85bf6edd-748e-492f-a511-3bdb53edf49a@arm.com> Date: Fri, 1 Dec 2023 11:28:48 +0000 User-Agent: Mozilla Thunderbird Content-Language: en-US To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>, Kyrylo Tkachov <kyrylo.tkachov@arm.com> From: Saurabh Jha <saurabh.jha@arm.com> Subject: [PATCH] testsuite, arm: Fix up pr112337.c test X-ClientProxiedBy: LO2P265CA0493.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::18) To DBBPR08MB6091.eurprd08.prod.outlook.com (2603:10a6:10:1f4::5) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DBBPR08MB6091:EE_|DB5PR08MB10163:EE_|AM4PEPF00025F9C:EE_|VI0PR08MB10800:EE_ X-MS-Office365-Filtering-Correlation-Id: 24bda9e3-94e4-4c72-2aab-08dbf260b8eb x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Th2DQPVUAj4XSgbCAB2xbb7p9ZSwoi22lLoDkpaAG8T87uWJ/NGoB7cPeEjorLy0J6u/Vw1M5G+bdkETXbRfYvazh48cLXtvRKxxVQaj7Oqgltx5dETwEk2HxQNfBnrcB4KxDhb8PLOqj3QUSMkUEz3SRIVVIBbl953Pe9mEJm3UfDcLf1DuDJIDWa0hsmXt9AGrgkLE2IZl/NsCZ7Z+4DjKsvxSejuq9TQ5WE4Y2RNqtO1cNn3n5Ow/XOakcSlToZZcL9dLyMgDcSC0ZV72ZIvwWqmM+DpEsDxUjcDcaqeYGTaZTDRKzaL1Lu1iXOByTA+1WOMFiBe6k+21nrH+/+z8s3YpzaqGwNguV1BAl/ABD1b1kMaNwttC0IHMk60MjsbWCAUfUpmYlAa8n4gpCAszbowctg1s3aVm34ZVHiIfv/YPng6a38KEtaO5ZXuYV2WQCrNaX0Hnvnk20EdxzBRuR8gu1YB1tu+yALQx+QzqS8SGNJ3JP3QSLsLm3qV5hndkJtY0tEbQxGVPg+txAt5sTqJYeHxuLPv7LzXYho0MRG8otCCxJ74v2K/XaW6thtJ0CvEa9tXT2Ft+POKNrRASogYkzYsdlR3rfYP0cyWpfiZATmV5eSTyaaqfbuy0EZVxz27SWApu4OSnLoA95FDSIZTV+8ILKiDTSQS5VBc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR08MB6091.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(39850400004)(366004)(376002)(346002)(396003)(230922051799003)(451199024)(64100799003)(1800799012)(186009)(38100700002)(316002)(86362001)(26005)(6636002)(66946007)(66476007)(110136005)(66556008)(235185007)(2616005)(83380400001)(2906002)(31696002)(44832011)(84970400001)(33964004)(6506007)(6512007)(8936002)(6486002)(8676002)(478600001)(41300700001)(31686004)(36756003)(5660300002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB10163 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM4PEPF00025F9C.EURPRD83.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3e45def3-5d9e-4ff7-691e-08dbf260b0db X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KNGWSlqu3VSGfaCsFjfzl2C1J72QYLu5w77qdvUbFocBI6zZci1Uj0j/c+Er/fNV5+Iwm3uCZSCg1VOwR2mqFyJrhDyLofFMWuUFNamh/tp+0zVxfk7Pj4+G6WLNHkMeK8f3teW0N6ZdXCy4Em/+E6/SLzfWCz0w6eWBFcJ46zzhui8oz6JiLTH6mdo5KgBeraWK1q3t5/gXXFPZFBu7T2G9fVfLcfC0OxCD5j3mVnRtLs0VN2PnUSBZI/Jy+bojpc/QkgvJvAL1LvAVEzMY2YonOwdRQoBsRipe5/P3XArCMmVuggh+Lo714lrWYv+ptvcey0qMNB9IV/+ZhD/JywNxrZNWVwmNnqXxc+duqV7L+qmFrYtbIhJtbQeAWypV6v78cYTRFcPqkOdwyHuJL9ELnkYRcy+7wO8znX7TYKxAv2dJ4/sh4CFQWcHMeD7gARl7YNuASW/ds2fYDCfSoVyaVkYKAI9OkLJlzttpfDaOo0LVbjDNV4HRFCq0IkClTxMbCgPyhNbYbxPSKHCF5k81q3zpHfZ2XZaKyaCDaO3ZNL5U2IVuGUJz1ctBQ9jnvDgMCMQGZjaWPrF1XszBxjsDalt3bF/aPZWWwwEwzueaYcJZwSXNe/oVk3KbluBFCCBX7yzmspVXU79RfLPHigynw8LbTNRI/ITxsETF2PSlf/1sug08/DJl48n9HD0fUgb6BTk5bwObcKJL21GN+tvX5i0NOTGgi3wdDwx58gouiHpF5PMnfXnLJekWMwYK1YhWj+XiJbKna/5X4g8PfGNkQCJTOe+cpghFAMMnEzk= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230031)(4636009)(346002)(396003)(136003)(376002)(39860400002)(230922051799003)(1800799012)(82310400011)(186009)(64100799003)(451199024)(46966006)(40470700004)(36840700001)(84970400001)(40480700001)(31686004)(40460700003)(2616005)(36860700001)(47076005)(356005)(81166007)(2906002)(5660300002)(235185007)(41300700001)(83380400001)(82740400003)(33964004)(6512007)(336012)(36756003)(6506007)(26005)(6486002)(70206006)(110136005)(70586007)(478600001)(44832011)(8676002)(31696002)(6636002)(8936002)(86362001)(316002)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2023 11:29:03.5634 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 24bda9e3-94e4-4c72-2aab-08dbf260b8eb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM4PEPF00025F9C.EURPRD83.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR08MB10800 X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org |
Series |
testsuite, arm: Fix up pr112337.c test
|
|
Checks
Context | Check | Description |
---|---|---|
linaro-tcwg-bot/tcwg_gcc_build--master-arm | success | Testing passed |
linaro-tcwg-bot/tcwg_gcc_build--master-aarch64 | success | Testing passed |
linaro-tcwg-bot/tcwg_gcc_check--master-aarch64 | success | Testing passed |
Commit Message
Saurabh Jha
Dec. 1, 2023, 11:28 a.m. UTC
Hey,
I introduced this test "gcc/testsuite/gcc.target/arm/mve/pr112337.c" in this commit 2365aae84de030bbb006edac18c9314812fc657b before. This had an error which I unfortunately missed. This patch fixes that test.
Did regression testing on arm-none-eabi and found no regressions. Output of running gcc/contrib/compare_tests is this:
"""
Tests that now work, but didn't before (2 tests):
arm-eabi-aem/-marm/-march=armv7-a/-mfpu=vfpv3-d16/-mfloat-abi=softfp: gcc.target/arm/mve/pr112337.c (test for excess errors)
arm-eabi-aem/-mthumb/-march=armv8-a/-mfpu=crypto-neon-fp-armv8/-mfloat-abi=hard: gcc.target/arm/mve/pr112337.c (test for excess errors)
"""
Ok for trunk? I don't have commit access so could someone please commit on my behalf?
Regards,
Saurabh
gcc/testsuite/ChangeLog:
* gcc.target/arm/mve/pr112337.c: Fix the testcase
From 2365aae84de030bbb006edac18c9314812fc657b Mon Sep 17 00:00:00 2001
From: Saurabh Jha <saujha01@e130340.arm.com>
Date: Tue, 28 Nov 2023 13:05:58 +0000
Subject: [PATCH] testsuite: Fix up pr112337.c test
---
gcc/testsuite/gcc.target/arm/mve/pr112337.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On 01/12/2023 11:28, Saurabh Jha wrote: > Hey, > > I introduced this test "gcc/testsuite/gcc.target/arm/mve/pr112337.c" in this commit 2365aae84de030bbb006edac18c9314812fc657b before. This had an error which I unfortunately missed. This patch fixes that test. > > Did regression testing on arm-none-eabi and found no regressions. Output of running gcc/contrib/compare_tests is this: > > """ > Tests that now work, but didn't before (2 tests): > > arm-eabi-aem/-marm/-march=armv7-a/-mfpu=vfpv3-d16/-mfloat-abi=softfp: gcc.target/arm/mve/pr112337.c (test for excess errors) > arm-eabi-aem/-mthumb/-march=armv8-a/-mfpu=crypto-neon-fp-armv8/-mfloat-abi=hard: gcc.target/arm/mve/pr112337.c (test for excess errors) > """ > > Ok for trunk? I don't have commit access so could someone please commit on my behalf? > > Regards, > Saurabh > > gcc/testsuite/ChangeLog: > > * gcc.target/arm/mve/pr112337.c: Fix the testcase Hmm, could this be related to the changes Christophe made recently to change the way MVE vector types were set up internally? If so, this might indicate an issue that's going to affect real users with existing code. Christophe? R.
On Fri, 1 Dec 2023 at 13:44, Richard Earnshaw (lists) <Richard.Earnshaw@arm.com> wrote: > > On 01/12/2023 11:28, Saurabh Jha wrote: > > Hey, > > > > I introduced this test "gcc/testsuite/gcc.target/arm/mve/pr112337.c" in this commit 2365aae84de030bbb006edac18c9314812fc657b before. This had an error which I unfortunately missed. This patch fixes that test. > > > > Did regression testing on arm-none-eabi and found no regressions. Output of running gcc/contrib/compare_tests is this: > > > > """ > > Tests that now work, but didn't before (2 tests): > > > > arm-eabi-aem/-marm/-march=armv7-a/-mfpu=vfpv3-d16/-mfloat-abi=softfp: gcc.target/arm/mve/pr112337.c (test for excess errors) > > arm-eabi-aem/-mthumb/-march=armv8-a/-mfpu=crypto-neon-fp-armv8/-mfloat-abi=hard: gcc.target/arm/mve/pr112337.c (test for excess errors) > > """ > > > > Ok for trunk? I don't have commit access so could someone please commit on my behalf? > > > > Regards, > > Saurabh > > > > gcc/testsuite/ChangeLog: > > > > * gcc.target/arm/mve/pr112337.c: Fix the testcase > > > Hmm, could this be related to the changes Christophe made recently to change the way MVE vector types were set up internally? If so, this might indicate an issue that's going to affect real users with existing code. > My change was only about vector types, here the problem is with a pointer to a scalar. Anyway, I ran the test with my commit reverted and it still fails in the same way, so I think this patch is needed. Thanks, Christophe > Christophe? > > R.
On 01/12/2023 13:45, Christophe Lyon wrote: > On Fri, 1 Dec 2023 at 13:44, Richard Earnshaw (lists) > <Richard.Earnshaw@arm.com> wrote: >> >> On 01/12/2023 11:28, Saurabh Jha wrote: >>> Hey, >>> >>> I introduced this test "gcc/testsuite/gcc.target/arm/mve/pr112337.c" in this commit 2365aae84de030bbb006edac18c9314812fc657b before. This had an error which I unfortunately missed. This patch fixes that test. >>> >>> Did regression testing on arm-none-eabi and found no regressions. Output of running gcc/contrib/compare_tests is this: >>> >>> """ >>> Tests that now work, but didn't before (2 tests): >>> >>> arm-eabi-aem/-marm/-march=armv7-a/-mfpu=vfpv3-d16/-mfloat-abi=softfp: gcc.target/arm/mve/pr112337.c (test for excess errors) >>> arm-eabi-aem/-mthumb/-march=armv8-a/-mfpu=crypto-neon-fp-armv8/-mfloat-abi=hard: gcc.target/arm/mve/pr112337.c (test for excess errors) >>> """ >>> >>> Ok for trunk? I don't have commit access so could someone please commit on my behalf? >>> >>> Regards, >>> Saurabh >>> >>> gcc/testsuite/ChangeLog: >>> >>> * gcc.target/arm/mve/pr112337.c: Fix the testcase >> >> >> Hmm, could this be related to the changes Christophe made recently to change the way MVE vector types were set up internally? If so, this might indicate an issue that's going to affect real users with existing code. >> > > My change was only about vector types, here the problem is with a > pointer to a scalar. > Anyway, I ran the test with my commit reverted and it still fails in > the same way, so I think this patch is needed. > > Thanks, > > Christophe > >> Christophe? >> >> R. Ok, thanks for checking. In that case, Saurabh, your patch is OK, but please change 'Fix testcase' to 'Use int32_t instead of int.' Note that ChangeLog entries end with a full stop. R.
On 12/1/2023 2:10 PM, Richard Earnshaw (lists) wrote: > On 01/12/2023 13:45, Christophe Lyon wrote: >> On Fri, 1 Dec 2023 at 13:44, Richard Earnshaw (lists) >> <Richard.Earnshaw@arm.com> wrote: >>> On 01/12/2023 11:28, Saurabh Jha wrote: >>>> Hey, >>>> >>>> I introduced this test "gcc/testsuite/gcc.target/arm/mve/pr112337.c" in this commit 2365aae84de030bbb006edac18c9314812fc657b before. This had an error which I unfortunately missed. This patch fixes that test. >>>> >>>> Did regression testing on arm-none-eabi and found no regressions. Output of running gcc/contrib/compare_tests is this: >>>> >>>> """ >>>> Tests that now work, but didn't before (2 tests): >>>> >>>> arm-eabi-aem/-marm/-march=armv7-a/-mfpu=vfpv3-d16/-mfloat-abi=softfp: gcc.target/arm/mve/pr112337.c (test for excess errors) >>>> arm-eabi-aem/-mthumb/-march=armv8-a/-mfpu=crypto-neon-fp-armv8/-mfloat-abi=hard: gcc.target/arm/mve/pr112337.c (test for excess errors) >>>> """ >>>> >>>> Ok for trunk? I don't have commit access so could someone please commit on my behalf? >>>> >>>> Regards, >>>> Saurabh >>>> >>>> gcc/testsuite/ChangeLog: >>>> >>>> * gcc.target/arm/mve/pr112337.c: Fix the testcase >>> >>> Hmm, could this be related to the changes Christophe made recently to change the way MVE vector types were set up internally? If so, this might indicate an issue that's going to affect real users with existing code. >>> >> My change was only about vector types, here the problem is with a >> pointer to a scalar. >> Anyway, I ran the test with my commit reverted and it still fails in >> the same way, so I think this patch is needed. >> >> Thanks, >> >> Christophe >> >>> Christophe? >>> >>> R. > Ok, thanks for checking. In that case, Saurabh, your patch is OK, but please change 'Fix testcase' to 'Use int32_t instead of int.' > > Note that ChangeLog entries end with a full stop. > > R. Thank you for the feedback. Please find the updated ChangeLog below. gcc/testsuite/ChangeLog: * gcc.target/arm/mve/pr112337.c: Use int32_t instead of int. From 2365aae84de030bbb006edac18c9314812fc657b Mon Sep 17 00:00:00 2001 From: Saurabh Jha <saujha01@e130340.arm.com> Date: Tue, 28 Nov 2023 13:05:58 +0000 Subject: [PATCH] testsuite: Fix up pr112337.c test --- gcc/testsuite/gcc.target/arm/mve/pr112337.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/gcc.target/arm/mve/pr112337.c b/gcc/testsuite/gcc.target/arm/mve/pr112337.c index 8f491990088..d1a075ecd0e 100644 --- a/gcc/testsuite/gcc.target/arm/mve/pr112337.c +++ b/gcc/testsuite/gcc.target/arm/mve/pr112337.c @@ -5,8 +5,8 @@ #include <arm_mve.h> void g(int32x4_t); -void f(int, int, int, short, int *p) { - int *bias = p; +void f(int, int, int, short, int32_t *p) { + int32_t *bias = p; for (;;) { int32x4_t d = vldrwq_s32 (p); bias += 4;
Saurabh Jha <saurabh.jha@arm.com> writes: > On 12/1/2023 2:10 PM, Richard Earnshaw (lists) wrote: >> On 01/12/2023 13:45, Christophe Lyon wrote: >>> On Fri, 1 Dec 2023 at 13:44, Richard Earnshaw (lists) >>> <Richard.Earnshaw@arm.com> wrote: >>>> On 01/12/2023 11:28, Saurabh Jha wrote: >>>>> Hey, >>>>> >>>>> I introduced this test "gcc/testsuite/gcc.target/arm/mve/pr112337.c" in this commit 2365aae84de030bbb006edac18c9314812fc657b before. This had an error which I unfortunately missed. This patch fixes that test. >>>>> >>>>> Did regression testing on arm-none-eabi and found no regressions. Output of running gcc/contrib/compare_tests is this: >>>>> >>>>> """ >>>>> Tests that now work, but didn't before (2 tests): >>>>> >>>>> arm-eabi-aem/-marm/-march=armv7-a/-mfpu=vfpv3-d16/-mfloat-abi=softfp: gcc.target/arm/mve/pr112337.c (test for excess errors) >>>>> arm-eabi-aem/-mthumb/-march=armv8-a/-mfpu=crypto-neon-fp-armv8/-mfloat-abi=hard: gcc.target/arm/mve/pr112337.c (test for excess errors) >>>>> """ >>>>> >>>>> Ok for trunk? I don't have commit access so could someone please commit on my behalf? >>>>> >>>>> Regards, >>>>> Saurabh >>>>> >>>>> gcc/testsuite/ChangeLog: >>>>> >>>>> * gcc.target/arm/mve/pr112337.c: Fix the testcase >>>> >>>> Hmm, could this be related to the changes Christophe made recently to change the way MVE vector types were set up internally? If so, this might indicate an issue that's going to affect real users with existing code. >>>> >>> My change was only about vector types, here the problem is with a >>> pointer to a scalar. >>> Anyway, I ran the test with my commit reverted and it still fails in >>> the same way, so I think this patch is needed. >>> >>> Thanks, >>> >>> Christophe >>> >>>> Christophe? >>>> >>>> R. >> Ok, thanks for checking. In that case, Saurabh, your patch is OK, but please change 'Fix testcase' to 'Use int32_t instead of int.' >> >> Note that ChangeLog entries end with a full stop. >> >> R. > > Thank you for the feedback. Please find the updated ChangeLog below. > > gcc/testsuite/ChangeLog: > > * gcc.target/arm/mve/pr112337.c: Use int32_t instead of int. Thanks, pushed to trunk. Richard
diff --git a/gcc/testsuite/gcc.target/arm/mve/pr112337.c b/gcc/testsuite/gcc.target/arm/mve/pr112337.c index 8f491990088..d1a075ecd0e 100644 --- a/gcc/testsuite/gcc.target/arm/mve/pr112337.c +++ b/gcc/testsuite/gcc.target/arm/mve/pr112337.c @@ -5,8 +5,8 @@ #include <arm_mve.h> void g(int32x4_t); -void f(int, int, int, short, int *p) { - int *bias = p; +void f(int, int, int, short, int32_t *p) { + int32_t *bias = p; for (;;) { int32x4_t d = vldrwq_s32 (p); bias += 4;