Message ID | 1425646888-4332-1-git-send-email-jon.turney@dronecode.org.uk |
---|---|
State | New, archived |
Headers |
Received: (qmail 69068 invoked by alias); 6 Mar 2015 13:01:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 69057 invoked by uid 89); 6 Mar 2015 13:01:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL, BAYES_00, KAM_STOCKGEN, RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 X-HELO: rgout06.bt.lon5.cpcloud.co.uk Received: from rgout06.bt.lon5.cpcloud.co.uk (HELO rgout06.bt.lon5.cpcloud.co.uk) (65.20.0.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Mar 2015 13:01:46 +0000 X-OWM-Source-IP: 31.51.205.191(GB) X-OWM-Env-Sender: jonturney@btinternet.com X-CTCH-RefID: str=0001.0A090201.54F9A537.01C7, ss=1, re=0.001, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-Junkmail-Premium-Raw: score=27/50, refid=2.7.2:2015.3.5.621:17:27.888, ip=31.51.205.191, rules=__HAS_FROM, __TO_MALFORMED_2, __TO_NO_NAME, __SUBJ_ALPHA_END, __HAS_MSGID, __SANE_MSGID, __HAS_X_MAILER, __ANY_URI, __URI_NO_WWW, __URI_NO_PATH, BODYTEXTP_SIZE_3000_LESS, BODY_SIZE_1600_1699, __MIME_TEXT_ONLY, RDNS_GENERIC_POOLED, __URI_NS, SXL_IP_DYNAMIC[191.205.51.31.fur], HTML_00_01, HTML_00_10, BODY_SIZE_5000_LESS, RDNS_SUSP_GENERIC, RDNS_SUSP, BODY_SIZE_2000_LESS, BODY_SIZE_7000_LESS X-CTCH-Spam: Unknown Received: from localhost.localdomain (31.51.205.191) by rgout06.bt.lon5.cpcloud.co.uk (8.6.122.06) (authenticated as jonturney@btinternet.com) id 54F7816C003D4DE1; Fri, 6 Mar 2015 13:01:42 +0000 From: Jon TURNEY <jon.turney@dronecode.org.uk> To: gdb-patches@sourceware.org Cc: Jon TURNEY <jon.turney@dronecode.org.uk> Subject: [PATCH] testsuite: Don't set SYMBOL_PREFIX for x86_64-*-cygwin Date: Fri, 6 Mar 2015 13:01:28 +0000 Message-Id: <1425646888-4332-1-git-send-email-jon.turney@dronecode.org.uk> |
Commit Message
Jon Turney
March 6, 2015, 1:01 p.m. UTC
Exactly like x86_64-*-mingw, SYMBOL_PREFIX should not be set to "_" for
x86_64-*-cygwin
I'm not sure that testsuite results on x86_64-*-cygwin tell you a great deal,
but for the record:
-# of expected passes 20510
-# of unexpected failures 649
+# of expected passes 21456
+# of unexpected failures 729
# of unexpected successes 2
# of expected failures 42
-# of known failures 50
-# of untested testcases 90
-# of unresolved testcases 9
-# of unsupported tests 114
+# of known failures 52
+# of untested testcases 80
+# of unresolved testcases 184
+# of unsupported tests 118
ChangeLog/gdb/testuite:
2015-03-04 Jon TURNEY <jon.turney@dronecode.org.uk>
* lib/gdb.exp (gdb_target_symbol_prefix_flags): Don't set
SYMBOL_PREFIX for x86_64-*-cygwin.
Signed-off-by: Jon TURNEY <jon.turney@dronecode.org.uk>
---
gdb/testsuite/lib/gdb.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 03/06/2015 01:01 PM, Jon TURNEY wrote: > Exactly like x86_64-*-mingw, SYMBOL_PREFIX should not be set to "_" for > x86_64-*-cygwin > > I'm not sure that testsuite results on x86_64-*-cygwin tell you a great deal, > but for the record: > > -# of expected passes 20510 > -# of unexpected failures 649 > +# of expected passes 21456 > +# of unexpected failures 729 > # of unexpected successes 2 > # of expected failures 42 > -# of known failures 50 > -# of untested testcases 90 > -# of unresolved testcases 9 > -# of unsupported tests 114 > +# of known failures 52 > +# of untested testcases 80 > +# of unresolved testcases 184 > +# of unsupported tests 118 > > ChangeLog/gdb/testuite: > > 2015-03-04 Jon TURNEY <jon.turney@dronecode.org.uk> > > * lib/gdb.exp (gdb_target_symbol_prefix_flags): Don't set > SYMBOL_PREFIX for x86_64-*-cygwin. OK. Thanks, Pedro Alves
On 18/03/2015 23:34, Pedro Alves wrote: > On 03/06/2015 01:01 PM, Jon TURNEY wrote: >> Exactly like x86_64-*-mingw, SYMBOL_PREFIX should not be set to "_" for >> x86_64-*-cygwin [...] >> 2015-03-04 Jon TURNEY <jon.turney@dronecode.org.uk> >> >> * lib/gdb.exp (gdb_target_symbol_prefix_flags): Don't set >> SYMBOL_PREFIX for x86_64-*-cygwin. > > OK. I do not have write access, so can you apply this, please.
On 03/20/2015 04:06 PM, Jon TURNEY wrote: > On 18/03/2015 23:34, Pedro Alves wrote: >> On 03/06/2015 01:01 PM, Jon TURNEY wrote: >>> Exactly like x86_64-*-mingw, SYMBOL_PREFIX should not be set to "_" for >>> x86_64-*-cygwin > [...] >>> 2015-03-04 Jon TURNEY <jon.turney@dronecode.org.uk> >>> >>> * lib/gdb.exp (gdb_target_symbol_prefix_flags): Don't set >>> SYMBOL_PREFIX for x86_64-*-cygwin. >> >> OK. > > I do not have write access, so can you apply this, please. Are you planning on working on GDB further? (That'd be awesome, btw.) We can get you write access so you can push your own patches. Let me know if you'd like that. Thanks, Pedro Alves
On 20/03/2015 17:23, Pedro Alves wrote: > On 03/20/2015 04:06 PM, Jon TURNEY wrote: >> On 18/03/2015 23:34, Pedro Alves wrote: >>> On 03/06/2015 01:01 PM, Jon TURNEY wrote: >>>> Exactly like x86_64-*-mingw, SYMBOL_PREFIX should not be set to "_" for >>>> x86_64-*-cygwin >> [...] >>>> 2015-03-04 Jon TURNEY <jon.turney@dronecode.org.uk> >>>> >>>> * lib/gdb.exp (gdb_target_symbol_prefix_flags): Don't set >>>> SYMBOL_PREFIX for x86_64-*-cygwin. >>> >>> OK. >> >> I do not have write access, so can you apply this, please. > > Are you planning on working on GDB further? (That'd be > awesome, btw.) We can get you write access so you can > push your own patches. Let me know if you'd like that. Yes, please. I already have a sourceware account, 'jturney'.
On 23/03/2015 14:39, Jon TURNEY wrote: > On 20/03/2015 17:23, Pedro Alves wrote: >> On 03/20/2015 04:06 PM, Jon TURNEY wrote: >>> On 18/03/2015 23:34, Pedro Alves wrote: >>>> On 03/06/2015 01:01 PM, Jon TURNEY wrote: >>>>> Exactly like x86_64-*-mingw, SYMBOL_PREFIX should not be set to "_" >>>>> for >>>>> x86_64-*-cygwin >>> [...] >>>>> 2015-03-04 Jon TURNEY <jon.turney@dronecode.org.uk> >>>>> >>>>> * lib/gdb.exp (gdb_target_symbol_prefix_flags): Don't set >>>>> SYMBOL_PREFIX for x86_64-*-cygwin. >>>> >>>> OK. >>> >>> I do not have write access, so can you apply this, please. >> >> Are you planning on working on GDB further? (That'd be >> awesome, btw.) We can get you write access so you can >> push your own patches. Let me know if you'd like that. > > Yes, please. So it seems I do have write access, although I didn't know this :-) Can I go ahead and commit this?
On 03/25/2015 05:51 PM, Jon TURNEY wrote: > On 23/03/2015 14:39, Jon TURNEY wrote: >> On 20/03/2015 17:23, Pedro Alves wrote: >>> On 03/20/2015 04:06 PM, Jon TURNEY wrote: >>>> On 18/03/2015 23:34, Pedro Alves wrote: >>>>> On 03/06/2015 01:01 PM, Jon TURNEY wrote: >>>>>> Exactly like x86_64-*-mingw, SYMBOL_PREFIX should not be set to "_" >>>>>> for >>>>>> x86_64-*-cygwin >>>> [...] >>>>>> 2015-03-04 Jon TURNEY <jon.turney@dronecode.org.uk> >>>>>> >>>>>> * lib/gdb.exp (gdb_target_symbol_prefix_flags): Don't set >>>>>> SYMBOL_PREFIX for x86_64-*-cygwin. >>>>> >>>>> OK. >>>> >>>> I do not have write access, so can you apply this, please. >>> >>> Are you planning on working on GDB further? (That'd be >>> awesome, btw.) We can get you write access so you can >>> push your own patches. Let me know if you'd like that. >> >> Yes, please. > > So it seems I do have write access, although I didn't know this :-) > :-) > Can I go ahead and commit this? Yes. Please add yourself to write-after-approval section of the gdb/MAINTAINERS file. No need for approval for that one. Just post the patch/commit to the list for the archives. Thanks, Pedro Alves
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index f274b64..0041adf 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -4998,7 +4998,7 @@ proc core_find {binfile {deletefiles {}} {arg ""}} { # TODO: find out automatically if the target needs this. proc gdb_target_symbol_prefix_flags {} { - if { [istarget "*-*-cygwin*"] || [istarget "i?86-*-mingw*"] + if { [istarget "i?86-*-cygwin*"] || [istarget "i?86-*-mingw*"] || [istarget "*-*-msdosdjgpp*"] || [istarget "*-*-go32*"] } { return "additional_flags=-DSYMBOL_PREFIX=\"_\"" } else {