[gdb/aarch64] Add new debug architecture version

Message ID 20230425142252.754998-1-luis.machado@arm.com
State New
Headers
Series [gdb/aarch64] Add new debug architecture version |

Commit Message

Luis Machado April 25, 2023, 2:22 p.m. UTC
  Teach gdb about a new debug architecture version for AArch64 (0x11).

No user-visible changes.

Regression-tested on aarch64-linux Ubuntu 20.04/22.04.

Signed-off-by: Luis Machado <luis.machado@arm.com>
---
 gdb/nat/aarch64-hw-point.h       | 2 ++
 gdb/nat/aarch64-linux-hw-point.c | 2 ++
 2 files changed, 4 insertions(+)
  

Comments

Luis Machado April 26, 2023, 6:01 a.m. UTC | #1
On 4/25/23 15:22, Luis Machado via Gdb-patches wrote:
> Teach gdb about a new debug architecture version for AArch64 (0x11).
> 
> No user-visible changes.
> 
> Regression-tested on aarch64-linux Ubuntu 20.04/22.04.
> 
> Signed-off-by: Luis Machado <luis.machado@arm.com>
> ---
>   gdb/nat/aarch64-hw-point.h       | 2 ++
>   gdb/nat/aarch64-linux-hw-point.c | 2 ++
>   2 files changed, 4 insertions(+)
> 
> diff --git a/gdb/nat/aarch64-hw-point.h b/gdb/nat/aarch64-hw-point.h
> index f4662f7c782..c19681422da 100644
> --- a/gdb/nat/aarch64-hw-point.h
> +++ b/gdb/nat/aarch64-hw-point.h
> @@ -59,6 +59,8 @@
>   #define AARCH64_DEBUG_ARCH_V8_2 0x8
>   #define AARCH64_DEBUG_ARCH_V8_4 0x9
>   #define AARCH64_DEBUG_ARCH_V8_8 0x10
> +/* Armv8.9 debug architecture.  */
> +#define AARCH64_DEBUG_ARCH_V8_9 0x11
>   
>   /* ptrace expects control registers to be formatted as follows:
>   
> diff --git a/gdb/nat/aarch64-linux-hw-point.c b/gdb/nat/aarch64-linux-hw-point.c
> index ccb47cd5aa2..8cf8b31530c 100644
> --- a/gdb/nat/aarch64-linux-hw-point.c
> +++ b/gdb/nat/aarch64-linux-hw-point.c
> @@ -234,6 +234,8 @@ compatible_debug_arch (unsigned int debug_arch)
>       return true;
>     if (debug_arch == AARCH64_DEBUG_ARCH_V8_8)
>       return true;
> +  if (debug_arch == AARCH64_DEBUG_ARCH_V8_9)
> +    return true;
>   
>     return false;
>   }

Pushed now.
  

Patch

diff --git a/gdb/nat/aarch64-hw-point.h b/gdb/nat/aarch64-hw-point.h
index f4662f7c782..c19681422da 100644
--- a/gdb/nat/aarch64-hw-point.h
+++ b/gdb/nat/aarch64-hw-point.h
@@ -59,6 +59,8 @@ 
 #define AARCH64_DEBUG_ARCH_V8_2 0x8
 #define AARCH64_DEBUG_ARCH_V8_4 0x9
 #define AARCH64_DEBUG_ARCH_V8_8 0x10
+/* Armv8.9 debug architecture.  */
+#define AARCH64_DEBUG_ARCH_V8_9 0x11
 
 /* ptrace expects control registers to be formatted as follows:
 
diff --git a/gdb/nat/aarch64-linux-hw-point.c b/gdb/nat/aarch64-linux-hw-point.c
index ccb47cd5aa2..8cf8b31530c 100644
--- a/gdb/nat/aarch64-linux-hw-point.c
+++ b/gdb/nat/aarch64-linux-hw-point.c
@@ -234,6 +234,8 @@  compatible_debug_arch (unsigned int debug_arch)
     return true;
   if (debug_arch == AARCH64_DEBUG_ARCH_V8_8)
     return true;
+  if (debug_arch == AARCH64_DEBUG_ARCH_V8_9)
+    return true;
 
   return false;
 }