Message ID | 20230413151018.31791-1-palmer@rivosinc.com |
---|---|
State | Committed |
Commit | e6b050da8a4513ab37fd3699c7a963421fbe4d81 |
Headers |
Return-Path: <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 664B73857BB2 for <patchwork@sourceware.org>; Thu, 13 Apr 2023 15:12:15 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id B32243858D20 for <gcc-patches@gcc.gnu.org>; Thu, 13 Apr 2023 15:11:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B32243858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pl1-x634.google.com with SMTP id p8so15352165plk.9 for <gcc-patches@gcc.gnu.org>; Thu, 13 Apr 2023 08:11:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1681398718; x=1683990718; h=to:from:cc:content-transfer-encoding:mime-version:message-id:date :subject:from:to:cc:subject:date:message-id:reply-to; bh=C9Pvd/fl8cuH2/MC675+dKxIvL/IxUeBMdw4wOqdy8A=; b=H/vY7ynfX6G9TA1OOjT5l8XeeKKzqaxm9IwxT3d87G0E9S2X4W1A9K/paCoV8c5par 67+PsRju3gdNGGO64/cN5WD96iaElXDdvSPczA2XZLjxFolGBqf3l7qDlDc/fgoHLQeV ig51GF5f0v48amtTs7ChD665jGgXrNH0vK4M17rpOfD8O2zk+B2EqesFpuvCVyZaj/Fm MGUUP0EwzW3nYrYS2kWzbFvpviNVBAJ6Q8j7re6UWwzuEg9eR8CVTRbeCLROy2b2GnqZ PK6xJPsB9aKvex4v/fpI1s+kiS0LpUEevY1m2mqEEY3YntuGPI/hcZhcnQkcksWfaTFG VI1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681398718; x=1683990718; h=to:from:cc:content-transfer-encoding:mime-version:message-id:date :subject:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=C9Pvd/fl8cuH2/MC675+dKxIvL/IxUeBMdw4wOqdy8A=; b=NDBPAwqDxDzsi9m6WFnYZ9s11eEFTMVwPCEnndVY1W/aXm5QwC0L9Qwf4eKPW21CxB KNalCMceVuTdKA5R00+/PEGRFAPXtEdqEnMYSKZatTPLVwe5zi/dbrQcMiiAnZPELvz1 3Skh6HTnLLBJ591ZV8Vbq8Zqx4kMI2XWDxsCyGMedKHnACdj9rvCiIcFyJeXr5eKT0Yp f3UilU+00YQaJxrO9zCFtUrcTFNJF3Om7RFUK6wH3GohAS4LJC65fyRDW7kHJ8B5D8hX OPBbMx7S5E6BN4n+RiGiNiotvDYdUZoLml2srMF5oGIxK7ihxvPuLebxMJ0IJLO+deFt KVJA== X-Gm-Message-State: AAQBX9elIhtoVcZnIhSqq3joz+GGqtsjPoDeUDx8YMRstH0J0HNoNA2W RL1nEar3juppLPqEHnrj0QgyNQ== X-Google-Smtp-Source: AKy350Z1hGEC1PQct7ES34gr79rRHzviekIY/tmhVzfdYk0UW4OulTDkdVnowu+BbNAlMBFXaJ8mAw== X-Received: by 2002:a17:902:7893:b0:1a1:dd2a:fe6c with SMTP id q19-20020a170902789300b001a1dd2afe6cmr2615506pll.53.1681398717557; Thu, 13 Apr 2023 08:11:57 -0700 (PDT) Received: from localhost ([50.221.140.188]) by smtp.gmail.com with ESMTPSA id jd14-20020a170903260e00b001a653a32173sm1619960plb.29.2023.04.13.08.11.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 08:11:57 -0700 (PDT) Subject: [PATCH] RISC-V: Set the ABI for the RVV tests Date: Thu, 13 Apr 2023 08:10:19 -0700 Message-Id: <20230413151018.31791-1-palmer@rivosinc.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: Palmer Dabbelt <palmer@rivosinc.com> From: Palmer Dabbelt <palmer@rivosinc.com> To: gcc-patches@gcc.gnu.org X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> |
Series |
RISC-V: Set the ABI for the RVV tests
|
|
Commit Message
Palmer Dabbelt
April 13, 2023, 3:10 p.m. UTC
The RVV test harness currently sets the ISA according to the target tuple, but doesn't also set the ABI. This just sets the ABI to match the ISA, though we should really also be respecting the user's specific ISA to test. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/rvv.exp (gcc_mabi): New variable. --- I've still got some rv32-related multilib failures so there might be something else going on here, but I think at least this is going to be necessary. --- gcc/testsuite/gcc.target/riscv/rvv/rvv.exp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Comments
Ok, thanks :) Palmer Dabbelt <palmer@rivosinc.com>於 2023年4月13日 週四,23:12寫道: > The RVV test harness currently sets the ISA according to the target > tuple, but doesn't also set the ABI. This just sets the ABI to match > the ISA, though we should really also be respecting the user's specific > ISA to test. > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/rvv/rvv.exp (gcc_mabi): New variable. > --- > I've still got some rv32-related multilib failures so there might be > something else going on here, but I think at least this is going to be > necessary. > --- > gcc/testsuite/gcc.target/riscv/rvv/rvv.exp | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp > b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp > index 7a9a2b6ac48..4b5509db385 100644 > --- a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp > +++ b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp > @@ -31,15 +31,17 @@ if ![info exists DEFAULT_CFLAGS] then { > } > > set gcc_march "rv64gcv_zfh" > +set gcc_mabi "lp64d" > if [istarget riscv32-*-*] then { > set gcc_march "rv32gcv_zfh" > + set gcc_mabi "ilp32d" > } > > # Initialize `dg'. > dg-init > > # Main loop. > -set CFLAGS "$DEFAULT_CFLAGS -march=$gcc_march -O3" > +set CFLAGS "$DEFAULT_CFLAGS -march=$gcc_march -mabi=$gcc_mabi -O3" > dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/base/*.\[cS\]]] \ > "" $CFLAGS > gcc-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/vsetvl/*.\[cS\]]] > \ > -- > 2.39.2 > >
On Thu, 13 Apr 2023 08:59:58 PDT (-0700), gcc-patches@gcc.gnu.org wrote: > Ok, thanks :) Committed. > > Palmer Dabbelt <palmer@rivosinc.com>於 2023年4月13日 週四,23:12寫道: > >> The RVV test harness currently sets the ISA according to the target >> tuple, but doesn't also set the ABI. This just sets the ABI to match >> the ISA, though we should really also be respecting the user's specific >> ISA to test. >> >> gcc/testsuite/ChangeLog: >> >> * gcc.target/riscv/rvv/rvv.exp (gcc_mabi): New variable. >> --- >> I've still got some rv32-related multilib failures so there might be >> something else going on here, but I think at least this is going to be >> necessary. >> --- >> gcc/testsuite/gcc.target/riscv/rvv/rvv.exp | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp >> b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp >> index 7a9a2b6ac48..4b5509db385 100644 >> --- a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp >> +++ b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp >> @@ -31,15 +31,17 @@ if ![info exists DEFAULT_CFLAGS] then { >> } >> >> set gcc_march "rv64gcv_zfh" >> +set gcc_mabi "lp64d" >> if [istarget riscv32-*-*] then { >> set gcc_march "rv32gcv_zfh" >> + set gcc_mabi "ilp32d" >> } >> >> # Initialize `dg'. >> dg-init >> >> # Main loop. >> -set CFLAGS "$DEFAULT_CFLAGS -march=$gcc_march -O3" >> +set CFLAGS "$DEFAULT_CFLAGS -march=$gcc_march -mabi=$gcc_mabi -O3" >> dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/base/*.\[cS\]]] \ >> "" $CFLAGS >> gcc-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/vsetvl/*.\[cS\]]] >> \ >> -- >> 2.39.2 >> >>
diff --git a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp index 7a9a2b6ac48..4b5509db385 100644 --- a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp +++ b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp @@ -31,15 +31,17 @@ if ![info exists DEFAULT_CFLAGS] then { } set gcc_march "rv64gcv_zfh" +set gcc_mabi "lp64d" if [istarget riscv32-*-*] then { set gcc_march "rv32gcv_zfh" + set gcc_mabi "ilp32d" } # Initialize `dg'. dg-init # Main loop. -set CFLAGS "$DEFAULT_CFLAGS -march=$gcc_march -O3" +set CFLAGS "$DEFAULT_CFLAGS -march=$gcc_march -mabi=$gcc_mabi -O3" dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/base/*.\[cS\]]] \ "" $CFLAGS gcc-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/vsetvl/*.\[cS\]]] \