Message ID | 20230127172427.4132635-1-tromey@adacore.com |
---|---|
State | Committed |
Commit | f6210497fd7ff8f71c1421abb3dacdd4556dd097 |
Headers |
Return-Path: <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2DD7B385B503 for <patchwork@sourceware.org>; Fri, 27 Jan 2023 17:25:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2DD7B385B503 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1674840301; bh=cLUKc7GOGk8h706sfFd3xaEXIPlYPFFy+wRGzSbcHFI=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=J/1hz9Gu0PaejLOfAqmoQww8eNThrbOWZhOueVRJVLR1IwxG/CDUvqwnQrqTZZgKC PuLOGF1fjQKqx8BThqgSKpczwB91pXayfy2KN06/M4XtviZb3O69dz2jtaKXn9qCTL +6HkTHi/Ys7n2MjxaHNT+9Cnjd+UNaXdXHMre+CE= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by sourceware.org (Postfix) with ESMTPS id D09663858C00 for <gdb-patches@sourceware.org>; Fri, 27 Jan 2023 17:24:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D09663858C00 Received: by mail-il1-x12c.google.com with SMTP id i17so2404784ils.11 for <gdb-patches@sourceware.org>; Fri, 27 Jan 2023 09:24:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cLUKc7GOGk8h706sfFd3xaEXIPlYPFFy+wRGzSbcHFI=; b=X4KOHTdNfa25xsjil4ltvrNONgQE0fiJBqFo5D01Ax9PLEo+4yZVRX1lDI2cpcgXBr kVvKNrlL0NidIHo5o85OKswpi+jpUXIlsCcgsJ6rMt9bRswBp5ORq8pklSgEm7OPmjj2 2sEig7OjBQv/VH78sfx2yrc+Uly2yrJTOiLp1g+aha2ePKuLc4ZVAuebTVrDYc6NaRfO Gyq14bE8xfYNlGxey7gnEy6l4g02ObWEYPe9IRHSR6v2psRJW6cALHxmTO9iVd03FkEP yTQPX5LvzTnnDFoDwr0DS/GLlyxQc9zMCMEhD7yxgHb+UaZUmLZWH9zJhgOKTdDA4E/c lN4Q== X-Gm-Message-State: AO0yUKV2LQYrJDxu6/DFHXAScAijsTqTivUdz75VRhoim8L7qsCFYRdH O/AdeYS4okGslMeRVlRLEQDM0/rtCa4O+BTY X-Google-Smtp-Source: AK7set/lo72nJT3Pe2OYUHsgToPUwlSj1vcwulvBvdly1RmVmxDvii161rV+6VeCY36Ll9qxUcFicw== X-Received: by 2002:a05:6e02:1b82:b0:310:9276:730e with SMTP id h2-20020a056e021b8200b003109276730emr11906519ili.5.1674840277078; Fri, 27 Jan 2023 09:24:37 -0800 (PST) Received: from localhost.localdomain (75-166-146-144.hlrn.qwest.net. [75.166.146.144]) by smtp.gmail.com with ESMTPSA id c1-20020a92bd01000000b0030f5796e89fsm1366148ile.48.2023.01.27.09.24.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jan 2023 09:24:36 -0800 (PST) To: gdb-patches@sourceware.org Cc: Tom Tromey <tromey@adacore.com> Subject: [pushed] Invert test in gdb.ada/ptype_tagged_param.exp Date: Fri, 27 Jan 2023 10:24:27 -0700 Message-Id: <20230127172427.4132635-1-tromey@adacore.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=subscribe> From: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> Reply-To: Tom Tromey <tromey@adacore.com> Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> |
Series |
[pushed] Invert test in gdb.ada/ptype_tagged_param.exp
|
|
Commit Message
Tom Tromey
Jan. 27, 2023, 5:24 p.m. UTC
Simon pointed out that the kfail check in gdb.ada/ptype_tagged_param.exp is inverted. See: https://sourceware.org/pipermail/gdb-patches/2023-January/196296.html This patch fixes the problem. --- gdb/testsuite/gdb.ada/ptype_tagged_param.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 2023-01-27 5:24 p.m., Tom Tromey via Gdb-patches wrote: > Simon pointed out that the kfail check in > gdb.ada/ptype_tagged_param.exp is inverted. See: > > https://sourceware.org/pipermail/gdb-patches/2023-January/196296.html > > This patch fixes the problem. > --- > gdb/testsuite/gdb.ada/ptype_tagged_param.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.ada/ptype_tagged_param.exp b/gdb/testsuite/gdb.ada/ptype_tagged_param.exp > index eaf61ddde79..759b10f9b6a 100644 > --- a/gdb/testsuite/gdb.ada/ptype_tagged_param.exp > +++ b/gdb/testsuite/gdb.ada/ptype_tagged_param.exp > @@ -48,7 +48,7 @@ gdb_test_multiple "ptype s" "ptype s" { > pass $gdb_test_name > } > -re -wrap $nodebug { > - if {$has_runtime_debug_info} { > + if {!$has_runtime_debug_info} { > kfail "no debug info" $gdb_test_name Why is this a kfail instead of an xfail? Is there really a GDB bug here? > } else { > fail $gdb_test_name >
>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes: >> kfail "no debug info" $gdb_test_name Pedro> Why is this a kfail instead of an xfail? Is there really a GDB bug here? It's just my perennial inability to distinguish the two. There's no gdb bug, this seems to be a compiler issue. If changing it to xfail is correct, let me know and I will do it. And endeavor to remember that kfail is for gdb bugs. Tom
On 2023-01-27 9:01 p.m., Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes: > >>> kfail "no debug info" $gdb_test_name > > Pedro> Why is this a kfail instead of an xfail? Is there really a GDB bug here? > > It's just my perennial inability to distinguish the two. There's no gdb > bug, this seems to be a compiler issue. If changing it to xfail is > correct, let me know and I will do it. :-) Yes, kfail is correct. > And endeavor to remember that kfail is for gdb bugs. Here's how I memorize it: xfail - e(X)ternal issue kfail - (K)nown bug
>>>> kfail "no debug info" $gdb_test_name >> Pedro> Why is this a kfail instead of an xfail? Is there really a GDB bug here? >> >> It's just my perennial inability to distinguish the two. There's no gdb >> bug, this seems to be a compiler issue. If changing it to xfail is >> correct, let me know and I will do it. Pedro> :-) Pedro> Yes, kfail is correct. Confusing! But I think just a typo. I'm going to send a patch to change it. Tom
On 2023-01-30 3:03 p.m., Tom Tromey wrote: >>>>> kfail "no debug info" $gdb_test_name >>> > Pedro> Why is this a kfail instead of an xfail? Is there really a GDB bug here? >>> >>> It's just my perennial inability to distinguish the two. There's no gdb >>> bug, this seems to be a compiler issue. If changing it to xfail is >>> correct, let me know and I will do it. > > Pedro> :-) > > Pedro> Yes, kfail is correct. > > Confusing! But I think just a typo. Sorry! Yes, unfortunate typo. > I'm going to send a patch to change it. Thank you.
diff --git a/gdb/testsuite/gdb.ada/ptype_tagged_param.exp b/gdb/testsuite/gdb.ada/ptype_tagged_param.exp index eaf61ddde79..759b10f9b6a 100644 --- a/gdb/testsuite/gdb.ada/ptype_tagged_param.exp +++ b/gdb/testsuite/gdb.ada/ptype_tagged_param.exp @@ -48,7 +48,7 @@ gdb_test_multiple "ptype s" "ptype s" { pass $gdb_test_name } -re -wrap $nodebug { - if {$has_runtime_debug_info} { + if {!$has_runtime_debug_info} { kfail "no debug info" $gdb_test_name } else { fail $gdb_test_name